PMD Results

The following document contains the results of PMD

Files

org/apache/struts/action/ActionForm.java

ViolationLine
An empty statement (semicolon) not part of a loop151

org/apache/struts/action/ActionMapping.java

ViolationLine
These nested if statements could be combined73 - 75

org/apache/struts/action/ActionServlet.java

ViolationLine
An empty statement (semicolon) not part of a loop311
An empty statement (semicolon) not part of a loop867
These nested if statements could be combined1013 - 1039
These nested if statements could be combined1141 - 1160
These nested if statements could be combined1262 - 1281
These nested if statements could be combined1401 - 1435

org/apache/struts/action/RequestProcessor.java

ViolationLine
These nested if statements could be combined443 - 445
These nested if statements could be combined452 - 454

org/apache/struts/chain/commands/servlet/ExceptionHandler.java

ViolationLine
Avoid unused private fields such as 'log'42

org/apache/struts/chain/commands/servlet/PopulateActionForm.java

ViolationLine
Avoid unused private fields such as 'log'37

org/apache/struts/chain/commands/servlet/SelectLocale.java

ViolationLine
Avoid unused private fields such as 'log'36

org/apache/struts/chain/commands/servlet/ValidateActionForm.java

ViolationLine
These nested if statements could be combined59 - 65

org/apache/struts/chain/contexts/WebActionContext.java

ViolationLine
Overriding method merely calls super50 - 52

org/apache/struts/mock/MockActionServlet.java

ViolationLine
An empty statement (semicolon) not part of a loop59
Overriding method merely calls super102 - 105

org/apache/struts/mock/MockFormBean.java

ViolationLine
Do not use if statements that are always true or always false91

org/apache/struts/upload/CommonsMultipartRequestHandler.java

ViolationLine
Avoid empty catch blocks403 - 405

org/apache/struts/util/ImageButtonBean.java

ViolationLine
An empty statement (semicolon) not part of a loop52

org/apache/struts/util/RequestUtils.java

ViolationLine
An empty statement (semicolon) not part of a loop823

org/apache/struts/util/TokenProcessor.java

ViolationLine
Avoid unnecessary temporaries when converting primitives to Strings201

org/apache/struts/validator/Resources.java

ViolationLine
Avoid unused local variables such as 'msgBundle'293

org/apache/struts/validator/ValidatorPlugIn.java

ViolationLine
Avoid unused private fields such as 'config'76

org/apache/struts/validator/validwhen/ValidWhenLexer.java

ViolationLine
Avoid unused local variables such as 'theRetToken'70
Avoid unused local variables such as '_token'74
Avoid unused local variables such as '_saveIndex'264
Avoid unused local variables such as '_saveIndex'329
Avoid unused local variables such as '_saveIndex'381
Avoid unused local variables such as '_saveIndex'449
Avoid unused local variables such as '_saveIndex'478
Avoid unused local variables such as '_saveIndex'559
Avoid unused local variables such as '_saveIndex'580
Avoid unused local variables such as '_saveIndex'601
Avoid unused local variables such as '_saveIndex'622
Avoid unused local variables such as '_saveIndex'643
Avoid unused local variables such as '_saveIndex'664
Avoid unused local variables such as '_saveIndex'810
Avoid unused local variables such as '_saveIndex'832
Avoid unused local variables such as '_saveIndex'854
Avoid unused local variables such as '_saveIndex'875
Avoid unused local variables such as '_saveIndex'896
Avoid unused local variables such as '_saveIndex'918

org/apache/struts/validator/validwhen/ValidWhenParser.java

ViolationLine
These nested if statements could be combined104 - 106
These nested if statements could be combined110 - 112
An empty statement (semicolon) not part of a loop174
An empty statement (semicolon) not part of a loop177
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.429
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.443
Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead.445