Checkstyle Results

The following document contains the results of Checkstyle .

Summary

FilesInfosWarningsErrors
5653188

Files

FilesIWE
javax/servlet/jsp/jstl/sql/Result.java 070
javax/servlet/jsp/jstl/sql/ResultImpl.java 0202
javax/servlet/jsp/jstl/sql/ResultSupport.java 060
javax/servlet/jsp/jstl/sql/SQLExecutionTag.java 050
javax/servlet/jsp/jstl/sql/package.html 010
org/apache/commons/jelly/tags/sql/DataSourceUtil.java 0212
org/apache/commons/jelly/tags/sql/DataSourceWrapper.java 0250
org/apache/commons/jelly/tags/sql/DateParamTag.java 0180
org/apache/commons/jelly/tags/sql/DriverTag.java 0260
org/apache/commons/jelly/tags/sql/ParamTag.java 050
org/apache/commons/jelly/tags/sql/QueryTag.java 2320
org/apache/commons/jelly/tags/sql/ResultImpl.java 020
org/apache/commons/jelly/tags/sql/ResultImpl.java 0253
org/apache/commons/jelly/tags/sql/ResultSetTag.java 0110
org/apache/commons/jelly/tags/sql/RowTag.java 090
org/apache/commons/jelly/tags/sql/SetDataSourceTag.java 0300
org/apache/commons/jelly/tags/sql/SqlTagLibrary.java 010
org/apache/commons/jelly/tags/sql/SqlTagSupport.java 0251
org/apache/commons/jelly/tags/sql/TransactionTag.java 1340
org/apache/commons/jelly/tags/sql/UpdateTag.java 2150

javax/servlet/jsp/jstl/sql/Result.java

ErrorLine
Warning Redundant 'public' modifier. 48
Warning Redundant 'public' modifier. 57
Warning Redundant 'public' modifier. 64
Warning First sentence should end with a period. 66
Warning Redundant 'public' modifier. 71
Warning First sentence should end with a period. 73
Warning Redundant 'public' modifier. 79

javax/servlet/jsp/jstl/sql/ResultImpl.java

ErrorLine
Error Using the '.*' form of import should be avoided - java.sql.*. 19
Error Using the '.*' form of import should be avoided - java.util.*. 20
Warning Missing a Javadoc comment. 35
Warning Missing a Javadoc comment. 36
Warning Missing a Javadoc comment. 37
Warning Missing a Javadoc comment. 38
Warning Unused @param tag for 'startRow,'. 46
Warning Unused @param tag for 'maxRows,'. 47
Warning Unused @throws tag for 'if'. 48
Warning Expected @param tag for 'startRow'. 50
Warning Expected @param tag for 'maxRows'. 50
Warning Expected @throws tag for 'SQLException'. 51
Warning '{' should be on the previous line. 52
Warning '-' is not preceded with whitespace. 62
Warning '-' is not followed by whitespace. 62
Warning '-' is not preceded with whitespace. 87
Warning '-' is not followed by whitespace. 87
Warning '-' is not preceded with whitespace. 88
Warning '-' is not followed by whitespace. 88
Warning 'cast' is not followed by whitespace. 128
Warning First sentence should end with a period. 142
Warning First sentence should end with a period. 155

javax/servlet/jsp/jstl/sql/ResultSupport.java

ErrorLine
Warning Utility classes should not have a public or default constructor. 30
Warning Unused @param tag for 'ResultSet'. 36
Warning Expected @param tag for 'rs'. 40
Warning First sentence should end with a period. 48
Warning Unused @param tag for 'ResultSet'. 51
Warning Expected @param tag for 'rs'. 56

javax/servlet/jsp/jstl/sql/SQLExecutionTag.java

ErrorLine
Warning Unclosed HTML tag found: <code> parameter values for 26
Warning First sentence should end with a period. 48
Warning Unused @param tag for 'the'. 51
Warning Redundant 'public' modifier. 53
Warning Expected @param tag for 'value'. 53

javax/servlet/jsp/jstl/sql/package.html

ErrorLine
Warning Missing package documentation file.0

org/apache/commons/jelly/tags/sql/DataSourceUtil.java

ErrorLine
Warning Utility classes should not have a public or default constructor. 39
Warning Missing a Javadoc comment. 41
Warning Field 'ESCAPE' is used in only one method. 41
Warning Missing a Javadoc comment. 42
Warning Field 'TOKEN' is used in only one method. 42
Error Unused private field 'log'. 45
Warning Expected an @return tag. 53
Warning Expected @param tag for 'rawDataSource'. 53
Warning Expected @param tag for 'pc'. 53
Warning Expected @throws tag for 'JellyTagException'. 54
Error Assignment of parameter 'rawDataSource' is not allowed. 58
Warning '}' should be on the same line. 76
Warning '}' should be on the same line. 80
Warning '}' should be on the same line. 83
Warning First sentence should end with a period. 91
Warning Expected an @return tag. 94
Warning Expected @param tag for 'params'. 94
Warning Expected @throws tag for 'JellyTagException'. 94
Warning '4' is a magic number. 97
Warning '4' is a magic number. 108
Warning '}' should be on the same line. 115
Warning '}' should be on the same line. 129
Warning '3' is a magic number. 138

org/apache/commons/jelly/tags/sql/DataSourceWrapper.java

ErrorLine
Warning Missing a Javadoc comment. 42
Warning Field 'driverClassName' is used in only one method. 42
Warning Missing a Javadoc comment. 43
Warning Missing a Javadoc comment. 44
Warning Missing a Javadoc comment. 45
Warning Missing a Javadoc comment. 47
Warning Missing a Javadoc comment. 58
Warning Missing a Javadoc comment. 62
Warning Missing a Javadoc comment. 66
Warning Expected an @return tag. 74
Warning Expected @throws tag for 'SQLException'. 74
Warning '}' should be on the same line. 83
Warning ')' is preceded with whitespace. 93
Warning Expected an @return tag. 102
Warning Expected @param tag for 'username'. 102
Warning Expected @param tag for 'password'. 102
Warning Expected @throws tag for 'SQLException'. 103
Warning Expected an @return tag. 110
Warning Expected @throws tag for 'SQLException'. 110
Warning Expected an @return tag. 117
Warning Expected @throws tag for 'SQLException'. 117
Warning Expected @param tag for 'seconds'. 124
Warning Expected @throws tag for 'SQLException'. 124
Warning Expected @param tag for 'out'. 131
Warning Expected @throws tag for 'SQLException'. 131

org/apache/commons/jelly/tags/sql/DateParamTag.java

ErrorLine
Warning Missing a Javadoc comment. 39
Warning Field 'TIMESTAMP_TYPE' is used in only one method. 39
Warning Missing a Javadoc comment. 40
Warning Field 'TIME_TYPE' is used in only one method. 40
Warning Missing a Javadoc comment. 41
Warning Field 'DATE_TYPE' is used in only one method. 41
Warning Missing a Javadoc comment. 46
Warning Variable 'type' must be private and have accessor methods. 46
Warning Missing a Javadoc comment. 47
Warning Variable 'value' must be private and have accessor methods. 47
Warning Missing a Javadoc comment. 52
Warning Missing a Javadoc comment. 58
Warning Missing a Javadoc comment. 62
Warning Missing a Javadoc comment. 69
Warning Missing a Javadoc comment. 86
Warning '}' should be on the same line. 92
Warning '}' should be on the same line. 97
Warning '}' should be on the same line. 102

org/apache/commons/jelly/tags/sql/DriverTag.java

ErrorLine
Warning Missing a Javadoc comment. 30
Warning Field 'DRIVER_CLASS_NAME' is used in only one method. 30
Warning Missing a Javadoc comment. 32
Warning Field 'JDBC_URL' is used in only one method. 32
Warning Missing a Javadoc comment. 33
Warning Field 'USER_NAME' is used in only one method. 33
Warning Missing a Javadoc comment. 34
Warning Field 'PASSWORD' is used in only one method. 34
Warning Missing a Javadoc comment. 36
Warning Missing a Javadoc comment. 37
Warning Missing a Javadoc comment. 38
Warning Field 'scope' is used in only one method. 38
Warning Missing a Javadoc comment. 39
Warning Missing a Javadoc comment. 40
Warning Missing a Javadoc comment. 45
Warning Missing a Javadoc comment. 49
Warning Expected @param tag for 'scopeName'. 58
Warning Missing a Javadoc comment. 62
Warning Missing a Javadoc comment. 66
Warning Missing a Javadoc comment. 73
Warning '}' should be on the same line. 77
Warning Missing a Javadoc comment. 90
Warning Missing a Javadoc comment. 97
Warning Missing a Javadoc comment. 104
Warning Missing a Javadoc comment. 111
Warning Missing a Javadoc comment. 115

org/apache/commons/jelly/tags/sql/ParamTag.java

ErrorLine
Warning Missing a Javadoc comment. 33
Warning Variable 'value' must be private and have accessor methods. 33
Warning Missing a Javadoc comment. 36
Warning Missing a Javadoc comment. 43
Warning '}' should be on the same line. 53

org/apache/commons/jelly/tags/sql/QueryTag.java

ErrorLine
Warning Field 'log' is used in only one method. 44
Warning Missing a Javadoc comment. 51
Warning Variable 'maxRows' must be private and have accessor methods. 51
Warning Missing a Javadoc comment. 52
Warning Variable 'maxRowsSpecified' must be private and have accessor methods. 52
Warning Missing a Javadoc comment. 53
Warning Variable 'startRow' must be private and have accessor methods. 53
Warning Missing a Javadoc comment. 58
Warning Field 'conn' is used in only one method. 58
Warning Missing a Javadoc comment. 63
Warning Expected @param tag for 'startRow'. 73
Warning Expected @param tag for 'maxRows'. 81
Info Cyclomatic Complexity is 29 (max allowed is 10). 102
Info NPath Complexity is 5,190 (max allowed is 200). 102
Warning Expected @param tag for 'output'. 102
Warning Expected @throws tag for 'JellyTagException'. 102
Warning '}' should be on the same line. 109
Warning '}' should be on the same line. 113
Warning '}' should be on the same line. 119
Warning '(' is followed by whitespace. 129
Warning ')' is preceded with whitespace. 129
Warning '}' should be on the same line. 142
Warning '(' is followed by whitespace. 163
Warning ')' is preceded with whitespace. 163
Warning '(' is followed by whitespace. 164
Warning ')' is preceded with whitespace. 164
Warning '(' is followed by whitespace. 167
Warning ')' is preceded with whitespace. 167
Warning '}' should be on the same line. 172
Warning '}' should be on the same line. 192
Warning '}' should be on the same line. 195
Warning '}' should be on the same line. 200
Warning '}' should be on the same line. 208
Warning '}' should be on the same line. 216

org/apache/commons/jelly/tags/sql/ResultImpl.java

ErrorLine
Warning Found duplicate of 44 lines in C:\source\jakarta\jakarta-commons\jelly\jelly-tags\sql\src\java\javax\servlet\jsp\jstl\sql\ResultImpl.java, starting from line 53 55
Warning Found duplicate of 72 lines in C:\source\jakarta\jakarta-commons\jelly\jelly-tags\sql\src\java\javax\servlet\jsp\jstl\sql\ResultImpl.java, starting from line 93 141

org/apache/commons/jelly/tags/sql/ResultImpl.java

ErrorLine
Error Using the '.*' form of import should be avoided - java.sql.*. 19
Error Using the '.*' form of import should be avoided - java.util.*. 20
Warning 'javax.servlet.jsp.jstl.sql.Result' should be separated from previous imports. 21
Warning Missing a Javadoc comment. 37
Warning Missing a Javadoc comment. 38
Warning Missing a Javadoc comment. 39
Warning Missing a Javadoc comment. 40
Warning Unused @param tag for 'startRow,'. 48
Warning Unused @param tag for 'maxRows,'. 49
Warning Unused @throws tag for 'if'. 50
Warning Expected @param tag for 'startRow'. 52
Warning Expected @param tag for 'maxRows'. 52
Warning Expected @throws tag for 'SQLException'. 53
Warning '-' is not preceded with whitespace. 64
Warning '-' is not followed by whitespace. 64
Warning '-' is not preceded with whitespace. 89
Warning '-' is not followed by whitespace. 89
Warning '-' is not preceded with whitespace. 90
Warning '-' is not followed by whitespace. 90
Error Declaring variables, return values or parameters of type 'HashSet' is not allowed. 111
Warning ';' is followed by whitespace. 112
Warning '(' is followed by whitespace. 114
Warning ')' is preceded with whitespace. 114
Warning ')' is preceded with whitespace. 121
Warning ';' is followed by whitespace. 126
Warning 'cast' is not followed by whitespace. 176
Warning First sentence should end with a period. 190
Warning First sentence should end with a period. 203

org/apache/commons/jelly/tags/sql/ResultSetTag.java

ErrorLine
Warning Missing a Javadoc comment. 34
Warning Missing a Javadoc comment. 35
Warning First sentence should end with a period. 37
Warning Expected @param tag for 'row'. 40
Warning Missing a Javadoc comment. 46
Warning Redundant throws: 'MissingAttributeException' is subclass of 'JellyTagException'. 46
Warning '(' is followed by whitespace. 48
Warning ')' is preceded with whitespace. 48
Warning '(' is followed by whitespace. 54
Warning ')' is preceded with whitespace. 54
Warning Expected @param tag for 'var'. 64

org/apache/commons/jelly/tags/sql/RowTag.java

ErrorLine
Warning Missing a Javadoc comment. 31
Warning '(' is followed by whitespace. 32
Warning ')' is preceded with whitespace. 32
Warning '(' is followed by whitespace. 33
Warning ')' is preceded with whitespace. 33
Warning '(' is followed by whitespace. 34
Warning ')' is preceded with whitespace. 34
Warning '(' is followed by whitespace. 36
Warning ')' is preceded with whitespace. 36

org/apache/commons/jelly/tags/sql/SetDataSourceTag.java

ErrorLine
Warning Field 'log' is used in only one method. 38
Warning Missing a Javadoc comment. 40
Warning Variable 'dataSource' must be private and have accessor methods. 40
Warning Missing a Javadoc comment. 41
Warning Variable 'dataSourceSpecified' must be private and have accessor methods. 41
Warning Missing a Javadoc comment. 42
Warning Variable 'jdbcURL' must be private and have accessor methods. 42
Warning Missing a Javadoc comment. 43
Warning Variable 'driverClassName' must be private and have accessor methods. 43
Warning Missing a Javadoc comment. 44
Warning Variable 'userName' must be private and have accessor methods. 44
Warning Missing a Javadoc comment. 45
Warning Variable 'password' must be private and have accessor methods. 45
Warning Missing a Javadoc comment. 47
Warning Field 'scope' is used in only one method. 47
Warning Missing a Javadoc comment. 48
Warning Missing a Javadoc comment. 53
Warning Expected @param tag for 'scope'. 64
Warning Missing a Javadoc comment. 68
Warning Missing a Javadoc comment. 72
Warning Missing a Javadoc comment. 77
Warning Missing a Javadoc comment. 81
Warning Missing a Javadoc comment. 85
Warning Missing a Javadoc comment. 89
Warning Missing a Javadoc comment. 96
Warning '}' should be on the same line. 101
Warning '}' should be on the same line. 113
Warning '(' is followed by whitespace. 115
Warning ')' is preceded with whitespace. 115
Warning '}' should be on the same line. 127

org/apache/commons/jelly/tags/sql/SqlTagLibrary.java

ErrorLine
Warning Missing a Javadoc comment. 29

org/apache/commons/jelly/tags/sql/SqlTagSupport.java

ErrorLine
Warning Missing a Javadoc comment. 42
Warning Variable 'var' must be private and have accessor methods. 42
Warning Missing a Javadoc comment. 43
Warning Variable 'scope' must be private and have accessor methods. 43
Warning Missing a Javadoc comment. 50
Warning Variable 'rawDataSource' must be private and have accessor methods. 50
Warning Missing a Javadoc comment. 51
Warning Variable 'dataSourceSpecified' must be private and have accessor methods. 51
Warning Missing a Javadoc comment. 52
Warning Variable 'sql' must be private and have accessor methods. 52
Warning Missing a Javadoc comment. 57
Warning Missing a Javadoc comment. 58
Error Variable access definition in wrong order. 58
Warning Variable 'isPartOfTransaction' must be private and have accessor methods. 58
Warning Missing a Javadoc comment. 63
Warning Expected @param tag for 'var'. 73
Warning Expected @param tag for 'scopeName'. 81
Warning Expected @param tag for 'dataSource'. 89
Warning Expected @param tag for 'sql'. 100
Warning Expected @param tag for 'o'. 112
Warning Javadoc has empty description section. 122
Warning Missing a Javadoc comment. 129
Warning Missing a Javadoc comment. 133
Warning '}' should be on the same line. 146
Warning '}' should be on the same line. 154
Warning Missing a Javadoc comment. 164

org/apache/commons/jelly/tags/sql/TransactionTag.java

ErrorLine
Warning Missing a Javadoc comment. 40
Warning Field 'TRANSACTION_READ_COMMITTED' is used in only one method. 40
Warning Missing a Javadoc comment. 41
Warning Field 'TRANSACTION_READ_UNCOMMITTED' is used in only one method. 41
Warning Missing a Javadoc comment. 42
Warning Field 'TRANSACTION_REPEATABLE_READ' is used in only one method. 42
Warning Missing a Javadoc comment. 43
Warning Field 'TRANSACTION_SERIALIZABLE' is used in only one method. 43
Warning Missing a Javadoc comment. 48
Warning Variable 'rawDataSource' must be private and have accessor methods. 48
Warning Missing a Javadoc comment. 49
Warning Variable 'dataSourceSpecified' must be private and have accessor methods. 49
Warning Missing a Javadoc comment. 54
Warning Missing a Javadoc comment. 55
Warning Missing a Javadoc comment. 56
Warning Missing a Javadoc comment. 61
Warning Expected @param tag for 'dataSource'. 68
Info Cyclomatic Complexity is 15 (max allowed is 10). 82
Warning Expected @param tag for 'output'. 82
Warning Expected @throws tag for 'JellyTagException'. 82
Warning '}' should be on the same line. 101
Warning '}' should be on the same line. 111
Warning '}' should be on the same line. 116
Warning Must have at least one statement. 117
Warning '}' should be on the same line. 128
Warning '}' should be on the same line. 132
Warning Expected @param tag for 'iso'. 144
Warning Expected @throws tag for 'JellyTagException'. 144
Warning '}' should be on the same line. 148
Warning '}' should be on the same line. 151
Warning '}' should be on the same line. 154
Warning '}' should be on the same line. 157
Warning Expected an @return tag. 167
Warning '}' should be on the same line. 187
Warning Must have at least one statement. 188

org/apache/commons/jelly/tags/sql/UpdateTag.java

ErrorLine
Warning Field 'log' is used in only one method. 40
Warning Missing a Javadoc comment. 45
Warning Field 'conn' is used in only one method. 45
Warning Missing a Javadoc comment. 50
Info Cyclomatic Complexity is 19 (max allowed is 10). 69
Info NPath Complexity is 296 (max allowed is 200). 69
Warning Expected @param tag for 'output'. 69
Warning Expected @throws tag for 'JellyTagException'. 69
Warning '}' should be on the same line. 72
Warning '}' should be on the same line. 84
Warning '(' is followed by whitespace. 95
Warning ')' is preceded with whitespace. 95
Warning '}' should be on the same line. 100
Warning '}' should be on the same line. 114
Warning '}' should be on the same line. 117
Warning '}' should be on the same line. 122
Warning '}' should be on the same line. 130