Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
148 | 0 | 0 | 2533 |
Files
org/apache/torque/NoRowsException.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Parameter msg should be final. |
43
|
| Parameter nested should be final. |
55
|
| Parameter msg should be final. |
68
|
| Parameter nested should be final. |
68
|
org/apache/torque/TooManyRowsException.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Parameter msg should be final. |
42
|
| Parameter nested should be final. |
54
|
| Parameter msg should be final. |
67
|
| Parameter nested should be final. |
67
|
org/apache/torque/Torque.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Line has trailing spaces. |
83
|
| Name 'memberConfig' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
87
|
| Parameter configFile should be final. |
120
|
| Parameter conf should be final. |
133
|
| Parameter conf should be final. |
154
|
| Parameter name should be final. |
175
|
| Parameter name should be final. |
188
|
| Parameter defaultClassName should be final. |
189
|
| Parameter name should be final. |
228
|
| Parameter className should be final. |
239
|
| Parameter name should be final. |
265
|
| Parameter name should be final. |
283
|
| Parameter username should be final. |
283
|
| Parameter password should be final. |
284
|
| Parameter name should be final. |
297
|
| Parameter con should be final. |
317
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
338
|
| Parameter conf should be final. |
338
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
350
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
359
|
org/apache/torque/TorqueException.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Parameter msg should be final. |
45
|
| Parameter nested should be final. |
57
|
| Parameter msg should be final. |
70
|
| Parameter nested should be final. |
70
|
org/apache/torque/TorqueInstance.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'defaultDBName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
71
|
| Name 'dbMaps' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
74
|
| Name 'dsFactoryMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
77
|
| Name 'adapterMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
80
|
| Name 'managers' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
83
|
| Name 'conf' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
86
|
| Name 'isInit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
89
|
| Name 'mapBuilders' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
97
|
| Redundant 'final' modifier. |
170
|
| Parameter conf should be final. |
170
|
| 'conf' hides a field. |
170
|
| ';' is followed by whitespace. |
183
|
| Line is longer than 80 characters. |
193
|
| Parameter conf should be final. |
223
|
| 'conf' hides a field. |
223
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
295
|
| Parameter configFile should be final. |
295
|
| 'conf' hides a field. |
301
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
319
|
| Parameter conf should be final. |
319
|
| 'conf' hides a field. |
319
|
| Method 'initManagerMappings' is not designed for extension - needs to be abstract, final or empty. |
350
|
| Parameter conf should be final. |
350
|
| 'conf' hides a field. |
350
|
| Parameter name should be final. |
396
|
| Parameter className should be final. |
396
|
| Method 'isInit' is not designed for extension - needs to be abstract, final or empty. |
426
|
| Method 'setConfiguration' is not designed for extension - needs to be abstract, final or empty. |
436
|
| Parameter conf should be final. |
436
|
| 'conf' hides a field. |
436
|
| Method 'getConfiguration' is not designed for extension - needs to be abstract, final or empty. |
447
|
| Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
459
|
| Parameter name should be final. |
459
|
| Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
477
|
| Parameter name should be final. |
477
|
| Parameter defaultClassName should be final. |
478
|
| Method 'shutdown' is not designed for extension - needs to be abstract, final or empty. |
508
|
| Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
543
|
| Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
559
|
| Parameter name should be final. |
559
|
| Redundant 'final' modifier. |
593
|
| Parameter name should be final. |
593
|
| Method 'registerMapBuilder' is not designed for extension - needs to be abstract, final or empty. |
636
|
| Parameter className should be final. |
636
|
| Parameter db should be final. |
649
|
| Parameter prop should be final. |
649
|
| Redundant 'final' modifier. |
667
|
| Parameter map should be final. |
667
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
684
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
697
|
| Parameter name should be final. |
697
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
735
|
| Parameter name should be final. |
735
|
| Parameter username should be final. |
735
|
| Parameter password should be final. |
736
|
| Method 'getDB' is not designed for extension - needs to be abstract, final or empty. |
770
|
| Parameter name should be final. |
770
|
| Method 'getDefaultDB' is not designed for extension - needs to be abstract, final or empty. |
782
|
| Line has trailing spaces. |
792
|
| Method 'closeConnection' is not designed for extension - needs to be abstract, final or empty. |
804
|
| Parameter con should be final. |
804
|
org/apache/torque/TorqueRuntimeException.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'nested' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
| Parameter msg should be final. |
66
|
| Parameter nested should be final. |
78
|
| 'nested' hides a field. |
78
|
| Parameter msg should be final. |
92
|
| Parameter nested should be final. |
92
|
| 'nested' hides a field. |
92
|
| Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
101
|
| Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Parameter out should be final. |
114
|
| Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
130
|
| Parameter out should be final. |
130
|
| Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
145
|
| Parameter out should be final. |
145
|
| Parameter skip should be final. |
145
|
| Parameter t should be final. |
194
|
| Parameter stackTrace should be final. |
208
|
org/apache/torque/adapter/DB.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Line is longer than 80 characters. |
73
|
| Parameter in should be final. |
89
|
| Method 'getStringDelimiter' is not designed for extension - needs to be abstract, final or empty. |
98
|
| Parameter obj should be final. |
120
|
| Parameter con should be final. |
129
|
| Parameter table should be final. |
129
|
| Parameter con should be final. |
139
|
| Parameter table should be final. |
139
|
| Parameter in should be final. |
148
|
| Method 'ignoreCaseInOrderBy' is not designed for extension - needs to be abstract, final or empty. |
159
|
| Parameter in should be final. |
159
|
| Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
171
|
| Method 'supportsNativeOffset' is not designed for extension - needs to be abstract, final or empty. |
184
|
| Method 'escapeText' is not designed for extension - needs to be abstract, final or empty. |
197
|
| Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
208
|
| Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
220
|
| Parameter date should be final. |
220
|
| Method 'getBooleanString' is not designed for extension - needs to be abstract, final or empty. |
241
|
| Parameter b should be final. |
241
|
| Avoid inline conditionals. |
243
|
org/apache/torque/adapter/DBAxion.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Parameter in should be final. |
45
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Parameter in should be final. |
56
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
64
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Parameter obj should be final. |
72
|
| Parameter con should be final. |
84
|
| Parameter table should be final. |
84
|
| Parameter con should be final. |
95
|
| Parameter table should be final. |
95
|
org/apache/torque/adapter/DBCloudscape.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Parameter in should be final. |
46
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Parameter in should be final. |
57
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
65
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Parameter obj should be final. |
73
|
| '132' is a magic number. |
75
|
| '3' is a magic number. |
102
|
| Parameter con should be final. |
132
|
| Parameter table should be final. |
132
|
| Parameter con should be final. |
143
|
| Parameter table should be final. |
143
|
org/apache/torque/adapter/DBDB2400.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Parameter in should be final. |
48
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
60
|
| Parameter in should be final. |
60
|
| Parameter in should be final. |
73
|
| Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
84
|
org/apache/torque/adapter/DBDB2App.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Parameter in should be final. |
49
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Parameter in should be final. |
61
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
70
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Parameter obj should be final. |
78
|
| Parameter con should be final. |
90
|
| Parameter table should be final. |
90
|
| Parameter con should be final. |
101
|
| Parameter table should be final. |
101
|
| Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
111
|
org/apache/torque/adapter/DBDB2Net.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Parameter in should be final. |
50
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Parameter in should be final. |
62
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
71
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
79
|
| Parameter obj should be final. |
79
|
| Parameter con should be final. |
91
|
| Parameter table should be final. |
91
|
| Parameter con should be final. |
102
|
| Parameter table should be final. |
102
|
| Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
112
|
org/apache/torque/adapter/DBFactory.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Utility classes should not have a public or default constructor. |
33
|
| '40' is a magic number. |
38
|
| Parameter driver should be final. |
100
|
org/apache/torque/adapter/DBHypersonicSQL.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Parameter in should be final. |
46
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
58
|
| Parameter in should be final. |
58
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Parameter obj should be final. |
74
|
| Parameter con should be final. |
89
|
| Parameter table should be final. |
89
|
| Parameter con should be final. |
100
|
| Parameter table should be final. |
100
|
org/apache/torque/adapter/DBInformix.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Parameter in should be final. |
47
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
60
|
| Parameter in should be final. |
60
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Parameter obj should be final. |
76
|
| Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Parameter con should be final. |
88
|
| Parameter table should be final. |
88
|
| Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
107
|
| Parameter con should be final. |
107
|
| Parameter table should be final. |
107
|
org/apache/torque/adapter/DBInstantDB.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Parameter in should be final. |
49
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
60
|
| Parameter in should be final. |
60
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Parameter obj should be final. |
76
|
| Parameter con should be final. |
88
|
| Parameter table should be final. |
88
|
| Parameter con should be final. |
99
|
| Parameter table should be final. |
99
|
org/apache/torque/adapter/DBInterbase.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Parameter in should be final. |
37
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Parameter in should be final. |
48
|
| Method 'ignoreCaseInOrderBy' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Parameter in should be final. |
62
|
| Method 'getStringDelimiter' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Parameter obj should be final. |
88
|
| Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Parameter con should be final. |
100
|
| Parameter table should be final. |
100
|
| Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
122
|
| Parameter con should be final. |
122
|
| Parameter table should be final. |
122
|
org/apache/torque/adapter/DBMM.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
43
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
60
|
| Parameter in should be final. |
60
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
71
|
| Parameter in should be final. |
71
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
79
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Parameter obj should be final. |
91
|
| Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Parameter con should be final. |
104
|
| Parameter table should be final. |
104
|
| Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Parameter con should be final. |
120
|
| Parameter table should be final. |
120
|
| Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
132
|
| Method 'supportsNativeOffset' is not designed for extension - needs to be abstract, final or empty. |
144
|
| Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
155
|
| Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
168
|
| Parameter date should be final. |
168
|
org/apache/torque/adapter/DBMSSQL.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
45
|
org/apache/torque/adapter/DBNone.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Parameter url should be final. |
52
|
| Expected @param tag for 'url'. |
52
|
| Parameter username should be final. |
52
|
| Expected @param tag for 'username'. |
52
|
| Parameter password should be final. |
52
|
| Expected @param tag for 'password'. |
52
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Parameter in should be final. |
62
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Parameter in should be final. |
73
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
81
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Parameter obj should be final. |
89
|
| Parameter con should be final. |
101
|
| Parameter table should be final. |
101
|
| Parameter con should be final. |
112
|
| Parameter table should be final. |
112
|
org/apache/torque/adapter/DBOdbc.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Parameter in should be final. |
45
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Parameter in should be final. |
56
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
64
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Parameter obj should be final. |
72
|
| Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
86
|
| Parameter con should be final. |
86
|
| Parameter table should be final. |
86
|
| Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Parameter con should be final. |
100
|
| Parameter table should be final. |
100
|
org/apache/torque/adapter/DBOracle.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Parameter in should be final. |
52
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Parameter in should be final. |
63
|
| Line has trailing spaces. |
74
|
| Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Parameter date should be final. |
74
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
101
|
| Parameter sequenceName should be final. |
101
|
| Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
113
|
| Parameter con should be final. |
113
|
| Parameter table should be final. |
113
|
| Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
132
|
| Parameter con should be final. |
132
|
| Parameter table should be final. |
132
|
| Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
145
|
| Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
156
|
| Method 'escapeText' is not designed for extension - needs to be abstract, final or empty. |
168
|
org/apache/torque/adapter/DBPostgres.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Missing a Javadoc comment. |
39
|
| Name 'sdf' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
39
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
55
|
| Parameter in should be final. |
55
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Parameter in should be final. |
67
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Parameter name should be final. |
87
|
| Parameter con should be final. |
99
|
| Parameter table should be final. |
99
|
| Parameter con should be final. |
110
|
| Parameter table should be final. |
110
|
| Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Method 'supportsNativeOffset' is not designed for extension - needs to be abstract, final or empty. |
132
|
| Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
143
|
| Method 'getBooleanString' is not designed for extension - needs to be abstract, final or empty. |
153
|
| Parameter b should be final. |
153
|
| Avoid inline conditionals. |
155
|
| Avoid inline conditionals. |
155
|
| Line has trailing spaces. |
160
|
| Line has trailing spaces. |
162
|
| Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
168
|
| Parameter date should be final. |
168
|
org/apache/torque/adapter/DBSapDB.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Parameter in should be final. |
46
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Parameter in should be final. |
57
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
65
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Parameter sequenceName should be final. |
83
|
| Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Parameter con should be final. |
95
|
| Parameter table should be final. |
95
|
| Method 'escapeText' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
128
|
| Parameter con should be final. |
128
|
| Parameter table should be final. |
128
|
org/apache/torque/adapter/DBSybase.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Parameter in should be final. |
54
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
65
|
| Parameter in should be final. |
65
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Parameter unused should be final. |
85
|
| Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Parameter con should be final. |
97
|
| Parameter table should be final. |
97
|
| Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
116
|
| Parameter con should be final. |
116
|
| Parameter table should be final. |
116
|
| Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
129
|
| Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
140
|
| Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
153
|
| Parameter date should be final. |
153
|
org/apache/torque/adapter/DBWeblogic.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Parameter in should be final. |
44
|
| Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
55
|
| Parameter in should be final. |
55
|
| Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
71
|
| Parameter obj should be final. |
71
|
| Parameter con should be final. |
83
|
| Parameter table should be final. |
83
|
| Parameter con should be final. |
94
|
| Parameter table should be final. |
94
|
org/apache/torque/adapter/IDMethod.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| interfaces should describe a type and hence have methods. |
26
|
org/apache/torque/avalon/Torque.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| interfaces should describe a type and hence have methods. |
28
|
| Missing a Javadoc comment. |
31
|
org/apache/torque/avalon/TorqueComponent.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'context' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
58
|
| Name 'torqueInstance' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
61
|
| Name 'configFile' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
64
|
| Line is longer than 80 characters. |
73
|
| Parameter torqueInstance should be final. |
86
|
| 'torqueInstance' hides a field. |
86
|
| Line is longer than 80 characters. |
108
|
| Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Parameter configuration should be final. |
110
|
| 'configFile' hides a field. |
115
|
| Line has trailing spaces. |
120
|
| Avoid inline conditionals. |
121
|
| Line has trailing spaces. |
141
|
| Line has trailing spaces. |
146
|
| Method 'contextualize' is not designed for extension - needs to be abstract, final or empty. |
158
|
| Parameter context should be final. |
158
|
| 'context' hides a field. |
158
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
167
|
| Method 'start' is not designed for extension - needs to be abstract, final or empty. |
177
|
| Method 'stop' is not designed for extension - needs to be abstract, final or empty. |
185
|
| Method 'isInit' is not designed for extension - needs to be abstract, final or empty. |
205
|
| Method 'getConfiguration' is not designed for extension - needs to be abstract, final or empty. |
215
|
| Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
226
|
| Parameter name should be final. |
226
|
| Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
239
|
| Parameter name should be final. |
239
|
| Parameter defaultClassName should be final. |
240
|
| Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
252
|
| Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
268
|
| Parameter name should be final. |
268
|
| Method 'registerMapBuilder' is not designed for extension - needs to be abstract, final or empty. |
279
|
| Parameter className should be final. |
279
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
291
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
304
|
| Parameter name should be final. |
304
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
322
|
| Parameter name should be final. |
322
|
| Parameter username should be final. |
322
|
| Parameter password should be final. |
323
|
| Method 'getDB' is not designed for extension - needs to be abstract, final or empty. |
336
|
| Parameter name should be final. |
336
|
| Method 'getDefaultDB' is not designed for extension - needs to be abstract, final or empty. |
347
|
| Method 'closeConnection' is not designed for extension - needs to be abstract, final or empty. |
357
|
| Parameter con should be final. |
357
|
org/apache/torque/dsfactory/AbstractDataSourceFactory.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'setProperty' is not designed for extension - needs to be abstract, final or empty. |
70
|
| Parameter property should be final. |
70
|
| Parameter c should be final. |
70
|
| Parameter ds should be final. |
70
|
| Method 'applyConfiguration' is not designed for extension - needs to be abstract, final or empty. |
146
|
| Parameter c should be final. |
146
|
| Parameter o should be final. |
146
|
| Line has trailing spaces. |
168
|
| Method 'initCPDS' is not designed for extension - needs to be abstract, final or empty. |
176
|
| Parameter configuration should be final. |
176
|
| Line has trailing spaces. |
193
|
| Line has trailing spaces. |
196
|
org/apache/torque/dsfactory/DataSourceFactory.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
31
|
| Line has trailing spaces. |
45
|
org/apache/torque/dsfactory/JndiDataSourceFactory.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'path' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
58
|
| Name 'ctx' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
60
|
| Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
63
|
| Name 'lastLookup' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
66
|
| Name 'ttl' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
69
|
| Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Line contains a tab character. |
76
|
| Line has trailing spaces. |
77
|
| Line contains a tab character. |
77
|
| Line contains a tab character. |
78
|
| Line contains a tab character. |
79
|
| Line contains a tab character. |
83
|
| Line contains a tab character. |
89
|
| Line contains a tab character. |
91
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Parameter configuration should be final. |
97
|
| Parameter configuration should be final. |
116
|
| Line contains a tab character. |
139
|
| Line contains a tab character. |
140
|
| Line contains a tab character. |
142
|
| Parameter configuration should be final. |
178
|
| 'ds' hides a field. |
187
|
| Parameter ctx should be final. |
222
|
| 'ctx' hides a field. |
222
|
| Expected @throws tag for 'NamingException'. |
222
|
| Parameter ctx should be final. |
243
|
| 'ctx' hides a field. |
243
|
| Expected @param tag for 'ctx'. |
243
|
| Parameter path should be final. |
243
|
| 'path' hides a field. |
243
|
| Expected @param tag for 'path'. |
243
|
| Parameter ds should be final. |
243
|
| 'ds' hides a field. |
243
|
| Expected @param tag for 'ds'. |
243
|
| Expected @throws tag for 'Exception'. |
244
|
| Must have at least one statement. |
266
|
| Must have at least one statement. |
270
|
org/apache/torque/dsfactory/PerUserPoolDataSourceFactory.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
45
|
| Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
| Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Parameter configuration should be final. |
62
|
| 'ds' hides a field. |
72
|
| Parameter configuration should be final. |
84
|
| 'ds' hides a field. |
88
|
org/apache/torque/dsfactory/SharedPoolDataSourceFactory.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
45
|
| Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
| Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Parameter configuration should be final. |
62
|
| 'ds' hides a field. |
72
|
| Parameter configuration should be final. |
84
|
| 'ds' hides a field. |
88
|
org/apache/torque/dsfactory/TorqueDataSourceFactory.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
| Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Parameter configuration should be final. |
61
|
| Method 'initTorqueClassic' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Parameter configuration should be final. |
84
|
| 'ds' hides a field. |
88
|
org/apache/torque/manager/AbstractBaseManager.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Variable 'log' must be private and have accessor methods. |
54
|
| Name 'cache' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
57
|
| Variable 'cache' must be private and have accessor methods. |
57
|
| Name 'mrCache' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
60
|
| Variable 'mrCache' must be private and have accessor methods. |
60
|
| Name 'omClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
63
|
| Missing a Javadoc comment. |
65
|
| Name 'className' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
65
|
| Missing a Javadoc comment. |
67
|
| Name 'region' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
67
|
| Missing a Javadoc comment. |
69
|
| Name 'isNew' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
69
|
| Missing a Javadoc comment. |
71
|
| Name 'validFields' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
71
|
| Variable 'validFields' must be private and have accessor methods. |
71
|
| Missing a Javadoc comment. |
72
|
| Name 'listenersMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
72
|
| Variable 'listenersMap' must be private and have accessor methods. |
72
|
| Method 'getOMClass' is not designed for extension - needs to be abstract, final or empty. |
79
|
| Method 'setOMClass' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Parameter omClass should be final. |
89
|
| 'omClass' hides a field. |
89
|
| Method 'getOMInstance' is not designed for extension - needs to be abstract, final or empty. |
101
|
| Expected @throws tag for 'InstantiationException'. |
102
|
| Expected @throws tag for 'IllegalAccessException'. |
102
|
| Method 'getClassName' is not designed for extension - needs to be abstract, final or empty. |
111
|
| Method 'setClassName' is not designed for extension - needs to be abstract, final or empty. |
122
|
| Parameter v should be final. |
122
|
| Expected an @return tag. |
145
|
| Method 'getOMInstance' is not designed for extension - needs to be abstract, final or empty. |
145
|
| Parameter id should be final. |
145
|
| Expected @param tag for 'id'. |
145
|
| Expected an @return tag. |
157
|
| Method 'getOMInstance' is not designed for extension - needs to be abstract, final or empty. |
157
|
| Parameter key should be final. |
157
|
| Expected @param tag for 'key'. |
157
|
| Parameter fromCache should be final. |
157
|
| Expected @param tag for 'fromCache'. |
157
|
| Method 'cacheGet' is not designed for extension - needs to be abstract, final or empty. |
178
|
| Missing a Javadoc comment. |
178
|
| Parameter key should be final. |
178
|
| Line has trailing spaces. |
192
|
| Method 'clearImpl' is not designed for extension - needs to be abstract, final or empty. |
196
|
| Line has trailing spaces. |
214
|
| Expected an @return tag. |
220
|
| Method 'removeInstanceImpl' is not designed for extension - needs to be abstract, final or empty. |
220
|
| Parameter key should be final. |
220
|
| Expected @param tag for 'key'. |
220
|
| Line has trailing spaces. |
245
|
| Expected an @return tag. |
251
|
| Method 'putInstanceImpl' is not designed for extension - needs to be abstract, final or empty. |
251
|
| Parameter om should be final. |
251
|
| Expected @param tag for 'om'. |
251
|
| Line has trailing spaces. |
259
|
| Expected an @return tag. |
266
|
| Method 'putInstanceImpl' is not designed for extension - needs to be abstract, final or empty. |
266
|
| Parameter key should be final. |
266
|
| Expected @param tag for 'key'. |
266
|
| Parameter om should be final. |
266
|
| Expected @param tag for 'om'. |
266
|
| Line has trailing spaces. |
297
|
| Expected an @return tag. |
303
|
| Parameter id should be final. |
303
|
| Expected @param tag for 'id'. |
303
|
| Method 'getOMs' is not designed for extension - needs to be abstract, final or empty. |
314
|
| Parameter ids should be final. |
314
|
| Method 'getOMs' is not designed for extension - needs to be abstract, final or empty. |
328
|
| Parameter ids should be final. |
328
|
| Method 'getOMs' is not designed for extension - needs to be abstract, final or empty. |
342
|
| Parameter ids should be final. |
342
|
| Parameter fromCache should be final. |
342
|
| Expected @param tag for 'fromCache'. |
342
|
| Line has trailing spaces. |
400
|
| Expected an @return tag. |
406
|
| Parameter ids should be final. |
406
|
| Expected @param tag for 'ids'. |
406
|
| Line has trailing spaces. |
411
|
| Method 'getRegion' is not designed for extension - needs to be abstract, final or empty. |
414
|
| Method 'setRegion' is not designed for extension - needs to be abstract, final or empty. |
426
|
| Parameter v should be final. |
426
|
| Method 'getMethodResultCache' is not designed for extension - needs to be abstract, final or empty. |
455
|
| The double-checked locking idiom is broken and should be avoided. |
461
|
| Line has trailing spaces. |
480
|
| Method 'addCacheListenerImpl' is not designed for extension - needs to be abstract, final or empty. |
483
|
| Parameter listener should be final. |
483
|
| 'isNew' hides a field. |
499
|
| Must have at least one statement. |
506
|
| Line has trailing spaces. |
527
|
| Parameter key should be final. |
531
|
| Expected @param tag for 'key'. |
531
|
| Line has trailing spaces. |
548
|
| Method 'notifyListeners' is not designed for extension - needs to be abstract, final or empty. |
553
|
| Parameter listeners should be final. |
553
|
| Expected @param tag for 'listeners'. |
553
|
| Parameter oldOm should be final. |
554
|
| Expected @param tag for 'oldOm'. |
554
|
| Parameter om should be final. |
554
|
| Expected @param tag for 'om'. |
554
|
| Line has trailing spaces. |
591
|
| Parameter out should be final. |
595
|
| Expected @param tag for 'out'. |
595
|
| Expected @throws tag for 'IOException'. |
596
|
| Line has trailing spaces. |
603
|
| Parameter in should be final. |
608
|
| Expected @throws tag for 'IOException'. |
609
|
| Expected @throws tag for 'ClassNotFoundException'. |
609
|
org/apache/torque/manager/CacheListener.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
31
|
| Expected @param tag for 'om'. |
34
|
| Line has trailing spaces. |
35
|
| Line has trailing spaces. |
37
|
| Expected @param tag for 'om'. |
40
|
| Line has trailing spaces. |
41
|
| Line has trailing spaces. |
43
|
| Line has trailing spaces. |
45
|
| Expected an @return tag. |
47
|
org/apache/torque/manager/MethodCacheKey.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Missing a Javadoc comment. |
32
|
| Name 'n' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
32
|
| Variable 'n' must be private and have accessor methods. |
32
|
| Missing a Javadoc comment. |
33
|
| Name 'instanceOrClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
33
|
| Missing a Javadoc comment. |
34
|
| Name 'method' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
34
|
| Missing a Javadoc comment. |
35
|
| Name 'arg1' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
35
|
| Missing a Javadoc comment. |
36
|
| Name 'arg2' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
36
|
| Missing a Javadoc comment. |
37
|
| Name 'arg3' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
37
|
| Missing a Javadoc comment. |
38
|
| Name 'moreThanThree' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
38
|
| Missing a Javadoc comment. |
39
|
| Name 'groupKey' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
39
|
| Missing a Javadoc comment. |
41
|
| Missing a Javadoc comment. |
45
|
| Parameter instanceOrClass should be final. |
45
|
| 'instanceOrClass' hides a field. |
45
|
| Parameter method should be final. |
45
|
| 'method' hides a field. |
45
|
| Missing a Javadoc comment. |
50
|
| Parameter instanceOrClass should be final. |
50
|
| 'instanceOrClass' hides a field. |
50
|
| Parameter method should be final. |
50
|
| 'method' hides a field. |
50
|
| Parameter arg1 should be final. |
51
|
| 'arg1' hides a field. |
51
|
| Missing a Javadoc comment. |
56
|
| Parameter instanceOrClass should be final. |
56
|
| 'instanceOrClass' hides a field. |
56
|
| Parameter method should be final. |
56
|
| 'method' hides a field. |
56
|
| Parameter arg1 should be final. |
57
|
| 'arg1' hides a field. |
57
|
| Parameter arg2 should be final. |
57
|
| 'arg2' hides a field. |
57
|
| Missing a Javadoc comment. |
62
|
| Parameter instanceOrClass should be final. |
62
|
| 'instanceOrClass' hides a field. |
62
|
| Parameter method should be final. |
62
|
| 'method' hides a field. |
62
|
| Parameter arg1 should be final. |
63
|
| 'arg1' hides a field. |
63
|
| Parameter arg2 should be final. |
63
|
| 'arg2' hides a field. |
63
|
| Parameter arg3 should be final. |
64
|
| 'arg3' hides a field. |
64
|
| Missing a Javadoc comment. |
69
|
| Parameter moreThanThree should be final. |
69
|
| 'moreThanThree' hides a field. |
69
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
81
|
| Parameter instanceOrClass should be final. |
81
|
| 'instanceOrClass' hides a field. |
81
|
| Parameter method should be final. |
81
|
| 'method' hides a field. |
81
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Parameter instanceOrClass should be final. |
97
|
| 'instanceOrClass' hides a field. |
97
|
| Parameter method should be final. |
97
|
| 'method' hides a field. |
97
|
| Parameter arg1 should be final. |
98
|
| 'arg1' hides a field. |
98
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Parameter instanceOrClass should be final. |
114
|
| 'instanceOrClass' hides a field. |
114
|
| Parameter method should be final. |
114
|
| 'method' hides a field. |
114
|
| Parameter arg1 should be final. |
115
|
| 'arg1' hides a field. |
115
|
| Parameter arg2 should be final. |
115
|
| 'arg2' hides a field. |
115
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Parameter instanceOrClass should be final. |
133
|
| 'instanceOrClass' hides a field. |
133
|
| Parameter method should be final. |
133
|
| 'method' hides a field. |
133
|
| Parameter arg1 should be final. |
134
|
| 'arg1' hides a field. |
134
|
| Parameter arg2 should be final. |
134
|
| 'arg2' hides a field. |
134
|
| Parameter arg3 should be final. |
135
|
| 'arg3' hides a field. |
135
|
| Expected @param tag for 'arg3'. |
135
|
| '3' is a magic number. |
138
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
153
|
| Parameter keys should be final. |
153
|
| '3' is a magic number. |
162
|
| '4' is a magic number. |
165
|
| '3' is a magic number. |
166
|
| Method 'getGroupKey' is not designed for extension - needs to be abstract, final or empty. |
175
|
| Missing a Javadoc comment. |
175
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
180
|
| Missing a Javadoc comment. |
180
|
| Parameter obj should be final. |
180
|
| '3' is a magic number. |
198
|
| '5' is a magic number. |
200
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
214
|
| Missing a Javadoc comment. |
214
|
| Avoid inline conditionals. |
220
|
| Avoid inline conditionals. |
223
|
| Avoid inline conditionals. |
226
|
| '3' is a magic number. |
227
|
| '5' is a magic number. |
229
|
| Avoid inline conditionals. |
231
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
241
|
| Missing a Javadoc comment. |
241
|
| '50' is a magic number. |
243
|
| '3' is a magic number. |
256
|
| '5' is a magic number. |
258
|
| Missing a Javadoc comment. |
272
|
| Method 'makeObject' is not designed for extension - needs to be abstract, final or empty. |
279
|
| Expected @throws tag for 'Exception'. |
280
|
| Method 'passivateObject' is not designed for extension - needs to be abstract, final or empty. |
289
|
| Parameter obj should be final. |
289
|
| Expected @throws tag for 'Exception'. |
290
|
org/apache/torque/manager/MethodResultCache.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Missing a Javadoc comment. |
43
|
| Name 'pool' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
| Missing a Javadoc comment. |
44
|
| Name 'jcsCache' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
| Missing a Javadoc comment. |
45
|
| Name 'groups' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
| Missing a Javadoc comment. |
50
|
| Parameter cache should be final. |
50
|
| '10000' is a magic number. |
55
|
| Method 'clear' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Missing a Javadoc comment. |
67
|
| Method 'getImpl' is not designed for extension - needs to be abstract, final or empty. |
84
|
| Missing a Javadoc comment. |
84
|
| Parameter key should be final. |
84
|
| Line is longer than 80 characters. |
99
|
| Method 'putImpl' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Missing a Javadoc comment. |
106
|
| Parameter key should be final. |
106
|
| Parameter value should be final. |
106
|
| Method 'removeImpl' is not designed for extension - needs to be abstract, final or empty. |
136
|
| Missing a Javadoc comment. |
136
|
| Parameter key should be final. |
136
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
152
|
| Missing a Javadoc comment. |
152
|
| Parameter instanceOrClass should be final. |
152
|
| Parameter method should be final. |
152
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
180
|
| Missing a Javadoc comment. |
180
|
| Parameter instanceOrClass should be final. |
180
|
| Parameter method should be final. |
180
|
| Parameter arg1 should be final. |
181
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
209
|
| Missing a Javadoc comment. |
209
|
| Parameter instanceOrClass should be final. |
209
|
| Parameter method should be final. |
209
|
| Parameter arg1 should be final. |
210
|
| Parameter arg2 should be final. |
210
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
238
|
| Missing a Javadoc comment. |
238
|
| Parameter instanceOrClass should be final. |
238
|
| Parameter method should be final. |
238
|
| Parameter arg1 should be final. |
239
|
| Parameter arg2 should be final. |
239
|
| Parameter arg3 should be final. |
240
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
268
|
| Missing a Javadoc comment. |
268
|
| Parameter keys should be final. |
268
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
296
|
| Missing a Javadoc comment. |
296
|
| Parameter value should be final. |
296
|
| Parameter instanceOrClass should be final. |
296
|
| Parameter method should be final. |
296
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
310
|
| Missing a Javadoc comment. |
310
|
| Parameter value should be final. |
310
|
| Parameter instanceOrClass should be final. |
310
|
| Parameter method should be final. |
311
|
| Parameter arg1 should be final. |
311
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
325
|
| Missing a Javadoc comment. |
325
|
| Parameter value should be final. |
325
|
| Parameter instanceOrClass should be final. |
325
|
| Parameter method should be final. |
325
|
| Parameter arg1 should be final. |
326
|
| Parameter arg2 should be final. |
326
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
340
|
| Missing a Javadoc comment. |
340
|
| Parameter value should be final. |
340
|
| Parameter instanceOrClass should be final. |
340
|
| Parameter method should be final. |
340
|
| Parameter arg1 should be final. |
341
|
| Parameter arg2 should be final. |
341
|
| Parameter arg3 should be final. |
341
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
355
|
| Missing a Javadoc comment. |
355
|
| Parameter value should be final. |
355
|
| Parameter keys should be final. |
355
|
| Method 'removeAll' is not designed for extension - needs to be abstract, final or empty. |
370
|
| Missing a Javadoc comment. |
370
|
| Parameter instanceOrClass should be final. |
370
|
| Parameter method should be final. |
370
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
399
|
| Missing a Javadoc comment. |
399
|
| Parameter instanceOrClass should be final. |
399
|
| Parameter method should be final. |
399
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
427
|
| Missing a Javadoc comment. |
427
|
| Parameter instanceOrClass should be final. |
427
|
| Parameter method should be final. |
427
|
| Parameter arg1 should be final. |
428
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
456
|
| Missing a Javadoc comment. |
456
|
| Parameter instanceOrClass should be final. |
456
|
| Parameter method should be final. |
456
|
| Parameter arg1 should be final. |
457
|
| Parameter arg2 should be final. |
457
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
485
|
| Missing a Javadoc comment. |
485
|
| Parameter instanceOrClass should be final. |
485
|
| Parameter method should be final. |
485
|
| Parameter arg1 should be final. |
486
|
| Parameter arg2 should be final. |
486
|
| Parameter arg3 should be final. |
487
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
515
|
| Missing a Javadoc comment. |
515
|
| Parameter keys should be final. |
515
|
org/apache/torque/manager/NoOpMethodResultCache.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Missing a Javadoc comment. |
32
|
| Parameter cache should be final. |
32
|
| Missing a Javadoc comment. |
38
|
| Method 'getImpl' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| Parameter key should be final. |
42
|
| Method 'putImpl' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Missing a Javadoc comment. |
48
|
| Parameter key should be final. |
48
|
| Parameter value should be final. |
48
|
| Method 'removeImpl' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter key should be final. |
54
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Missing a Javadoc comment. |
61
|
| Parameter instanceOrClass should be final. |
61
|
| Parameter method should be final. |
61
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Missing a Javadoc comment. |
66
|
| Parameter instanceOrClass should be final. |
66
|
| Parameter method should be final. |
66
|
| Parameter arg1 should be final. |
67
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Missing a Javadoc comment. |
72
|
| Parameter instanceOrClass should be final. |
72
|
| Parameter method should be final. |
72
|
| Parameter arg1 should be final. |
73
|
| Parameter arg2 should be final. |
73
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Missing a Javadoc comment. |
78
|
| Parameter instanceOrClass should be final. |
78
|
| Parameter method should be final. |
78
|
| Parameter arg1 should be final. |
79
|
| Parameter arg2 should be final. |
79
|
| Parameter arg3 should be final. |
80
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Missing a Javadoc comment. |
85
|
| Parameter keys should be final. |
85
|
| Missing a Javadoc comment. |
90
|
| Parameter value should be final. |
90
|
| Parameter instanceOrClass should be final. |
90
|
| Parameter method should be final. |
90
|
| Missing a Javadoc comment. |
94
|
| Parameter value should be final. |
94
|
| Parameter instanceOrClass should be final. |
94
|
| Parameter method should be final. |
95
|
| Parameter arg1 should be final. |
95
|
| Missing a Javadoc comment. |
99
|
| Parameter value should be final. |
99
|
| Parameter instanceOrClass should be final. |
99
|
| Parameter method should be final. |
99
|
| Parameter arg1 should be final. |
100
|
| Parameter arg2 should be final. |
100
|
| Missing a Javadoc comment. |
104
|
| Parameter value should be final. |
104
|
| Parameter instanceOrClass should be final. |
104
|
| Parameter method should be final. |
104
|
| Parameter arg1 should be final. |
105
|
| Parameter arg2 should be final. |
105
|
| Parameter arg3 should be final. |
105
|
| Missing a Javadoc comment. |
109
|
| Parameter value should be final. |
109
|
| Parameter keys should be final. |
109
|
| Missing a Javadoc comment. |
114
|
| Parameter instanceOrClass should be final. |
114
|
| Parameter method should be final. |
114
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
119
|
| Missing a Javadoc comment. |
119
|
| Parameter instanceOrClass should be final. |
119
|
| Parameter method should be final. |
119
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
124
|
| Missing a Javadoc comment. |
124
|
| Parameter instanceOrClass should be final. |
124
|
| Parameter method should be final. |
124
|
| Parameter arg1 should be final. |
125
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
130
|
| Missing a Javadoc comment. |
130
|
| Parameter instanceOrClass should be final. |
130
|
| Parameter method should be final. |
130
|
| Parameter arg1 should be final. |
131
|
| Parameter arg2 should be final. |
131
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
136
|
| Missing a Javadoc comment. |
136
|
| Parameter instanceOrClass should be final. |
136
|
| Parameter method should be final. |
136
|
| Parameter arg1 should be final. |
137
|
| Parameter arg2 should be final. |
137
|
| Parameter arg3 should be final. |
138
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
143
|
| Missing a Javadoc comment. |
143
|
| Parameter keys should be final. |
143
|
org/apache/torque/map/ColumnMap.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'type' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
28
|
| Name 'size' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
31
|
| Name 'pk' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
34
|
| Name 'notNull' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
37
|
| Name 'relatedTableName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
40
|
| Name 'relatedColumnName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
| Name 'table' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
46
|
| Name 'columnName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
| Parameter name should be final. |
58
|
| Parameter containingTable should be final. |
58
|
| Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Method 'getFullyQualifiedName' is not designed for extension - needs to be abstract, final or empty. |
79
|
| Method 'getTableName' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Parameter type should be final. |
99
|
| 'type' hides a field. |
99
|
| Method 'setSize' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Parameter size should be final. |
109
|
| 'size' hides a field. |
109
|
| Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
119
|
| Parameter pk should be final. |
119
|
| 'pk' hides a field. |
119
|
| Method 'setNotNull' is not designed for extension - needs to be abstract, final or empty. |
129
|
| Parameter nn should be final. |
129
|
| Method 'setForeignKey' is not designed for extension - needs to be abstract, final or empty. |
140
|
| Parameter fullyQualifiedName should be final. |
140
|
| Method 'setForeignKey' is not designed for extension - needs to be abstract, final or empty. |
162
|
| Parameter tableName should be final. |
162
|
| Parameter columnName should be final. |
162
|
| 'columnName' hides a field. |
162
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
182
|
| Method 'getSize' is not designed for extension - needs to be abstract, final or empty. |
192
|
| Method 'isPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
202
|
| Method 'isNotNull' is not designed for extension - needs to be abstract, final or empty. |
212
|
| Method 'isForeignKey' is not designed for extension - needs to be abstract, final or empty. |
222
|
| Method 'getRelatedName' is not designed for extension - needs to be abstract, final or empty. |
232
|
| Method 'getRelatedTableName' is not designed for extension - needs to be abstract, final or empty. |
242
|
| Method 'getRelatedColumnName' is not designed for extension - needs to be abstract, final or empty. |
252
|
org/apache/torque/map/DatabaseMap.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'name' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
36
|
| Name 'tables' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
39
|
| Name 'idTable' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
| Name 'idBroker' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
| Name 'idGenerators' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
51
|
| Parameter name should be final. |
66
|
| 'name' hides a field. |
66
|
| Parameter numberOfTables should be final. |
66
|
| '1.25' is a magic number. |
69
|
| '6' is a magic number. |
70
|
| Parameter name should be final. |
78
|
| 'name' hides a field. |
78
|
| '6' is a magic number. |
82
|
| Method 'containsTable' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Parameter table should be final. |
91
|
| Method 'containsTable' is not designed for extension - needs to be abstract, final or empty. |
102
|
| Parameter name should be final. |
102
|
| 'name' hides a field. |
102
|
| Method 'getIdTable' is not designed for extension - needs to be abstract, final or empty. |
116
|
| Method 'getIDBroker' is not designed for extension - needs to be abstract, final or empty. |
126
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
136
|
| Method 'getTable' is not designed for extension - needs to be abstract, final or empty. |
147
|
| Parameter name should be final. |
147
|
| 'name' hides a field. |
147
|
| Method 'getTables' is not designed for extension - needs to be abstract, final or empty. |
157
|
| ';' is preceded with whitespace. |
164
|
| Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
175
|
| Parameter tableName should be final. |
175
|
| Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
188
|
| Parameter tableName should be final. |
188
|
| Parameter numberOfColumns should be final. |
188
|
| Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
199
|
| Parameter map should be final. |
199
|
| Method 'setIdTable' is not designed for extension - needs to be abstract, final or empty. |
209
|
| Parameter idTable should be final. |
209
|
| 'idTable' hides a field. |
209
|
| Method 'setIdTable' is not designed for extension - needs to be abstract, final or empty. |
222
|
| Parameter tableName should be final. |
222
|
| Method 'addIdGenerator' is not designed for extension - needs to be abstract, final or empty. |
234
|
| Parameter type should be final. |
234
|
| Parameter idGen should be final. |
234
|
| Method 'getIdGenerator' is not designed for extension - needs to be abstract, final or empty. |
246
|
| Parameter type should be final. |
246
|
org/apache/torque/map/MapBuilder.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
org/apache/torque/map/TableMap.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'columns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
| Name 'dbMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
47
|
| Name 'tableName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
50
|
| Name 'prefix' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
53
|
| Name 'primaryKeyMethod' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
56
|
| Name 'pkInfo' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
62
|
| Parameter tableName should be final. |
78
|
| 'tableName' hides a field. |
78
|
| Parameter numberOfColumns should be final. |
79
|
| Parameter containingDB should be final. |
80
|
| '1.25' is a magic number. |
84
|
| Parameter tableName should be final. |
93
|
| 'tableName' hides a field. |
93
|
| Parameter containingDB should be final. |
93
|
| '20' is a magic number. |
97
|
| Parameter tableName should be final. |
108
|
| 'tableName' hides a field. |
108
|
| Parameter prefix should be final. |
109
|
| 'prefix' hides a field. |
109
|
| Parameter containingDB should be final. |
110
|
| '20' is a magic number. |
115
|
| Method 'containsColumn' is not designed for extension - needs to be abstract, final or empty. |
124
|
| Parameter column should be final. |
124
|
| Method 'containsColumn' is not designed for extension - needs to be abstract, final or empty. |
135
|
| Parameter name should be final. |
135
|
| Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Method 'containsObjectColumn' is not designed for extension - needs to be abstract, final or empty. |
161
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
181
|
| Method 'getPrefix' is not designed for extension - needs to be abstract, final or empty. |
191
|
| Method 'setPrefix' is not designed for extension - needs to be abstract, final or empty. |
202
|
| Parameter prefix should be final. |
202
|
| 'prefix' hides a field. |
202
|
| Method 'getPrimaryKeyMethod' is not designed for extension - needs to be abstract, final or empty. |
212
|
| Method 'getIdGenerator' is not designed for extension - needs to be abstract, final or empty. |
221
|
| Method 'getPrimaryKeyMethodInfo' is not designed for extension - needs to be abstract, final or empty. |
231
|
| Method 'getColumns' is not designed for extension - needs to be abstract, final or empty. |
241
|
| Method 'getColumn' is not designed for extension - needs to be abstract, final or empty. |
259
|
| Parameter name should be final. |
259
|
| Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
277
|
| Parameter cmap should be final. |
277
|
| Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
288
|
| Parameter columnName should be final. |
288
|
| Parameter type should be final. |
288
|
| Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
300
|
| Parameter columnName should be final. |
300
|
| Parameter type should be final. |
300
|
| Parameter size should be final. |
300
|
| Method 'addPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
311
|
| Parameter columnName should be final. |
311
|
| Parameter type should be final. |
311
|
| Method 'addPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
323
|
| Parameter columnName should be final. |
323
|
| Parameter type should be final. |
323
|
| Parameter size should be final. |
323
|
| Method 'addForeignKey' is not designed for extension - needs to be abstract, final or empty. |
336
|
| Parameter columnName should be final. |
336
|
| Parameter type should be final. |
337
|
| Parameter fkTable should be final. |
338
|
| Parameter fkColumn should be final. |
339
|
| Method 'addForeignKey' is not designed for extension - needs to be abstract, final or empty. |
353
|
| Parameter columnName should be final. |
353
|
| Parameter type should be final. |
354
|
| Parameter fkTable should be final. |
355
|
| Parameter fkColumn should be final. |
356
|
| Parameter size should be final. |
357
|
| Method 'addForeignPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
370
|
| Parameter columnName should be final. |
370
|
| Parameter type should be final. |
371
|
| Parameter fkTable should be final. |
372
|
| Parameter fkColumn should be final. |
373
|
| Method 'addForeignPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
387
|
| Parameter columnName should be final. |
387
|
| Parameter type should be final. |
388
|
| Parameter fkTable should be final. |
389
|
| Parameter fkColumn should be final. |
390
|
| Parameter size should be final. |
391
|
| Parameter name should be final. |
406
|
| Parameter type should be final. |
407
|
| Parameter pk should be final. |
408
|
| Parameter fkTable should be final. |
409
|
| Parameter fkColumn should be final. |
410
|
| Parameter size should be final. |
411
|
| Method 'setPrimaryKeyMethod' is not designed for extension - needs to be abstract, final or empty. |
443
|
| Parameter method should be final. |
443
|
| Method 'setPrimaryKeyMethodInfo' is not designed for extension - needs to be abstract, final or empty. |
463
|
| Parameter pkInfo should be final. |
463
|
| 'pkInfo' hides a field. |
463
|
| Redundant 'final' modifier. |
476
|
| Parameter data should be final. |
476
|
| Redundant 'final' modifier. |
487
|
| Parameter data should be final. |
487
|
| Parameter data should be final. |
501
|
org/apache/torque/oid/AutoIncrementIdGenerator.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Name 'dbAdapter' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
37
|
| Parameter adapter should be final. |
44
|
| Method 'getIdAsInt' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Parameter connection should be final. |
57
|
| Parameter keyInfo should be final. |
57
|
| Method 'getIdAsLong' is not designed for extension - needs to be abstract, final or empty. |
71
|
| Parameter connection should be final. |
71
|
| Parameter keyInfo should be final. |
71
|
| Method 'getIdAsBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
86
|
| Parameter connection should be final. |
86
|
| Parameter keyInfo should be final. |
86
|
| Method 'getIdAsString' is not designed for extension - needs to be abstract, final or empty. |
102
|
| Parameter connection should be final. |
102
|
| Parameter keyInfo should be final. |
102
|
| Method 'isPriorToInsert' is not designed for extension - needs to be abstract, final or empty. |
113
|
| Method 'isPostInsert' is not designed for extension - needs to be abstract, final or empty. |
123
|
| Parameter connection should be final. |
148
|
| Parameter keyInfo should be final. |
148
|
org/apache/torque/oid/IDBroker.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'tableMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
108
|
| Name 'ids' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
122
|
| Name 'quantityStore' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
130
|
| Name 'lastQueryTime' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
138
|
| '60000' is a magic number. |
143
|
| Name 'houseKeeperThread' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
153
|
| Name 'transactionsSupported' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
158
|
| Name 'configuration' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
166
|
| Name 'log' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
181
|
| Parameter tMap should be final. |
188
|
| Must have at least one statement. |
227
|
| Method 'setConfiguration' is not designed for extension - needs to be abstract, final or empty. |
247
|
| Parameter configuration should be final. |
247
|
| 'configuration' hides a field. |
247
|
| Method 'getIdAsInt' is not designed for extension - needs to be abstract, final or empty. |
264
|
| Parameter connection should be final. |
264
|
| Parameter tableName should be final. |
264
|
| Method 'getIdAsLong' is not designed for extension - needs to be abstract, final or empty. |
283
|
| Parameter connection should be final. |
283
|
| Parameter tableName should be final. |
283
|
| Method 'getIdAsBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
301
|
| Parameter connection should be final. |
301
|
| Parameter tableName should be final. |
302
|
| Method 'getIdAsString' is not designed for extension - needs to be abstract, final or empty. |
321
|
| Parameter connection should be final. |
321
|
| Parameter tableName should be final. |
321
|
| Method 'isPriorToInsert' is not designed for extension - needs to be abstract, final or empty. |
332
|
| Method 'isPostInsert' is not designed for extension - needs to be abstract, final or empty. |
342
|
| Method 'isConnectionRequired' is not designed for extension - needs to be abstract, final or empty. |
353
|
| Method 'getNextIds' is not designed for extension - needs to be abstract, final or empty. |
366
|
| Parameter tableName should be final. |
366
|
| Parameter numOfIdsToReturn should be final. |
367
|
| Method 'getNextIds' is not designed for extension - needs to be abstract, final or empty. |
386
|
| Parameter tableName should be final. |
386
|
| Parameter numOfIdsToReturn should be final. |
387
|
| Parameter connection should be final. |
388
|
| Avoid inline conditionals. |
422
|
| Method 'exists' is not designed for extension - needs to be abstract, final or empty. |
450
|
| Parameter tableName should be final. |
450
|
| Redundant throws: 'TorqueException' is subclass of 'Exception'. |
451
|
| '100' is a magic number. |
453
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
492
|
| Must have at least one statement. |
504
|
| Line is longer than 80 characters. |
530
|
| Method 'stop' is not designed for extension - needs to be abstract, final or empty. |
551
|
| Parameter tableName should be final. |
565
|
| Parameter tableName should be final. |
612
|
| Parameter adjustQuantity should be final. |
613
|
| Parameter connection should be final. |
614
|
| Parameter tableName should be final. |
703
|
| Parameter connection should be final. |
703
|
| '10' is a magic number. |
739
|
| Parameter con should be final. |
766
|
| Parameter tableName should be final. |
766
|
| Parameter con should be final. |
824
|
| Parameter tableName should be final. |
824
|
| Parameter id should be final. |
824
|
| '50' is a magic number. |
830
|
| Parameter con should be final. |
872
|
| Parameter tableName should be final. |
872
|
| Parameter quantity should be final. |
873
|
| '50' is a magic number. |
877
|
org/apache/torque/oid/IDGeneratorFactory.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Utility classes should not have a public or default constructor. |
29
|
| Parameter dbAdapter should be final. |
50
|
org/apache/torque/oid/IdGenerator.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
org/apache/torque/oid/SequenceIdGenerator.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Name 'dbAdapter' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
| Parameter adapter should be final. |
51
|
| Method 'getIdAsInt' is not designed for extension - needs to be abstract, final or empty. |
64
|
| Parameter connection should be final. |
64
|
| Parameter keyInfo should be final. |
64
|
| Method 'getIdAsLong' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Parameter connection should be final. |
78
|
| Parameter keyInfo should be final. |
78
|
| Method 'getIdAsBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
92
|
| Parameter connection should be final. |
92
|
| Parameter keyInfo should be final. |
92
|
| Method 'getIdAsString' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Parameter connection should be final. |
106
|
| Parameter keyInfo should be final. |
106
|
| Method 'isPriorToInsert' is not designed for extension - needs to be abstract, final or empty. |
117
|
| Method 'isPostInsert' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Method 'isConnectionRequired' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Parameter connection should be final. |
151
|
| Parameter keyInfo should be final. |
151
|
org/apache/torque/om/BaseObject.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'isNew' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
| Name 'primaryKey' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
51
|
| Name 'modified' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
60
|
| Name 'log' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
63
|
| Method 'getPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
70
|
| Method 'isModified' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Method 'isNew' is not designed for extension - needs to be abstract, final or empty. |
92
|
| Method 'setNew' is not designed for extension - needs to be abstract, final or empty. |
103
|
| Parameter b should be final. |
103
|
| Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Parameter primaryKey should be final. |
115
|
| 'primaryKey' hides a field. |
115
|
| Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Parameter primaryKey should be final. |
127
|
| 'primaryKey' hides a field. |
127
|
| Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
139
|
| Parameter primaryKey should be final. |
139
|
| 'primaryKey' hides a field. |
139
|
| Method 'setModified' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Parameter m should be final. |
149
|
| Method 'resetModified' is not designed for extension - needs to be abstract, final or empty. |
157
|
| Method 'getByName' is not designed for extension - needs to be abstract, final or empty. |
170
|
| Parameter field should be final. |
170
|
| Method 'getByPeerName' is not designed for extension - needs to be abstract, final or empty. |
183
|
| Parameter name should be final. |
183
|
| Method 'getByPosition' is not designed for extension - needs to be abstract, final or empty. |
196
|
| Parameter pos should be final. |
196
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
209
|
| Parameter obj should be final. |
209
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
227
|
| Parameter bo should be final. |
227
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
253
|
| Method 'log' is not designed for extension - needs to be abstract, final or empty. |
270
|
| Method 'getLog' is not designed for extension - needs to be abstract, final or empty. |
280
|
| Parameter dbName should be final. |
297
|
| Parameter con should be final. |
302
|
org/apache/torque/om/ComboKey.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'key' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
| Parameter keys should be final. |
59
|
| Parameter keys should be final. |
70
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Parameter keys should be final. |
80
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Parameter keys should be final. |
91
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
147
|
| Parameter keys should be final. |
147
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
157
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
169
|
| Parameter keyObj should be final. |
169
|
| Method 'looseEquals' is not designed for extension - needs to be abstract, final or empty. |
207
|
| Parameter keyObj should be final. |
207
|
| Method 'appendTo' is not designed for extension - needs to be abstract, final or empty. |
255
|
| Parameter sb should be final. |
255
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
296
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
322
|
org/apache/torque/om/DateKey.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Parameter key should be final. |
46
|
| Redundant throws: 'NumberFormatException' is unchecked exception. |
46
|
| Parameter key should be final. |
56
|
| Parameter key should be final. |
66
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Parameter key should be final. |
83
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Parameter key should be final. |
93
|
| Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
123
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
123
|
| Parameter keyObj should be final. |
123
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
150
|
| Avoid inline conditionals. |
153
|
org/apache/torque/om/NumberKey.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Parameter key should be final. |
46
|
| Parameter key should be final. |
56
|
| Parameter key should be final. |
66
|
| Parameter key should be final. |
83
|
| Parameter key should be final. |
93
|
| Parameter key should be final. |
104
|
| Parameter key should be final. |
115
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
134
|
| Parameter key should be final. |
134
|
| Redundant throws: 'NumberFormatException' is unchecked exception. |
134
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
144
|
| Parameter key should be final. |
144
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
154
|
| Parameter key should be final. |
154
|
| Avoid inline conditionals. |
156
|
| Method 'getBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
164
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
176
|
| Parameter keyObj should be final. |
176
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
211
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
227
|
| Parameter o should be final. |
227
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
238
|
| Method 'byteValue' is not designed for extension - needs to be abstract, final or empty. |
254
|
| Method 'intValue' is not designed for extension - needs to be abstract, final or empty. |
271
|
| Method 'shortValue' is not designed for extension - needs to be abstract, final or empty. |
288
|
| Method 'longValue' is not designed for extension - needs to be abstract, final or empty. |
300
|
| Method 'floatValue' is not designed for extension - needs to be abstract, final or empty. |
315
|
| Method 'doubleValue' is not designed for extension - needs to be abstract, final or empty. |
330
|
org/apache/torque/om/ObjectKey.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Name 'key' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
36
|
| Variable 'key' must be private and have accessor methods. |
36
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Method 'appendTo' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Parameter sb should be final. |
76
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Parameter obj should be final. |
87
|
| Parameter s should be final. |
98
|
org/apache/torque/om/Persistent.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
org/apache/torque/om/SimpleKey.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Line has trailing spaces. |
21
|
| Line has trailing spaces. |
33
|
| Parameter key should be final. |
34
|
| Line has trailing spaces. |
43
|
| Parameter key should be final. |
44
|
| Line has trailing spaces. |
53
|
| Parameter key should be final. |
54
|
| Line has trailing spaces. |
63
|
| Parameter key should be final. |
64
|
| Line has trailing spaces. |
73
|
| Parameter key should be final. |
74
|
| Line has trailing spaces. |
83
|
| Parameter key should be final. |
84
|
| Line has trailing spaces. |
93
|
| Parameter key should be final. |
94
|
| Line has trailing spaces. |
103
|
| Parameter key should be final. |
104
|
| Line has trailing spaces. |
113
|
| Parameter key should be final. |
114
|
| Line has trailing spaces. |
123
|
| Parameter key should be final. |
124
|
org/apache/torque/om/StringKey.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Parameter key should be final. |
43
|
| Parameter key should be final. |
53
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
70
|
| Parameter key should be final. |
70
|
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Parameter key should be final. |
80
|
| Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
110
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Parameter keyObj should be final. |
110
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
136
|
org/apache/torque/package.html
Error | Line |
| Missing package documentation file. | 0 |
org/apache/torque/pool/ConnectionPool.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| '60' is a magic number. |
55
|
| '60' is a magic number. |
55
|
| '1000' is a magic number. |
55
|
| '10' is a magic number. |
58
|
| '1000' is a magic number. |
58
|
| Name 'pool' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
61
|
| Name 'url' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
64
|
| Name 'username' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
67
|
| Name 'password' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
70
|
| Name 'totalConnections' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
73
|
| Name 'maxConnections' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
76
|
| Name 'expiryTime' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
79
|
| Name 'waitCount' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
85
|
| Name 'logInterval' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
91
|
| Name 'monitor' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
94
|
| Name 'connectionWaitTimeout' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
100
|
| Name 'cpds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
103
|
| Name 'timeStamps' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
109
|
| Parameter cpds should be final. |
123
|
| 'cpds' hides a field. |
123
|
| Parameter username should be final. |
123
|
| 'username' hides a field. |
123
|
| Parameter password should be final. |
124
|
| 'password' hides a field. |
124
|
| Parameter maxConnections should be final. |
124
|
| 'maxConnections' hides a field. |
124
|
| Parameter expiryTime should be final. |
124
|
| 'expiryTime' hides a field. |
124
|
| Parameter connectionWaitTimeout should be final. |
125
|
| 'connectionWaitTimeout' hides a field. |
125
|
| Parameter logInterval should be final. |
125
|
| 'logInterval' hides a field. |
125
|
| Avoid inline conditionals. |
136
|
| Avoid inline conditionals. |
139
|
| '1000' is a magic number. |
139
|
| Avoid inline conditionals. |
143
|
| '1000' is a magic number. |
143
|
| '1000' is a magic number. |
146
|
| Parameter username should be final. |
173
|
| 'username' hides a field. |
173
|
| Parameter password should be final. |
174
|
| 'password' hides a field. |
174
|
| '4' is a magic number. |
235
|
| Avoid inline conditionals. |
238
|
| Must have at least one statement. |
268
|
| Comment matches to-do format 'TODO:'. |
326
|
| Parameter pc should be final. |
337
|
| Avoid inline conditionals. |
346
|
| Parameter connection should be final. |
358
|
| Must have at least one statement. |
413
|
| Parameter event should be final. |
486
|
| Parameter event should be final. |
497
|
| Must have at least one statement. |
508
|
| Must have at least one statement. |
517
|
| Parameter pcon should be final. |
528
|
| Parameter pcon should be final. |
545
|
| Name 'isRun' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
579
|
| Must have at least one statement. |
603
|
org/apache/torque/pool/ConnectionWaitTimeoutException.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Parameter url should be final. |
34
|
org/apache/torque/pool/TorqueClassicDataSource.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'dataSourceName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
59
|
| Name 'description' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
62
|
| Name 'loginTimeout' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
65
|
| Name 'cpds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
68
|
| Name 'logWriter' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
71
|
| Name 'jndiEnvironment' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
74
|
| Name 'defaultMaxConnections' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
77
|
| Name 'perUserMaxConnections' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
83
|
| Name 'maxExpiryTime' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
86
|
| Name 'connectionWaitTimeout' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
92
|
| Name 'logInterval' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
95
|
| Name 'defaultAutoCommit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
98
|
| Name 'defaultReadOnly' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
101
|
| Method 'getDefaultMaxConnections' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Method 'setDefaultMaxConnections' is not designed for extension - needs to be abstract, final or empty. |
132
|
| Parameter v should be final. |
132
|
| Method 'getPerUserMaxConnections' is not designed for extension - needs to be abstract, final or empty. |
144
|
| Method 'setPerUserMaxConnections' is not designed for extension - needs to be abstract, final or empty. |
156
|
| Parameter v should be final. |
156
|
| Method 'getMaxExpiryTime' is not designed for extension - needs to be abstract, final or empty. |
167
|
| Method 'setMaxExpiryTime' is not designed for extension - needs to be abstract, final or empty. |
178
|
| Parameter v should be final. |
178
|
| Method 'getConnectionWaitTimeout' is not designed for extension - needs to be abstract, final or empty. |
190
|
| Method 'setConnectionWaitTimeout' is not designed for extension - needs to be abstract, final or empty. |
202
|
| Parameter v should be final. |
202
|
| Method 'getLogInterval' is not designed for extension - needs to be abstract, final or empty. |
214
|
| Method 'setLogInterval' is not designed for extension - needs to be abstract, final or empty. |
226
|
| Parameter v should be final. |
226
|
| Method 'isDefaultAutoCommit' is not designed for extension - needs to be abstract, final or empty. |
239
|
| Method 'setDefaultAutoCommit' is not designed for extension - needs to be abstract, final or empty. |
252
|
| Parameter v should be final. |
252
|
| Method 'isDefaultReadOnly' is not designed for extension - needs to be abstract, final or empty. |
265
|
| Method 'setDefaultReadOnly' is not designed for extension - needs to be abstract, final or empty. |
278
|
| Parameter v should be final. |
278
|
| Method 'getDataSourceName' is not designed for extension - needs to be abstract, final or empty. |
290
|
| Method 'setDataSourceName' is not designed for extension - needs to be abstract, final or empty. |
302
|
| Parameter v should be final. |
302
|
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. |
322
|
| Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. |
334
|
| Parameter v should be final. |
334
|
| Method 'getJndiEnvironment' is not designed for extension - needs to be abstract, final or empty. |
348
|
| Parameter key should be final. |
348
|
| Method 'setJndiEnvironment' is not designed for extension - needs to be abstract, final or empty. |
366
|
| Parameter key should be final. |
366
|
| Parameter value should be final. |
366
|
| Method 'getConnectionPoolDataSource' is not designed for extension - needs to be abstract, final or empty. |
382
|
| Method 'setConnectionPoolDataSource' is not designed for extension - needs to be abstract, final or empty. |
393
|
| Parameter v should be final. |
393
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
418
|
| Expected @throws tag for 'SQLException'. |
418
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
431
|
| Parameter username should be final. |
431
|
| Parameter password should be final. |
432
|
| Expected @throws tag for 'SQLException'. |
433
|
| Expected an @return tag. |
461
|
| Parameter suffix should be final. |
461
|
| Expected @param tag for 'suffix'. |
461
|
| 'private' modifier out of order with the JLS suggestions. |
483
|
| Parameter username should be final. |
483
|
| Parameter password should be final. |
483
|
| Expected @throws tag for 'javax.naming.NamingException'. |
484
|
| 'cpds' hides a field. |
489
|
| Method 'getLoginTimeout' is not designed for extension - needs to be abstract, final or empty. |
534
|
| Method 'getLogWriter' is not designed for extension - needs to be abstract, final or empty. |
545
|
| Method 'setLoginTimeout' is not designed for extension - needs to be abstract, final or empty. |
560
|
| Parameter seconds should be final. |
560
|
| Method 'setLogWriter' is not designed for extension - needs to be abstract, final or empty. |
571
|
| Parameter out should be final. |
571
|
| Method 'getReference' is not designed for extension - needs to be abstract, final or empty. |
582
|
| Expected @throws tag for 'NamingException'. |
582
|
| Method 'getObjectInstance' is not designed for extension - needs to be abstract, final or empty. |
628
|
| Parameter refObj should be final. |
628
|
| Expected @param tag for 'refObj'. |
628
|
| Parameter name should be final. |
628
|
| Expected @param tag for 'name'. |
628
|
| Parameter context should be final. |
629
|
| Expected @param tag for 'context'. |
629
|
| Parameter env should be final. |
629
|
| Expected @param tag for 'env'. |
629
|
| Expected @throws tag for 'Exception'. |
630
|
org/apache/torque/util/BasePeer.java
Error | Line |
| File length is 2,373 lines (max allowed is 2,000). |
1
|
| Line does not match expected header line of ' Apache License'. |
2
|
| Utility classes should not have a public or default constructor. |
79
|
| Line has trailing spaces. |
93
|
| Line has trailing spaces. |
95
|
| Line has trailing spaces. |
96
|
| '5' is a magic number. |
102
|
| Variable 'log' must be private and have accessor methods. |
105
|
| Parameter hash should be final. |
115
|
| Must have at least one statement. |
162
|
| Must have at least one statement. |
173
|
| Must have at least one statement. |
184
|
| Missing a Javadoc comment. |
191
|
| Parameter e should be final. |
191
|
| Line has trailing spaces. |
194
|
| 'cast' is not followed by whitespace. |
196
|
| Line has trailing spaces. |
198
|
| Parameter tableName should be final. |
211
|
| Parameter tableName should be final. |
225
|
| Parameter dbName should be final. |
225
|
| Parameter schema should be final. |
256
|
| Parameter columns should be final. |
283
|
| Parameter tableName should be final. |
302
|
| Parameter columnNames should be final. |
303
|
| Parameter con should be final. |
326
|
| Parameter table should be final. |
327
|
| Parameter column should be final. |
328
|
| Parameter value should be final. |
329
|
| Must have at least one statement. |
360
|
| Parameter table should be final. |
378
|
| Parameter column should be final. |
378
|
| Parameter value should be final. |
378
|
| Parameter criteria should be final. |
402
|
| Parameter criteria should be final. |
428
|
| Parameter con should be final. |
428
|
| Line is longer than 80 characters. |
529
|
| Must have at least one statement. |
562
|
| Parameter criteria should be final. |
593
|
| Parameter criteria should be final. |
640
|
| Parameter con should be final. |
640
|
| Parameter rec should be final. |
762
|
| Parameter tableName should be final. |
763
|
| Parameter criteria should be final. |
764
|
| Avoid inline conditionals. |
809
|
| Parameter criteria should be final. |
884
|
| Parameter criteria should be final. |
898
|
| Method length is 263 lines (max allowed is 150). |
914
|
| Parameter criteria should be final. |
914
|
| Parameter criteria should be final. |
1188
|
| Parameter criteria should be final. |
1218
|
| Parameter con should be final. |
1218
|
| Parameter queryString should be final. |
1254
|
| Parameter queryString should be final. |
1270
|
| Parameter dbName should be final. |
1270
|
| Parameter queryString should be final. |
1288
|
| Parameter dbName should be final. |
1289
|
| Parameter singleRecord should be final. |
1290
|
| Parameter queryString should be final. |
1308
|
| Parameter singleRecord should be final. |
1309
|
| Parameter con should be final. |
1310
|
| Parameter queryString should be final. |
1330
|
| Parameter start should be final. |
1331
|
| Parameter numberOfResults should be final. |
1332
|
| Parameter dbName should be final. |
1333
|
| Parameter singleRecord should be final. |
1334
|
| Parameter queryString should be final. |
1371
|
| Parameter start should be final. |
1372
|
| Parameter numberOfResults should be final. |
1373
|
| Parameter singleRecord should be final. |
1374
|
| Parameter con should be final. |
1375
|
| Line has trailing spaces. |
1387
|
| Must have at least one statement. |
1406
|
| Parameter qds should be final. |
1423
|
| Parameter qds should be final. |
1440
|
| Parameter singleRecord should be final. |
1440
|
| Expected @param tag for 'singleRecord'. |
1440
|
| Parameter qds should be final. |
1460
|
| Parameter numberOfResults should be final. |
1461
|
| Expected @param tag for 'numberOfResults'. |
1461
|
| Parameter singleRecord should be final. |
1462
|
| Expected @param tag for 'singleRecord'. |
1462
|
| Parameter qds should be final. |
1490
|
| Parameter start should be final. |
1491
|
| Parameter numberOfResults should be final. |
1492
|
| Parameter singleRecord should be final. |
1493
|
| Parameter criteria should be final. |
1546
|
| Parameter updateValues should be final. |
1599
|
| Parameter updateValues should be final. |
1636
|
| Parameter con should be final. |
1636
|
| Parameter selectCriteria should be final. |
1672
|
| Parameter updateValues should be final. |
1672
|
| Parameter selectCriteria should be final. |
1708
|
| Parameter updateValues should be final. |
1709
|
| Parameter con should be final. |
1710
|
| Line is longer than 80 characters. |
1770
|
| Parameter stmt should be final. |
1819
|
| Parameter stmt should be final. |
1835
|
| Parameter dbName should be final. |
1835
|
| Parameter stmt should be final. |
1863
|
| Parameter con should be final. |
1863
|
| Parameter ds should be final. |
1904
|
| Parameter name should be final. |
1938
|
| The double-checked locking idiom is broken and should be avoided. |
1950
|
| Expected an @return tag. |
2004
|
| Parameter criteria should be final. |
2004
|
| Expected @param tag for 'criteria'. |
2004
|
| Parameter con should be final. |
2004
|
| Expected @param tag for 'con'. |
2004
|
| Expected an @return tag. |
2080
|
| Parameter criteria should be final. |
2080
|
| Expected @param tag for 'criteria'. |
2080
|
| Method length is 236 lines (max allowed is 150). |
2106
|
| Parameter criteria should be final. |
2107
|
| Expected @param tag for 'criteria'. |
2107
|
| Parameter queryString should be final. |
2108
|
| Expected @param tag for 'queryString'. |
2108
|
| Parameter params should be final. |
2109
|
| Expected @param tag for 'params'. |
2109
|
| Parameter criteriaPhrase should be final. |
2363
|
| Parameter columnName should be final. |
2364
|
org/apache/torque/util/Criteria.java
Error | Line |
| File length is 3,563 lines (max allowed is 2,000). |
1
|
| Line does not match expected header line of ' Apache License'. |
2
|
| Missing a Javadoc comment. |
130
|
| Missing a Javadoc comment. |
132
|
| Name 'ignoreCase' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
132
|
| Missing a Javadoc comment. |
133
|
| Name 'singleRecord' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
133
|
| Missing a Javadoc comment. |
134
|
| Name 'cascade' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
134
|
| Missing a Javadoc comment. |
135
|
| Name 'selectModifiers' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
135
|
| Missing a Javadoc comment. |
136
|
| Name 'selectColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
136
|
| Missing a Javadoc comment. |
137
|
| Name 'orderByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
137
|
| Missing a Javadoc comment. |
138
|
| Name 'groupByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
138
|
| Missing a Javadoc comment. |
139
|
| Name 'having' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
139
|
| Missing a Javadoc comment. |
140
|
| Name 'asColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
140
|
| '8' is a magic number. |
140
|
| Missing a Javadoc comment. |
141
|
| Name 'joinL' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
141
|
| Missing a Javadoc comment. |
142
|
| Name 'joinR' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
142
|
| Name 'dbName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
145
|
| Name 'originalDbName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
148
|
| Name 'limit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
154
|
| Name 'offset' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
157
|
| Missing a Javadoc comment. |
159
|
| Name 'aliases' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
159
|
| Missing a Javadoc comment. |
161
|
| Name 'useTransaction' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
161
|
| Parameter initialCapacity should be final. |
179
|
| Parameter dbName should be final. |
190
|
| 'dbName' hides a field. |
190
|
| Parameter dbName should be final. |
202
|
| 'dbName' hides a field. |
202
|
| Parameter initialCapacity should be final. |
202
|
| Method 'clear' is not designed for extension - needs to be abstract, final or empty. |
214
|
| Method 'addAsColumn' is not designed for extension - needs to be abstract, final or empty. |
252
|
| Parameter name should be final. |
252
|
| Parameter clause should be final. |
252
|
| Method 'getAsColumns' is not designed for extension - needs to be abstract, final or empty. |
264
|
| Method 'addAlias' is not designed for extension - needs to be abstract, final or empty. |
276
|
| Parameter alias should be final. |
276
|
| Parameter table should be final. |
276
|
| '8' is a magic number. |
280
|
| Method 'getTableForAlias' is not designed for extension - needs to be abstract, final or empty. |
291
|
| Parameter alias should be final. |
291
|
| Method 'containsKey' is not designed for extension - needs to be abstract, final or empty. |
307
|
| Parameter table should be final. |
307
|
| Parameter column should be final. |
307
|
| Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
318
|
| Parameter column should be final. |
318
|
| Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
330
|
| Parameter table should be final. |
330
|
| Parameter column should be final. |
330
|
| Method 'setUseTransaction' is not designed for extension - needs to be abstract, final or empty. |
343
|
| Parameter v should be final. |
343
|
| Expected @param tag for 'v'. |
343
|
| Method 'isUseTransaction' is not designed for extension - needs to be abstract, final or empty. |
354
|
| Method 'getCriterion' is not designed for extension - needs to be abstract, final or empty. |
365
|
| Parameter column should be final. |
365
|
| Method 'getCriterion' is not designed for extension - needs to be abstract, final or empty. |
377
|
| Parameter table should be final. |
377
|
| Parameter column should be final. |
377
|
| Method 'getNewCriterion' is not designed for extension - needs to be abstract, final or empty. |
393
|
| Parameter column should be final. |
393
|
| Parameter value should be final. |
393
|
| Expected @param tag for 'value'. |
393
|
| Parameter comparison should be final. |
394
|
| Expected @param tag for 'comparison'. |
394
|
| Method 'getNewCriterion' is not designed for extension - needs to be abstract, final or empty. |
408
|
| Parameter table should be final. |
408
|
| Parameter column should be final. |
408
|
| Parameter value should be final. |
409
|
| Expected @param tag for 'value'. |
409
|
| Parameter comparison should be final. |
409
|
| Expected @param tag for 'comparison'. |
409
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
432
|
| Parameter c should be final. |
432
|
| Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
449
|
| Parameter name should be final. |
449
|
| Method 'getComparison' is not designed for extension - needs to be abstract, final or empty. |
460
|
| Parameter key should be final. |
460
|
| Method 'getComparison' is not designed for extension - needs to be abstract, final or empty. |
472
|
| Parameter table should be final. |
472
|
| Parameter column should be final. |
472
|
| Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
486
|
| Parameter name should be final. |
486
|
| Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
498
|
| Parameter table should be final. |
498
|
| Parameter column should be final. |
498
|
| Method 'getDbName' is not designed for extension - needs to be abstract, final or empty. |
512
|
| Method 'setDbName' is not designed for extension - needs to be abstract, final or empty. |
523
|
| Parameter dbName should be final. |
523
|
| 'dbName' hides a field. |
523
|
| Avoid inline conditionals. |
525
|
| Method 'getDouble' is not designed for extension - needs to be abstract, final or empty. |
534
|
| Parameter name should be final. |
534
|
| Method 'getDouble' is not designed for extension - needs to be abstract, final or empty. |
551
|
| Parameter table should be final. |
551
|
| Parameter column should be final. |
551
|
| Method 'getFloat' is not designed for extension - needs to be abstract, final or empty. |
564
|
| Parameter name should be final. |
564
|
| Method 'getFloat' is not designed for extension - needs to be abstract, final or empty. |
581
|
| Parameter table should be final. |
581
|
| Parameter column should be final. |
581
|
| Method 'getInteger' is not designed for extension - needs to be abstract, final or empty. |
594
|
| Parameter name should be final. |
594
|
| Method 'getInteger' is not designed for extension - needs to be abstract, final or empty. |
611
|
| Parameter table should be final. |
611
|
| Parameter column should be final. |
611
|
| Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
625
|
| Parameter name should be final. |
625
|
| Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
642
|
| Parameter table should be final. |
642
|
| Parameter column should be final. |
642
|
| Method 'getBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
656
|
| Parameter name should be final. |
656
|
| Method 'getBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
673
|
| Parameter table should be final. |
673
|
| Parameter column should be final. |
673
|
| Method 'getLong' is not designed for extension - needs to be abstract, final or empty. |
687
|
| Parameter name should be final. |
687
|
| Method 'getLong' is not designed for extension - needs to be abstract, final or empty. |
704
|
| Parameter table should be final. |
704
|
| Parameter column should be final. |
704
|
| Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
718
|
| Parameter name should be final. |
718
|
| Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
730
|
| Parameter table should be final. |
730
|
| Parameter column should be final. |
730
|
| Method 'getTableName' is not designed for extension - needs to be abstract, final or empty. |
744
|
| Parameter name should be final. |
744
|
| Method 'getList' is not designed for extension - needs to be abstract, final or empty. |
755
|
| Parameter name should be final. |
755
|
| Method 'getList' is not designed for extension - needs to be abstract, final or empty. |
767
|
| Parameter table should be final. |
767
|
| Parameter column should be final. |
767
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
781
|
| Parameter name should be final. |
781
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
793
|
| Parameter table should be final. |
793
|
| Parameter column should be final. |
793
|
| Method 'getObjectKey' is not designed for extension - needs to be abstract, final or empty. |
807
|
| Parameter name should be final. |
807
|
| Method 'getObjectKey' is not designed for extension - needs to be abstract, final or empty. |
819
|
| Parameter table should be final. |
819
|
| Parameter column should be final. |
819
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
834
|
| Parameter key should be final. |
834
|
| Unused @throws tag for 'NullPointerException'. |
851
|
| Method 'put' is not designed for extension - needs to be abstract, final or empty. |
854
|
| Parameter key should be final. |
854
|
| Parameter value should be final. |
854
|
| Method 'putAll' is not designed for extension - needs to be abstract, final or empty. |
874
|
| Parameter t should be final. |
874
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
937
|
| Parameter column should be final. |
937
|
| Parameter value should be final. |
937
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
967
|
| Parameter column should be final. |
967
|
| Parameter value should be final. |
967
|
| Parameter comparison should be final. |
967
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
993
|
| Parameter table should be final. |
993
|
| Parameter column should be final. |
993
|
| Parameter value should be final. |
993
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1021
|
| Parameter table should be final. |
1021
|
| Parameter column should be final. |
1022
|
| Parameter value should be final. |
1023
|
| Parameter comparison should be final. |
1024
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1050
|
| Parameter column should be final. |
1050
|
| Parameter value should be final. |
1050
|
| Avoid inline conditionals. |
1052
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1071
|
| Parameter column should be final. |
1071
|
| Parameter value should be final. |
1071
|
| Parameter comparison should be final. |
1071
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1090
|
| Parameter column should be final. |
1090
|
| Parameter value should be final. |
1090
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1111
|
| Parameter column should be final. |
1111
|
| Parameter value should be final. |
1111
|
| Parameter comparison should be final. |
1111
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1130
|
| Parameter column should be final. |
1130
|
| Parameter value should be final. |
1130
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1151
|
| Parameter column should be final. |
1151
|
| Parameter value should be final. |
1151
|
| Parameter comparison should be final. |
1151
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1170
|
| Parameter column should be final. |
1170
|
| Parameter value should be final. |
1170
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1191
|
| Parameter column should be final. |
1191
|
| Parameter value should be final. |
1191
|
| Parameter comparison should be final. |
1191
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1210
|
| Parameter column should be final. |
1210
|
| Parameter value should be final. |
1210
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1231
|
| Parameter column should be final. |
1231
|
| Parameter value should be final. |
1231
|
| Parameter comparison should be final. |
1231
|
| Method 'addDate' is not designed for extension - needs to be abstract, final or empty. |
1254
|
| Parameter column should be final. |
1254
|
| Parameter year should be final. |
1254
|
| Parameter month should be final. |
1254
|
| Parameter date should be final. |
1254
|
| Method 'addDate' is not designed for extension - needs to be abstract, final or empty. |
1279
|
| Parameter column should be final. |
1279
|
| Parameter year should be final. |
1279
|
| Parameter month should be final. |
1279
|
| Parameter date should be final. |
1279
|
| Parameter comparison should be final. |
1280
|
| Method 'addJoin' is not designed for extension - needs to be abstract, final or empty. |
1302
|
| Parameter left should be final. |
1302
|
| Parameter right should be final. |
1302
|
| '3' is a magic number. |
1306
|
| '3' is a magic number. |
1307
|
| Expected an @return tag. |
1319
|
| Method 'getJoinL' is not designed for extension - needs to be abstract, final or empty. |
1319
|
| Expected an @return tag. |
1328
|
| Method 'getJoinR' is not designed for extension - needs to be abstract, final or empty. |
1328
|
| Method 'addIn' is not designed for extension - needs to be abstract, final or empty. |
1351
|
| Parameter column should be final. |
1351
|
| Parameter values should be final. |
1351
|
| Method 'addIn' is not designed for extension - needs to be abstract, final or empty. |
1374
|
| Parameter column should be final. |
1374
|
| Parameter values should be final. |
1374
|
| Method 'addIn' is not designed for extension - needs to be abstract, final or empty. |
1398
|
| Parameter column should be final. |
1398
|
| Parameter values should be final. |
1398
|
| Method 'addNotIn' is not designed for extension - needs to be abstract, final or empty. |
1422
|
| Parameter column should be final. |
1422
|
| Parameter values should be final. |
1422
|
| Method 'addNotIn' is not designed for extension - needs to be abstract, final or empty. |
1445
|
| Parameter column should be final. |
1445
|
| Parameter values should be final. |
1445
|
| Method 'addNotIn' is not designed for extension - needs to be abstract, final or empty. |
1469
|
| Parameter column should be final. |
1469
|
| Parameter values should be final. |
1469
|
| Method 'setAll' is not designed for extension - needs to be abstract, final or empty. |
1478
|
| Method 'setDistinct' is not designed for extension - needs to be abstract, final or empty. |
1486
|
| Method 'setIgnoreCase' is not designed for extension - needs to be abstract, final or empty. |
1497
|
| Parameter b should be final. |
1497
|
| Method 'isIgnoreCase' is not designed for extension - needs to be abstract, final or empty. |
1508
|
| Method 'setSingleRecord' is not designed for extension - needs to be abstract, final or empty. |
1526
|
| Parameter b should be final. |
1526
|
| Method 'isSingleRecord' is not designed for extension - needs to be abstract, final or empty. |
1537
|
| Method 'setCascade' is not designed for extension - needs to be abstract, final or empty. |
1548
|
| Parameter b should be final. |
1548
|
| Method 'isCascade' is not designed for extension - needs to be abstract, final or empty. |
1559
|
| Method 'setLimit' is not designed for extension - needs to be abstract, final or empty. |
1570
|
| Parameter limit should be final. |
1570
|
| 'limit' hides a field. |
1570
|
| Method 'getLimit' is not designed for extension - needs to be abstract, final or empty. |
1581
|
| Method 'setOffset' is not designed for extension - needs to be abstract, final or empty. |
1592
|
| Parameter offset should be final. |
1592
|
| 'offset' hides a field. |
1592
|
| Method 'getOffset' is not designed for extension - needs to be abstract, final or empty. |
1603
|
| Method 'addSelectColumn' is not designed for extension - needs to be abstract, final or empty. |
1614
|
| Parameter name should be final. |
1614
|
| Method 'getSelectColumns' is not designed for extension - needs to be abstract, final or empty. |
1626
|
| Method 'getSelectModifiers' is not designed for extension - needs to be abstract, final or empty. |
1636
|
| Method 'addGroupByColumn' is not designed for extension - needs to be abstract, final or empty. |
1647
|
| Parameter groupBy should be final. |
1647
|
| Method 'addAscendingOrderByColumn' is not designed for extension - needs to be abstract, final or empty. |
1659
|
| Parameter name should be final. |
1659
|
| Method 'addDescendingOrderByColumn' is not designed for extension - needs to be abstract, final or empty. |
1671
|
| Parameter name should be final. |
1671
|
| Method 'getOrderByColumns' is not designed for extension - needs to be abstract, final or empty. |
1682
|
| Method 'getGroupByColumns' is not designed for extension - needs to be abstract, final or empty. |
1692
|
| Method 'getHaving' is not designed for extension - needs to be abstract, final or empty. |
1702
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
1713
|
| Parameter key should be final. |
1713
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
1728
|
| Line is longer than 80 characters. |
1741
|
| Must have at least one statement. |
1745
|
| Expected an @return tag. |
1755
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
1755
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
1755
|
| Parameter crit should be final. |
1755
|
| Expected @param tag for 'crit'. |
1755
|
| Method 'addHaving' is not designed for extension - needs to be abstract, final or empty. |
1829
|
| Parameter having should be final. |
1829
|
| 'having' hides a field. |
1829
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1853
|
| Parameter c should be final. |
1853
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1890
|
| Parameter column should be final. |
1890
|
| Parameter value should be final. |
1890
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1920
|
| Parameter column should be final. |
1920
|
| Parameter value should be final. |
1920
|
| Parameter comparison should be final. |
1920
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1955
|
| Parameter table should be final. |
1955
|
| Parameter column should be final. |
1955
|
| Parameter value should be final. |
1955
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1983
|
| Parameter table should be final. |
1983
|
| Parameter column should be final. |
1983
|
| Parameter value should be final. |
1983
|
| Parameter comparison should be final. |
1984
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2019
|
| Parameter column should be final. |
2019
|
| Parameter value should be final. |
2019
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2040
|
| Parameter column should be final. |
2040
|
| Parameter value should be final. |
2040
|
| Parameter comparison should be final. |
2040
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2059
|
| Parameter column should be final. |
2059
|
| Parameter value should be final. |
2059
|
| Line is longer than 80 characters. |
2076
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2079
|
| Parameter column should be final. |
2079
|
| Parameter value should be final. |
2079
|
| Parameter comparison should be final. |
2079
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2098
|
| Parameter column should be final. |
2098
|
| Parameter value should be final. |
2098
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2119
|
| Parameter column should be final. |
2119
|
| Parameter value should be final. |
2119
|
| Parameter comparison should be final. |
2119
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2138
|
| Parameter column should be final. |
2138
|
| Parameter value should be final. |
2138
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2159
|
| Parameter column should be final. |
2159
|
| Parameter value should be final. |
2159
|
| Parameter comparison should be final. |
2159
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2178
|
| Parameter column should be final. |
2178
|
| Parameter value should be final. |
2178
|
| Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2199
|
| Parameter column should be final. |
2199
|
| Parameter value should be final. |
2199
|
| Parameter comparison should be final. |
2199
|
| Method 'andDate' is not designed for extension - needs to be abstract, final or empty. |
2221
|
| Parameter column should be final. |
2221
|
| Parameter year should be final. |
2221
|
| Parameter month should be final. |
2221
|
| Parameter date should be final. |
2221
|
| Method 'andDate' is not designed for extension - needs to be abstract, final or empty. |
2245
|
| Parameter column should be final. |
2245
|
| Parameter year should be final. |
2245
|
| Parameter month should be final. |
2245
|
| Parameter date should be final. |
2245
|
| Parameter comparison should be final. |
2246
|
| Method 'andIn' is not designed for extension - needs to be abstract, final or empty. |
2270
|
| Parameter column should be final. |
2270
|
| Parameter values should be final. |
2270
|
| Method 'andIn' is not designed for extension - needs to be abstract, final or empty. |
2293
|
| Parameter column should be final. |
2293
|
| Parameter values should be final. |
2293
|
| Method 'andIn' is not designed for extension - needs to be abstract, final or empty. |
2317
|
| Parameter column should be final. |
2317
|
| Parameter values should be final. |
2317
|
| Method 'andNotIn' is not designed for extension - needs to be abstract, final or empty. |
2341
|
| Parameter column should be final. |
2341
|
| Parameter values should be final. |
2341
|
| Method 'andNotIn' is not designed for extension - needs to be abstract, final or empty. |
2364
|
| Parameter column should be final. |
2364
|
| Parameter values should be final. |
2364
|
| Method 'andNotIn' is not designed for extension - needs to be abstract, final or empty. |
2388
|
| Parameter column should be final. |
2388
|
| Parameter values should be final. |
2388
|
| Line is longer than 80 characters. |
2412
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2419
|
| Parameter c should be final. |
2419
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2456
|
| Parameter column should be final. |
2456
|
| Parameter value should be final. |
2456
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2485
|
| Parameter column should be final. |
2485
|
| Parameter value should be final. |
2485
|
| Parameter comparison should be final. |
2485
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2520
|
| Parameter table should be final. |
2520
|
| Parameter column should be final. |
2520
|
| Parameter value should be final. |
2520
|
| Line is longer than 80 characters. |
2544
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2547
|
| Parameter table should be final. |
2547
|
| Parameter column should be final. |
2547
|
| Parameter value should be final. |
2547
|
| Parameter comparison should be final. |
2548
|
| Line is longer than 80 characters. |
2550
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2581
|
| Parameter column should be final. |
2581
|
| Parameter value should be final. |
2581
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2602
|
| Parameter column should be final. |
2602
|
| Parameter value should be final. |
2602
|
| Parameter comparison should be final. |
2602
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2622
|
| Parameter column should be final. |
2622
|
| Parameter value should be final. |
2622
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2644
|
| Parameter column should be final. |
2644
|
| Parameter value should be final. |
2644
|
| Parameter comparison should be final. |
2644
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2663
|
| Parameter column should be final. |
2663
|
| Parameter value should be final. |
2663
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2684
|
| Parameter column should be final. |
2684
|
| Parameter value should be final. |
2684
|
| Parameter comparison should be final. |
2684
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2703
|
| Parameter column should be final. |
2703
|
| Parameter value should be final. |
2703
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2724
|
| Parameter column should be final. |
2724
|
| Parameter value should be final. |
2724
|
| Parameter comparison should be final. |
2724
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2743
|
| Parameter column should be final. |
2743
|
| Parameter value should be final. |
2743
|
| Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2764
|
| Parameter column should be final. |
2764
|
| Parameter value should be final. |
2764
|
| Parameter comparison should be final. |
2764
|
| Method 'orDate' is not designed for extension - needs to be abstract, final or empty. |
2786
|
| Parameter column should be final. |
2786
|
| Parameter year should be final. |
2786
|
| Parameter month should be final. |
2786
|
| Parameter date should be final. |
2786
|
| Method 'orDate' is not designed for extension - needs to be abstract, final or empty. |
2810
|
| Parameter column should be final. |
2810
|
| Parameter year should be final. |
2810
|
| Parameter month should be final. |
2810
|
| Parameter date should be final. |
2810
|
| Parameter comparison should be final. |
2811
|
| Method 'orIn' is not designed for extension - needs to be abstract, final or empty. |
2835
|
| Parameter column should be final. |
2835
|
| Parameter values should be final. |
2835
|
| Method 'orIn' is not designed for extension - needs to be abstract, final or empty. |
2858
|
| Parameter column should be final. |
2858
|
| Parameter values should be final. |
2858
|
| Method 'orIn' is not designed for extension - needs to be abstract, final or empty. |
2882
|
| Parameter column should be final. |
2882
|
| Parameter values should be final. |
2882
|
| Method 'orNotIn' is not designed for extension - needs to be abstract, final or empty. |
2906
|
| Parameter column should be final. |
2906
|
| Parameter values should be final. |
2906
|
| Method 'orNotIn' is not designed for extension - needs to be abstract, final or empty. |
2929
|
| Parameter column should be final. |
2929
|
| Parameter values should be final. |
2929
|
| Method 'orNotIn' is not designed for extension - needs to be abstract, final or empty. |
2953
|
| Parameter column should be final. |
2953
|
| Parameter values should be final. |
2953
|
| Line has trailing spaces. |
2964
|
| Parameter b should be final. |
2967
|
| Expected @param tag for 'b'. |
2967
|
| Line has trailing spaces. |
2969
|
| Missing a Javadoc comment. |
2978
|
| Missing a Javadoc comment. |
2979
|
| Name 'value' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
2982
|
| Name 'comparison' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
2985
|
| Name 'table' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
2988
|
| Name 'column' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
2991
|
| Name 'ignoreStringCase' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
2994
|
| Name 'db' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3000
|
| Name 'clauses' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3005
|
| Missing a Javadoc comment. |
3006
|
| Name 'conjunctions' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3006
|
| Parameter val should be final. |
3011
|
| Expected @param tag for 'val'. |
3011
|
| Parameter comp should be final. |
3011
|
| Expected @param tag for 'comp'. |
3011
|
| Parameter table should be final. |
3025
|
| 'table' hides a field. |
3025
|
| Parameter column should be final. |
3025
|
| 'column' hides a field. |
3025
|
| Parameter val should be final. |
3025
|
| Parameter comp should be final. |
3025
|
| Avoid inline conditionals. |
3028
|
| Avoid inline conditionals. |
3029
|
| Parameter tableColumn should be final. |
3040
|
| Parameter val should be final. |
3040
|
| Parameter comp should be final. |
3040
|
| Parameter table should be final. |
3063
|
| 'table' hides a field. |
3063
|
| Parameter column should be final. |
3063
|
| 'column' hides a field. |
3063
|
| Parameter val should be final. |
3063
|
| Parameter tableColumn should be final. |
3075
|
| Parameter val should be final. |
3075
|
| Parameter name should be final. |
3095
|
| 'db' hides a field. |
3138
|
| Parameter v should be final. |
3169
|
| Parameter b should be final. |
3185
|
| Expected an @return tag. |
3204
|
| Expected an @return tag. |
3212
|
| Expected an @return tag. |
3220
|
| Parameter criterion should be final. |
3220
|
| Expected @param tag for 'criterion'. |
3220
|
| Expected an @return tag. |
3230
|
| Parameter criterion should be final. |
3230
|
| Expected @param tag for 'criterion'. |
3230
|
| Parameter sb should be final. |
3240
|
| Expected @param tag for 'sb'. |
3240
|
| Parameter sb should be final. |
3298
|
| Parameter params should be final. |
3298
|
| 'db' hides a field. |
3305
|
| '25' is a magic number. |
3416
|
| Expected an @return tag. |
3425
|
| Parameter obj should be final. |
3425
|
| Expected @param tag for 'obj'. |
3425
|
| Expected an @return tag. |
3480
|
| Parameter c should be final. |
3518
|
| Expected @param tag for 'c'. |
3518
|
| Parameter s should be final. |
3518
|
| Expected @param tag for 's'. |
3518
|
| Expected an @return tag. |
3534
|
| Parameter c should be final. |
3551
|
| Expected @param tag for 'c'. |
3551
|
| Parameter a should be final. |
3551
|
| Expected @param tag for 'a'. |
3551
|
org/apache/torque/util/LargeSelect.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Name 'pageSize' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
139
|
| Name 'memoryLimit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
141
|
| Name 'blockBegin' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
144
|
| Name 'blockEnd' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
146
|
| Name 'currentlyFilledTo' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
148
|
| Name 'query' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
151
|
| Name 'dbName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
153
|
| Name 'qds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
155
|
| Name 'results' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
158
|
| Name 'thread' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
161
|
| Name 'killThread' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
166
|
| Name 'threadRunning' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
168
|
| Name 'queryCompleted' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
173
|
| Name 'totalsFinalized' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
178
|
| Name 'position' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
181
|
| Name 'totalPages' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
183
|
| Name 'totalRecords' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
185
|
| Name 'currentPageNumber' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
187
|
| Name 'criteria' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
190
|
| Name 'lastResults' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
192
|
| Name 'returnBuilderClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
198
|
| Name 'populateObjectsMethod' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
203
|
| Missing a Javadoc comment. |
212
|
| Missing a Javadoc comment. |
221
|
| Name 'params' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
224
|
| Parameter criteria should be final. |
243
|
| 'criteria' hides a field. |
243
|
| Parameter pageSize should be final. |
243
|
| 'pageSize' hides a field. |
243
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
244
|
| Parameter criteria should be final. |
266
|
| 'criteria' hides a field. |
266
|
| Parameter pageSize should be final. |
266
|
| 'pageSize' hides a field. |
266
|
| Parameter memoryPageLimit should be final. |
266
|
| 'memoryPageLimit' hides a field. |
266
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
267
|
| Parameter criteria should be final. |
297
|
| 'criteria' hides a field. |
297
|
| Parameter pageSize should be final. |
298
|
| 'pageSize' hides a field. |
298
|
| Parameter returnBuilderClassName should be final. |
299
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
300
|
| Parameter criteria should be final. |
337
|
| 'criteria' hides a field. |
337
|
| Parameter pageSize should be final. |
338
|
| 'pageSize' hides a field. |
338
|
| Parameter memoryPageLimit should be final. |
339
|
| 'memoryPageLimit' hides a field. |
339
|
| Parameter returnBuilderClassName should be final. |
340
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
341
|
| '{' is followed by whitespace. |
350
|
| '{' is followed by whitespace. |
353
|
| '{' is followed by whitespace. |
359
|
| Parameter criteria should be final. |
387
|
| 'criteria' hides a field. |
387
|
| Parameter pageSize should be final. |
387
|
| 'pageSize' hides a field. |
387
|
| Parameter memoryLimitPages should be final. |
387
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
388
|
| Unused @throws tag for 'IllegalArgumentException'. |
424
|
| Method 'getPage' is not designed for extension - needs to be abstract, final or empty. |
429
|
| Parameter pageNumber should be final. |
429
|
| Method 'getNextResults' is not designed for extension - needs to be abstract, final or empty. |
448
|
| Method 'getCurrentPageResults' is not designed for extension - needs to be abstract, final or empty. |
464
|
| Method 'getPreviousResults' is not designed for extension - needs to be abstract, final or empty. |
477
|
| Parameter start should be final. |
507
|
| Parameter start should be final. |
526
|
| Parameter size should be final. |
526
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
527
|
| '500' is a magic number. |
557
|
| '{' is followed by whitespace. |
632
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
653
|
| Parameter initialSize should be final. |
799
|
| '100' is a magic number. |
827
|
| Method 'getCurrentPageNumber' is not designed for extension - needs to be abstract, final or empty. |
843
|
| Method 'getTotalRecords' is not designed for extension - needs to be abstract, final or empty. |
858
|
| Method 'getPaginated' is not designed for extension - needs to be abstract, final or empty. |
869
|
| Method 'getTotalPages' is not designed for extension - needs to be abstract, final or empty. |
889
|
| Avoid inline conditionals. |
898
|
| Method 'getPageSize' is not designed for extension - needs to be abstract, final or empty. |
914
|
| Method 'getTotalsFinalized' is not designed for extension - needs to be abstract, final or empty. |
926
|
| Parameter moreIndicator should be final. |
937
|
| 'moreIndicator' hides a field. |
937
|
| Expected an @return tag. |
945
|
| Parameter memoryPageLimit should be final. |
958
|
| 'memoryPageLimit' hides a field. |
958
|
| Expected an @return tag. |
968
|
| Method 'getPageProgressText' is not designed for extension - needs to be abstract, final or empty. |
980
|
| Method 'getCurrentPageSize' is not designed for extension - needs to be abstract, final or empty. |
1001
|
| Method 'getFirstRecordNoForPage' is not designed for extension - needs to be abstract, final or empty. |
1015
|
| Method 'getLastRecordNoForPage' is not designed for extension - needs to be abstract, final or empty. |
1029
|
| Method 'getRecordProgressText' is not designed for extension - needs to be abstract, final or empty. |
1046
|
| Method 'getNextResultsAvailable' is not designed for extension - needs to be abstract, final or empty. |
1067
|
| Method 'getPreviousResultsAvailable' is not designed for extension - needs to be abstract, final or empty. |
1081
|
| Method 'hasResultsAvailable' is not designed for extension - needs to be abstract, final or empty. |
1095
|
| Method 'invalidateResult' is not designed for extension - needs to be abstract, final or empty. |
1107
|
| Line has trailing spaces. |
1119
|
| Method 'getSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1137
|
| Parameter name should be final. |
1137
|
| Method 'getSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1153
|
| Parameter name should be final. |
1153
|
| Parameter defaultValue should be final. |
1153
|
| Avoid inline conditionals. |
1160
|
| Line has trailing spaces. |
1164
|
| Method 'setSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1170
|
| Parameter name should be final. |
1170
|
| Parameter value should be final. |
1170
|
| Method 'removeSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1194
|
| Parameter name should be final. |
1194
|
| Line has trailing spaces. |
1204
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
1207
|
org/apache/torque/util/LimitHelper.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Utility classes should not have a public or default constructor. |
32
|
| Unused @param tag for 'critera'. |
39
|
| Parameter criteria should be final. |
42
|
| Expected @param tag for 'criteria'. |
42
|
| Parameter query should be final. |
42
|
| Line contains a tab character. |
43
|
| Expected @throws tag for 'TorqueException'. |
43
|
| Line has trailing spaces. |
54
|
| Redundant 'final' modifier. |
90
|
| Parameter query should be final. |
90
|
| Parameter offset should be final. |
91
|
| Parameter limit should be final. |
91
|
| Line has trailing spaces. |
94
|
| Redundant 'final' modifier. |
123
|
| Parameter query should be final. |
123
|
| Parameter offset should be final. |
124
|
| Parameter limit should be final. |
124
|
| Line has trailing spaces. |
159
|
| Line has trailing spaces. |
163
|
| Redundant 'final' modifier. |
164
|
| Parameter query should be final. |
164
|
| Parameter offset should be final. |
165
|
| Parameter limit should be final. |
165
|
| Line has trailing spaces. |
209
|
| Line has trailing spaces. |
213
|
| Redundant 'final' modifier. |
214
|
| Parameter query should be final. |
214
|
| Parameter offset should be final. |
215
|
| Parameter limit should be final. |
215
|
| Line is longer than 80 characters. |
219
|
org/apache/torque/util/Query.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
38
|
| Missing a Javadoc comment. |
39
|
| Missing a Javadoc comment. |
40
|
| Missing a Javadoc comment. |
41
|
| Missing a Javadoc comment. |
42
|
| Missing a Javadoc comment. |
43
|
| Missing a Javadoc comment. |
45
|
| Name 'selectModifiers' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
| Missing a Javadoc comment. |
46
|
| Name 'selectColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
46
|
| Missing a Javadoc comment. |
47
|
| Name 'fromTables' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
47
|
| Missing a Javadoc comment. |
48
|
| Name 'whereCriteria' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
| Missing a Javadoc comment. |
49
|
| Name 'orderByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
| Missing a Javadoc comment. |
50
|
| Name 'groupByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
50
|
| Missing a Javadoc comment. |
51
|
| Name 'having' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
51
|
| Missing a Javadoc comment. |
52
|
| Name 'limit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
52
|
| Missing a Javadoc comment. |
53
|
| Name 'preLimit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
53
|
| Missing a Javadoc comment. |
54
|
| Name 'postLimit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
54
|
| Missing a Javadoc comment. |
55
|
| Name 'rowcount' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
55
|
| Method 'getSelectModifiers' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Method 'setSelectModifiers' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Parameter modifiers should be final. |
73
|
| Method 'getSelectClause' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Method 'setSelectClause' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Parameter columns should be final. |
95
|
| Method 'getFromClause' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Method 'setFromClause' is not designed for extension - needs to be abstract, final or empty. |
116
|
| Parameter tables should be final. |
116
|
| Method 'getWhereClause' is not designed for extension - needs to be abstract, final or empty. |
128
|
| Method 'setWhereClause' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Parameter where should be final. |
138
|
| Method 'getOrderByClause' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Method 'getGroupByClause' is not designed for extension - needs to be abstract, final or empty. |
160
|
| Method 'setHaving' is not designed for extension - needs to be abstract, final or empty. |
171
|
| Parameter having should be final. |
171
|
| 'having' hides a field. |
171
|
| Method 'setLimit' is not designed for extension - needs to be abstract, final or empty. |
182
|
| Parameter limit should be final. |
182
|
| 'limit' hides a field. |
182
|
| Unused Javadoc tag. |
191
|
| Method 'setPreLimit' is not designed for extension - needs to be abstract, final or empty. |
193
|
| Parameter preLimit should be final. |
193
|
| 'preLimit' hides a field. |
193
|
| Expected @param tag for 'preLimit'. |
193
|
| Unused Javadoc tag. |
202
|
| Method 'setPostLimit' is not designed for extension - needs to be abstract, final or empty. |
204
|
| Parameter postLimit should be final. |
204
|
| 'postLimit' hides a field. |
204
|
| Expected @param tag for 'postLimit'. |
204
|
| Method 'setRowcount' is not designed for extension - needs to be abstract, final or empty. |
215
|
| Parameter rowcount should be final. |
215
|
| 'rowcount' hides a field. |
215
|
| Method 'getHaving' is not designed for extension - needs to be abstract, final or empty. |
226
|
| Method 'getLimit' is not designed for extension - needs to be abstract, final or empty. |
237
|
| Method 'getPostLimit' is not designed for extension - needs to be abstract, final or empty. |
248
|
| Method 'getPreLimit' is not designed for extension - needs to be abstract, final or empty. |
259
|
| Method 'hasLimit' is not designed for extension - needs to be abstract, final or empty. |
269
|
| Method 'getRowcount' is not designed for extension - needs to be abstract, final or empty. |
282
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
292
|
| Method 'toStringBuffer' is not designed for extension - needs to be abstract, final or empty. |
297
|
| Missing a Javadoc comment. |
297
|
| Parameter stmt should be final. |
297
|
| Line has trailing spaces. |
349
|
org/apache/torque/util/SqlEnum.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Class SqlEnum should be declared as final. |
29
|
| Missing a Javadoc comment. |
31
|
| Name 's' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
31
|
| Line has trailing spaces. |
32
|
| Line has trailing spaces. |
33
|
| Missing a Javadoc comment. |
33
|
| Parameter s should be final. |
33
|
| 's' hides a field. |
33
|
| Line has trailing spaces. |
34
|
| Line has trailing spaces. |
38
|
| Missing a Javadoc comment. |
38
|
| Line has trailing spaces. |
39
|
| Line has trailing spaces. |
42
|
| Line has trailing spaces. |
43
|
| Missing a Javadoc comment. |
43
|
| Line has trailing spaces. |
45
|
| Missing a Javadoc comment. |
45
|
| Line has trailing spaces. |
47
|
| Missing a Javadoc comment. |
47
|
| Missing a Javadoc comment. |
49
|
| Missing a Javadoc comment. |
51
|
| Missing a Javadoc comment. |
53
|
| Missing a Javadoc comment. |
55
|
| Line has trailing spaces. |
56
|
| Missing a Javadoc comment. |
57
|
| Missing a Javadoc comment. |
59
|
| Missing a Javadoc comment. |
61
|
| Missing a Javadoc comment. |
63
|
| Missing a Javadoc comment. |
65
|
| Missing a Javadoc comment. |
67
|
| Missing a Javadoc comment. |
69
|
| Missing a Javadoc comment. |
71
|
| Missing a Javadoc comment. |
73
|
| Missing a Javadoc comment. |
75
|
| Missing a Javadoc comment. |
77
|
| Missing a Javadoc comment. |
79
|
| Missing a Javadoc comment. |
81
|
| Missing a Javadoc comment. |
83
|
| Missing a Javadoc comment. |
85
|
| Missing a Javadoc comment. |
87
|
org/apache/torque/util/SqlExpression.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Utility classes should not have a public or default constructor. |
50
|
| Parameter column should be final. |
65
|
| Parameter relatedColumn should be final. |
65
|
| Parameter column should be final. |
83
|
| Parameter relatedColumn should be final. |
84
|
| Parameter ignoreCase should be final. |
85
|
| Parameter db should be final. |
86
|
| Avoid inline conditionals. |
88
|
| '25' is a magic number. |
88
|
| Parameter column should be final. |
107
|
| Parameter relatedColumn should be final. |
108
|
| Parameter ignoreCase should be final. |
109
|
| Parameter db should be final. |
110
|
| Parameter whereClause should be final. |
111
|
| Parameter columnName should be final. |
140
|
| Parameter criteria should be final. |
141
|
| Parameter comparison should be final. |
142
|
| Parameter columnName should be final. |
165
|
| Parameter criteria should be final. |
166
|
| Parameter comparison should be final. |
167
|
| Parameter ignoreCase should be final. |
168
|
| Parameter db should be final. |
169
|
| Avoid inline conditionals. |
172
|
| '40' is a magic number. |
172
|
| '20' is a magic number. |
172
|
| Parameter columnName should be final. |
192
|
| Parameter criteria should be final. |
193
|
| Parameter comparison should be final. |
194
|
| Parameter ignoreCase should be final. |
195
|
| Parameter db should be final. |
196
|
| Parameter whereClause should be final. |
197
|
| Parameter columnName should be final. |
318
|
| Parameter criteria should be final. |
319
|
| Parameter comparison should be final. |
320
|
| Parameter ignoreCase should be final. |
321
|
| Parameter db should be final. |
322
|
| Parameter columnName should be final. |
351
|
| Parameter criteria should be final. |
352
|
| Parameter comparison should be final. |
353
|
| Parameter ignoreCase should be final. |
354
|
| Parameter db should be final. |
355
|
| Parameter whereClause should be final. |
356
|
| Line has trailing spaces. |
358
|
| Line has trailing spaces. |
366
|
| Line has trailing spaces. |
370
|
| switch without "default" clause. |
395
|
| switch without "default" clause. |
399
|
| Parameter columnName should be final. |
453
|
| Parameter criteria should be final. |
454
|
| Parameter comparison should be final. |
455
|
| Parameter ignoreCase should be final. |
456
|
| Parameter db should be final. |
457
|
| Parameter columnName should be final. |
480
|
| Parameter criteria should be final. |
481
|
| Parameter comparison should be final. |
482
|
| Parameter ignoreCase should be final. |
483
|
| Parameter db should be final. |
484
|
| Parameter whereClause should be final. |
485
|
| Parameter value should be final. |
539
|
| Parameter ignoreCase should be final. |
540
|
| Parameter db should be final. |
541
|
| Parameter rawText should be final. |
568
|
| Parameter db should be final. |
568
|
| '1.1' is a magic number. |
570
|
org/apache/torque/util/Transaction.java
Error | Line |
| Line does not match expected header line of ' Apache License'. |
2
|
| Line has trailing spaces. |
34
|
| Line has trailing spaces. |
35
|
| Utility classes should not have a public or default constructor. |
44
|
| Parameter dbName should be final. |
60
|
| Parameter dbName should be final. |
76
|
| Parameter useTransaction should be final. |
77
|
| Parameter con should be final. |
104
|
| Expression can be simplified. |
117
|
| Parameter con should be final. |
143
|
| Expression can be simplified. |
157
|
| Line has trailing spaces. |
181
|
| Line has trailing spaces. |
185
|
| Parameter con should be final. |
185
|
| Line has trailing spaces. |
187
|
| Line has trailing spaces. |
191
|
| Line has trailing spaces. |
201
|
org/apache/torque/util/UniqueList.java
Error | Line |
| Missing a header - not enough lines in file. |
1
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
35
|
| Parameter o should be final. |
35
|