Tag List Report
The following document contains the listing of user tags found in the code. Below is the summary of the occurences per tag.
Tag | Total number of occurences |
---|
@todo | 0 |
TODO | 14 |
Each tag is detailed below:
Number of occurences found in the code: 0
Number of occurences found in the code: 14
org.apache.myfaces.orchestra.conversation.ConversationManager | Line |
---|
fix serialization issues. | 45 |
consider whether a static value is the best way to generate context ids; they only need to be unique within a user session. Statics are also test-unfriendly. | 56 |
do not call new directly here, as it makes it impossible to configure an alternative ConversationManager instance. This is IOC and test unfriendly. | 93 |
org.apache.myfaces.orchestra.conversation.ConversationRequestParameterProvider | Line |
---|
consider using a request-scope variable rather than a ThreadLocal; less damage if the flag is not reset.. | 57 |
org.apache.myfaces.orchestra.conversation.FlashScopeManager | Line |
---|
Make this error message less spring-specific. Spring is not the only IOC container that Orchestra can be used with. | 52 |
org.apache.myfaces.orchestra.conversation.jsf.components.UISeparateConversationContext | Line |
---|
actually save the original value? | 74 |
org.apache.myfaces.orchestra.conversation.spring.AbstractSpringOrchestraScope | Line |
---|
is there a better way to do this? | 256 |
org.apache.myfaces.orchestra.conversation.spring.JpaPersistenceContextFactory | Line |
---|
what happens when a bean invokes a method on itself? Does bind get called again? If so, then this implementation is inefficient as it will push itself onto the stack over and over again. This could be optimised by checking whether this is the current context, and if so just incrementing a counter rather than pushing onto a stack... | 69 |
org.apache.myfaces.orchestra.frameworkAdapter.basic.BasicFrameworkAdapter | Line |
---|
also look in the application scope. <p> | 261 |
investigate invoking the jsp.ExpressionFactory class to look up the variable. Possibly that could be done in a different JspFrameworkAdapter class. | 263 |
look up application-scoped objects. | 277 |
org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterProviderManager | Line |
---|
investigate why this is transient. At least some callers of register call it only once per session, so if the session data is passed to another machine or is saved then restored then it seems the registered providers will be lost when they should not be... | 56 |
remove this factory code. Not IOC-friendly. | 73 |
org.apache.myfaces.orchestra.urlParamNav.UrlParameterNavigationHandler | Line |
---|
this only supports one EL expression at the moment; it would be nice to support multiple. | 69 |