PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
2690

Files

FilesViolations
org/apache/portals/bridges/struts/PortletRequestProcessor.java 2
org/apache/portals/bridges/struts/PortletServlet.java 10
org/apache/portals/bridges/struts/PortletServletConfigImpl.java 1
org/apache/portals/bridges/struts/PortletServletContextImpl.java 4
org/apache/portals/bridges/struts/PortletServletRequestDispatcher.java 3
org/apache/portals/bridges/struts/PortletServletRequestWrapper.java 6
org/apache/portals/bridges/struts/PortletServletResponseWrapper.java 5
org/apache/portals/bridges/struts/PortletTilesRequestProcessor.java 2
org/apache/portals/bridges/struts/StrutsPortlet.java 28
org/apache/portals/bridges/struts/StrutsPortletURL.java 6
org/apache/portals/bridges/struts/config/AbstractConfigComponent.java 1
org/apache/portals/bridges/struts/config/PortletURLTypes.java 2
org/apache/portals/bridges/struts/config/RenderContextAttributes.java 2
org/apache/portals/bridges/struts/config/StrutsPortletConfig.java 1
org/apache/portals/bridges/struts/taglib/ELFormTag.java 1
org/apache/portals/bridges/struts/taglib/ELImageTag.java 1
org/apache/portals/bridges/struts/taglib/ELImgTag.java 1
org/apache/portals/bridges/struts/taglib/ELLinkTag.java 1
org/apache/portals/bridges/struts/taglib/ELRewriteTag.java 1
org/apache/portals/bridges/struts/taglib/FormTag.java 1
org/apache/portals/bridges/struts/taglib/ImageTag.java 1
org/apache/portals/bridges/struts/taglib/ImgTag.java 1
org/apache/portals/bridges/struts/taglib/LinkTag.java 1
org/apache/portals/bridges/struts/taglib/RewriteTag.java 1
org/apache/portals/bridges/struts/taglib/ScriptTag.java 3
org/apache/portals/bridges/struts/taglib/TagsSupport.java 4

org/apache/portals/bridges/struts/PortletRequestProcessor.java

ViolationLine
Avoid reassigning parameters such as 'response' 40
Avoid using 'if...else' statements without curly braces 63

org/apache/portals/bridges/struts/PortletServlet.java

ViolationLine
The class 'PortletServlet' has a Cyclomatic Complexity of 4 (Highest = 12). 44
The method 'performActionRenderRequest' has a Cyclomatic Complexity of 12. 124
Avoid if (x != y) ..; else ..; 141
Deeply nested if..then statements are hard to read 142
Deeply nested if..then statements are hard to read 150
Avoid using if statements without curly braces 156
Avoid using if statements without curly braces 158
Avoid using if statements without curly braces 161
Avoid using 'if...else' statements without curly braces 168
Avoid using 'if...else' statements without curly braces 171

org/apache/portals/bridges/struts/PortletServletConfigImpl.java

ViolationLine
Avoid using if statements without curly braces 48

org/apache/portals/bridges/struts/PortletServletContextImpl.java

ViolationLine
Avoid using 'if...else' statements without curly braces 55
Avoid using 'if...else' statements without curly braces 57
Avoid using if statements without curly braces 82
Avoid using if statements without curly braces 94

org/apache/portals/bridges/struts/PortletServletRequestDispatcher.java

ViolationLine
Avoid unused formal parameters such as 'include' 54
Avoid using if statements without curly braces 85
Deeply nested if..then statements are hard to read 85

org/apache/portals/bridges/struts/PortletServletRequestWrapper.java

ViolationLine
Avoid unused private fields such as 'log' 35
Avoid if (x != y) ..; else ..; 87
Avoid using 'if...else' statements without curly braces 93
Avoid if (x != y) ..; else ..; 102
Avoid using 'if...else' statements without curly braces 103
Avoid using 'if...else' statements without curly braces 105

org/apache/portals/bridges/struts/PortletServletResponseWrapper.java

ViolationLine
Avoid unused private fields such as 'log' 35
Avoid using 'if...else' statements without curly braces 50
Avoid using 'if...else' statements without curly braces 52
Avoid using 'if...else' statements without curly braces 61
Avoid using 'if...else' statements without curly braces 63

org/apache/portals/bridges/struts/PortletTilesRequestProcessor.java

ViolationLine
Avoid reassigning parameters such as 'response' 40
Avoid using 'if...else' statements without curly braces 63

org/apache/portals/bridges/struts/StrutsPortlet.java

ViolationLine
The class 'StrutsPortlet' has a Cyclomatic Complexity of 3 (Highest = 32). 51
The method 'init' has a Cyclomatic Complexity of 13. 126
Avoid using if statements without curly braces 130
Avoid using 'if...else' statements without curly braces 147
Avoid using if statements without curly braces 151
Avoid using if statements without curly braces 157
Avoid using if statements without curly braces 179
Avoid using if statements without curly braces 181
Avoid using if statements without curly braces 183
Avoid using if statements without curly braces 185
Avoid really long methods. 308
The method 'processRequest' has a Cyclomatic Complexity of 32. 308
Avoid using 'if...else' statements without curly braces 356
Avoid using if statements without curly braces 372
Avoid using if statements without curly braces 428
Avoid using if statements without curly braces 433
Avoid if (x != y) ..; else ..; 439
Avoid using if statements without curly braces 446
Avoid empty catch blocks 457
Avoid if (x != y) ..; else ..; 461
Avoid using if statements without curly braces 464
Avoid using if statements without curly braces 492
Avoid using if statements without curly braces 499
Avoid using if statements without curly braces 510
Avoid using if statements without curly braces 521
Avoid using if statements without curly braces 524
Avoid using if statements without curly braces 530
Avoid using 'for' statements without curly braces 540

org/apache/portals/bridges/struts/StrutsPortletURL.java

ViolationLine
Avoid reassigning parameters such as 'pageURL' 45
Avoid using 'if...else' statements without curly braces 51
Avoid using 'if...else' statements without curly braces 53
Avoid using if statements without curly braces 58
Avoid using if statements without curly braces 65
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. 85

org/apache/portals/bridges/struts/config/AbstractConfigComponent.java

ViolationLine
Avoid using if statements without curly braces 32

org/apache/portals/bridges/struts/config/PortletURLTypes.java

ViolationLine
Ensure you override both equals() and hashCode() 54
Avoid if (x != y) ..; else ..; 56

org/apache/portals/bridges/struts/config/RenderContextAttributes.java

ViolationLine
The class 'RenderContextAttributes' has a Cyclomatic Complexity of 3 (Highest = 13). 14
The method 'saveAttributes' has a Cyclomatic Complexity of 13. 178

org/apache/portals/bridges/struts/config/StrutsPortletConfig.java

ViolationLine
Avoid empty catch blocks 48

org/apache/portals/bridges/struts/taglib/ELFormTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ELImageTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ELImgTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ELLinkTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ELRewriteTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/FormTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ImageTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ImgTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/LinkTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/RewriteTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ScriptTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 76
Avoid using 'if...else' statements without curly braces 77
Avoid using 'if...else' statements without curly braces 79

org/apache/portals/bridges/struts/taglib/TagsSupport.java

ViolationLine
Avoid reassigning parameters such as 'url' 50
Avoid reassigning parameters such as 'type' 107
Avoid reassigning parameters such as 'url' 107
Avoid reassigning parameters such as 'formStartElement' 146