Received: (qmail 5898 invoked from network); 19 Oct 1997 23:51:42 -0000
Message-Id: <Pine.HPP.3.95.971019164230.3641S-100000@crush.ugcs.caltech.edu>
Date: Sun, 19 Oct 1997 16:51:14 -0700 (PDT)
From: Brian Tiemann <btman@ugcs.caltech.edu>
To: apbugs@hyperreal.org
Subject: Re: Request/patch for SuppressColumnSorting in mod_autoindex

>Number:         1263
>Category:       mod_autoindex
>Synopsis:       Add frame-safe anchor attribute to mod_autoindex links
>Confidential:   yes
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          suspended
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   unknown
>Arrival-Date:   Sun Oct 19 17:00:01 PDT 1997
>Closed-Date:
>Last-Modified:  Tue Aug 07 06:49:07 PDT 2001
>Originator:     btman@ugcs.caltech.edu
>Release:        1.3b2
>Organization:
>Environment:
>Description:
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open-suspended
State-Changed-By: coar
State-Changed-When: Tue Oct 21 07:55:25 PDT 1997
State-Changed-Why:
This feature will be considered for future inclusion.
Synopsis-Changed-From: Re: Request/patch for SuppressColumnSorting in mod_autoindex
Synopsis-Changed-To: Add frame-safe anchor attribute to mod_autoindex links
Synopsis-Changed-By: coar
Synopsis-Changed-When: Tue Oct 21 07:55:25 PDT 1997
Originator-Changed-From-To: -btman@ugcs.caltech.edu
Originator-Changed-By: coar
Originator-Changed-When: Tue Oct 21 07:55:25 PDT 1997
Release-Changed-From-To: -1.3b2
Release-Changed-By: coar
Release-Changed-When: Tue Oct 21 07:55:25 PDT 1997
Class-Changed-From-To: sw-bug-change-request
Class-Changed-By: coar
Class-Changed-When: Tue Oct 21 07:55:25 PDT 1997
Severity-Changed-From-To: serious-non-critical
Severity-Changed-By: coar
Severity-Changed-When: Tue Oct 21 07:55:25 PDT 1997
Responsible-Changed-From-To: gnats-admin-apache
Responsible-Changed-By: coar
Responsible-Changed-When: Tue Oct 21 07:55:25 PDT 1997
Responsible-Changed-Why:
Putting back into circulatio
Category-Changed-From-To: pending-mod_dir
Category-Changed-By: coar
Category-Changed-When: Tue Oct 21 07:55:25 PDT 1997

Category-Changed-From-To: mod_dir-mod_autoindex
Category-Changed-By: wrowe
Category-Changed-When: Tue Aug  7 06:49:07 PDT 2001

>Unformatted:
	Further enhancement to mod_autoindex...

	I've added TARGET="_self" to the emit_link function... this causes
the sorted output to open in the same window as it was called from. This
doesn't affect non-framed pages, and within frames, it means the output
will always be in the source frame, even if the HEADER.html has a <BASE
TARGET="..."> line directing other links elsewhere.

	I can't think of any reason why this would be undesirable.

	Following is the diff of that function:

***************
*** 753,759 ****
      qvalue[4] = '\0';
      reverse = ((curkey == fname) && (curdirection == D_ASCENDING));
      qvalue[3] = reverse ? D_DESCENDING : D_ASCENDING;
!     rvputs(r, "<A HREF=\"", qvalue, "\">", anchor, "</A>", NULL);
  }

  static void output_directories(struct ent **ar, int n,
--- 756,762 ----
      qvalue[4] = '\0';
      reverse = ((curkey == fname) && (curdirection == D_ASCENDING));
      qvalue[3] = reverse ? D_DESCENDING : D_ASCENDING;
!     rvputs(r, "<A TARGET=\"_self\" HREF=\"", qvalue, "\">", anchor, "</A>", NULL);
  }

  static void output_directories(struct ent **ar, int n,
***************

Brian