Received: (qmail 28229 invoked by uid 2012); 14 Jan 1998 09:39:56 -0000
Message-Id: <19980114093956.28228.qmail@hyperreal.org>
Date: 14 Jan 1998 09:39:56 -0000
From: John Van Essen <jve@gamers.org>
Reply-To: jve@gamers.org
To: apbugs@hyperreal.org
Subject: <PRE> emitted before preamble for non-html header file
X-Send-Pr-Version: 3.2

>Number:         1667
>Category:       mod_autoindex
>Synopsis:       <PRE> emitted before preamble for non-html header file
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          closed
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Wed Jan 14 01:40:00 PST 1998
>Last-Modified:  Tue Jan 20 10:52:40 PST 1998
>Originator:     jve@gamers.org
>Organization:
>Release:        1.3b3
>Environment:
N/A
>Description:
If the file specified by HeaderName is found as plain text (not html)
then the resulting page has a <PRE> in front of the preamble, instead
of after the preamble.
>How-To-Repeat:
The problem is obvious in the source...
>Fix:
Diff -c output for simple patch that fixes it.
It moves the <PRE> output after the preamble output.

*** mod_autoindex.c.orig        Wed Nov 12 16:37:45 1997
--- mod_autoindex.c     Wed Jan 14 04:18:14 1998
***************
*** 538,544 ****
        plaintext = 1;
        if (hrule)
            rputs("<HR>\n", r);
-       rputs("<PRE>\n", r);
      }
      else if (hrule)
        rputs("<HR>\n", r);
--- 538,543 ----
***************
*** 564,569 ****
--- 563,569 ----
      else {
        char buf[IOBUFSIZE + 1];
        int i, n, c, ch;
+       rputs("<PRE>\n", r);
        while (!feof(f)) {
            do
                n = fread(buf, sizeof(char), IOBUFSIZE, f);
%0
>Audit-Trail:
State-Changed-From-To: open-analyzed
State-Changed-By: coar
State-Changed-When: Wed Jan 14 07:47:09 PST 1998
State-Changed-Why:
Indeed it is being emitted in the wrong place!  Hmmmm..
State-Changed-From-To: analyzed-closed
State-Changed-By: coar
State-Changed-When: Tue Jan 20 10:52:40 PST 1998
State-Changed-Why:
This has been corrected in the 1.3 development stream.
The fix should appear in the next 1.3 release after 1.3b3.
Thanks for reporting this, and for using Apache!
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <apbugs@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]