Received: (qmail 11115 invoked by uid 2012); 26 May 1998 11:09:07 -0000
Message-Id: <19980526110907.11114.qmail@hyperreal.org>
Date: 26 May 1998 11:09:07 -0000
From: Bob Schulze <bob@yipp.com>
Reply-To: bob@yipp.com
To: apbugs@hyperreal.org
Subject: Few changes to http_main.c and http_main.h
X-Send-Pr-Version: 3.2

>Number:         2283
>Category:       apache-api
>Synopsis:       Few changes to http_main.c and http_main.h
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          closed
>Class:          change-request
>Submitter-Id:   apache
>Arrival-Date:   Tue May 26 04:10:00 PDT 1998
>Last-Modified:  Thu Jun  4 13:02:18 PDT 1998
>Originator:     bob@yipp.com
>Organization:
>Release:        1.3b6
>Environment:
N/A, all 1.3 OS
>Description:
For some modules (mod_log_mysql)to get running, 
we need these small changes in the files above:

diff http_main.c http_main.c_org: 
326c326
< //static pool *pconf;         /* Pool for config stuff */
---
> static pool *pconf;           /* Pool for config stuff */
835c835
< API_EXPORT(void) timeout(int sig)
---
> static void timeout(int sig)

diff http_main.h http_main.h_org:
110,112d109
< static pool *pconf;           /* Pool for config stuff */
< API_EXPORT(void) timeout(int sig);
< 
>How-To-Repeat:
Compile mod_log_mysql after fixing the api names
>Fix:
see description
>Audit-Trail:
State-Changed-From-To: open-feedback
State-Changed-By: marc
State-Changed-When: Tue May 26 09:45:16 PDT 1998
State-Changed-Why:
You will have to be more explicit about why these changes
are required.  I do not see the need to expose timeout()
offhand or why you are moving pconf to a .h file.

These changes are almost certainly not correct and are probably
caused by the module in question doing things it shouldn't
be.  The solution is more likely to fix the module.

From: Dean Gaudet <dgaudet@arctic.org>
To: marc@hyperreal.org
Cc: bob@yipp.com, apbugs@apache.org
Subject: Re: apache-api/2283: Few changes to http_main.c and http_main.h
Date: Thu, 28 May 1998 16:42:09 -0700 (PDT)

 For example, if you're exposing timeout() because you want to install a
 sigpipe/alrm handler and then restore timeout() later then you should use
 the result from signal() itself... as in:
 
     void (*old_handler)(int) = signal(SIGALRM, SIG_IGN);
 
     ...
 
     signal(SIGALRM, old_handler);
 
 And pconf is already available to modules.  It is the pool passed to the
 init() method in the module_rec.
 
 Dean
 
State-Changed-From-To: feedback-closed
State-Changed-By: dgaudet
State-Changed-When: Thu Jun  4 13:02:17 PDT 1998
State-Changed-Why:
User solved problem using my suggested code.

Dean
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <apbugs@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]