Received: (qmail 8385 invoked by uid 2012); 28 May 1998 21:43:20 -0000
Message-Id: <19980528214320.8384.qmail@hyperreal.org>
Date: 28 May 1998 21:43:20 -0000
From: Dave Dykstra <dwd@bell-labs.com>
Reply-To: dwd@bell-labs.com
To: apbugs@hyperreal.org
Subject: CGI output buffered on systems without O_NONBLOCK; F_NDELAY should be O_NDELAY
X-Send-Pr-Version: 3.2

>Number:         2313
>Category:       mod_cgi
>Synopsis:       CGI output buffered on systems without O_NONBLOCK; F_NDELAY should be O_NDELAY
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    apache
>State:          closed
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Thu May 28 14:50:00 PDT 1998
>Last-Modified:  Thu Jun  4 12:59:49 PDT 1998
>Originator:     dwd@bell-labs.com
>Organization:
>Release:        1.3b7
>Environment:
At least Amdahl's UTS 2.1.2
>Description:
The F_NDELAY in main/buff.c should be O_NDELAY.  This is an alternative to
turning off buffering to O_NONBLOCK.  I checked 7 different OS's and I only
saw O_NDELAY and not an F_NDELAY so I think it was just a typo.
	OS/release		   has O_NONBLOCK  has O_NDELAY
	========================== ==============  ============
	Linux slackware 2.0.32		yes		yes
	HPUX 9.04			yes		yes
	IRIX 5.3			yes		yes 
	NCR MP-RAS 4.0 3.0		yes		yes
	Solaris	5.4			yes		yes
	Sunos 4.1.2			yes		yes
	UTS 2.1.2			no		yes

It turns out that there are a lot of other problems on UTS 2.1.2, many of
which I have already solved.  I will submit them under a separate problem
report.  In the meantime, I figured this one was independent and easy to fix.
>How-To-Repeat:

>Fix:
Change the two instances of F_NDELAY to O_NDELAY in src/main/buff.c.
Alternatively, if someone thinks some system has F_NDELAY but not O_NDELAY,
add a third #ifdef option. 
>Audit-Trail:
State-Changed-From-To: open-closed
State-Changed-By: dgaudet
State-Changed-When: Thu Jun  4 12:59:48 PDT 1998
State-Changed-Why:
Actually it was supposed to be FNDELAY without the underscore...
I put in the three of them -- O_NONBLOCK first, O_NDELAY second,
FNDELAY third.  (patch in 1.3.1-dev)

Thanks
Dean
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <apbugs@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]