Received: (qmail 15473 invoked by uid 2012); 3 Oct 1998 18:51:57 -0000
Message-Id: <19981003185157.15472.qmail@hyperreal.org>
Date: 3 Oct 1998 18:51:57 -0000
From: Martin Plechsmid <plechsmi@karlin.mff.cuni.cz>
Reply-To: plechsmi@karlin.mff.cuni.cz
To: apbugs@hyperreal.org
Subject: Directories have size shown as "0k" instead of "-" in Fancy Indexing
X-Send-Pr-Version: 3.2

>Number:         3130
>Category:       mod_autoindex
>Synopsis:       Directories have size shown as "0k" instead of "-" in Fancy Indexing
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          closed
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Sat Oct  3 12:00:00 PDT 1998
>Last-Modified:  Sat Oct  3 23:15:27 PDT 1998
>Originator:     plechsmi@karlin.mff.cuni.cz
>Organization:
>Release:        1.3.2
>Environment:
-
>Description:
Fancy Indexing shows size of directories as "0k" instead of "-".
In Apache 1.2.6 it was OK.
Probably only a mistake (if not intended) in Apache 1.3.x (even 1.3.3-dev).
>How-To-Repeat:
See e.g.
	http://www.apache.org/dist/
>Fix:
The following patch for Apache 1.3.1 should solve it:

@@ -762,7 +762,7 @@
                if (!(p->alt = find_alt(d, rr, 1))) {
                    p->alt = "DIR";
                }
-               p->size = 0;
+               p->size = -1;
                p->name = ap_pstrcat(r->pool, name, "/", NULL);
            }
            else {
>Audit-Trail:
State-Changed-From-To: open-closed
State-Changed-By: marc
State-Changed-When: Sat Oct  3 23:15:27 PDT 1998
State-Changed-Why:
Fixed, thanks for the report.

Note that the reason this was changed was as a bogus fix to avoid storing
-1 in a size_t; the correct fix also involves changing the
size_t that it is stored in into an off_t.
Class-Changed-From-To: mistaken-sw-bug
Class-Changed-By: marc
Class-Changed-When: Sat Oct  3 23:15:27 PDT 1998
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <apbugs@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]
[If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request ]
[from a developer.                                      ]
[Reply only with text; DO NOT SEND ATTACHMENTS!         ]