Received: (qmail 28101 invoked by uid 2012); 6 Jan 1999 13:57:35 -0000
Message-Id: <19990106135735.28100.qmail@hyperreal.org>
Date: 6 Jan 1999 13:57:35 -0000
From: Peter N.Wiley-Cordone <pcordone@ieee.org>
Reply-To: pcordone@ieee.org
To: apbugs@hyperreal.org
Subject: ISAPI function call return status code check for mod_isapi
X-Send-Pr-Version: 3.2

>Number:         3629
>Category:       mod_isapi
>Synopsis:       ISAPI function call return status code check for mod_isapi
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Wed Jan  6 07:10:00 PST 1999
>Closed-Date:    Tue Sep 12 19:48:47 PDT 2000
>Last-Modified:  Tue Sep 12 19:48:47 PDT 2000
>Originator:     pcordone@ieee.org
>Release:        1.3.3
>Organization:
>Environment:
I am running Windows NT first build no patches applied.  I am making ISAPI
code with Delphi version 3.0 with all the latest patches applied.
>Description:
The return status code checks in mod_isapi for the ISAPI dll calls look like:

 if ((*isapi_version)(pVer) != TRUE) {

When I try to run my isapi server extensions I get error 500 page back.  Apparently
Delphi (and I would assume other languages) don't always define TRUE to be !FALSE
where FALSE is 0 (this is how the Apache code defines it if FALSE is not already
defined).
>How-To-Repeat:
Make a ISAPI project with Delphi and try to run the server extensions.
>Fix:
Change the code to read:

 if ((*isapi_version)(pVer) == FALSE) {

or

 if (!(*isapi_version)(pVer)) {

isn't this a safer way to check the results of a boolean expression instead of
checking that it is equall to TRUE?

>Release-Note:
>Audit-Trail:
Category-Changed-From-To: other-mod_isapi
Category-Changed-By: wrowe
Category-Changed-When: Thu Jun 15 13:27:38 PDT 2000

State-Changed-From-To: open-closed
State-Changed-By: wrowe
State-Changed-When: Tue Sep 12 19:48:47 PDT 2000
State-Changed-Why:

This seems to have been resolved some time ago.

Thank you for your report and interest in the apache
httpd project.

>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <apbugs@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]
[If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request ]
[from a developer.                                      ]
[Reply only with text; DO NOT SEND ATTACHMENTS!         ]