Received: (qmail 12301 invoked by uid 2012); 20 Jan 1999 08:43:21 -0000
Message-Id: <19990120084321.12300.qmail@hyperreal.org>
Date: 20 Jan 1999 08:43:21 -0000
From: Thomas Anders <anders@hmi.de>
Reply-To: anders@hmi.de
To: apbugs@hyperreal.org
Subject: mod_autoindex applies file icons to directories
X-Send-Pr-Version: 3.2

>Number:         3721
>Category:       mod_autoindex
>Synopsis:       mod_autoindex applies file icons to directories
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Wed Jan 20 00:50:01 PST 1999
>Closed-Date:    Tue Aug 07 07:17:13 PDT 2001
>Last-Modified:  Tue Aug 07 07:17:13 PDT 2001
>Originator:     anders@hmi.de
>Release:        1.3.4
>Organization:
>Environment:
OS: Solaris 2.6 with latest patches
Hardware: Sun Ultra-1/140
Compiler: cc: SC4.0 18 Oct 1995 C 4.0
>Description:
If a *directory* name (e.g. `foo.bin') has a "common file suffix" (here: `.bin'),
mod_autoindex shows the *file* icon (here: `binary.gif') instead of the
directory icon (here: `folder.gif') given that you used

	IndexOptions FancyIndexing
	AddIcon /icons/binary.gif .bin .exe
	AddIcon /icons/folder.gif ^^DIRECTORY^^

in your httpd.conf. 

IMHO mod_autoindex should apply those icons to regular files only, not to 
directories. For directories it should always use `folder.gif'.
>How-To-Repeat:
- make sure you have Apache 1.3.4 with mod_autoindex compiled in
- Create a directory `foo.bin' inside directory `bar'
- Make sure that the following appears in your httpd.conf:
	IndexOptions FancyIndexing
	AddIcon /icons/binary.gif .bin .exe
	AddIcon /icons/folder.gif ^^DIRECTORY^^
- let apache show a directory listing of `bar'
- look at the icon before `foo.bin' -- it's `binary.gif' instead of
  `folder.gif' :(
>Fix:
mod_autoindex should always show `folder.gif' (or whatever is declared for
^^DIRECTORY^^) for *directories*. Other icons declared for certain suffixes
should be applied to *regular files* only.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open-closed
State-Changed-By: wrowe
State-Changed-When: Tue Aug  7 07:17:13 PDT 2001
State-Changed-Why:

This is a very well put argument to always use AddIconByType
or AddIconByEncoding, since directories aren't subjected to
these categories.

>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <apbugs@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]
[If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request ]
[from a developer.                                      ]
[Reply only with text; DO NOT SEND ATTACHMENTS!         ]