Received: (qmail 2849 invoked by uid 2012); 28 Sep 1999 16:19:05 -0000
Message-Id: <19990928161905.2848.qmail@hyperreal.org>
Date: 28 Sep 1999 16:19:05 -0000
From: Martin Zeh <martin.zeh@sat1.de>
Reply-To: martin.zeh@sat1.de
To: apbugs@hyperreal.org
Subject: mod_rewrite drop the QUERY_STRING using the [P] flag on per-dir context
X-Send-Pr-Version: 3.2

>Number:         5073
>Category:       mod_rewrite
>Synopsis:       mod_rewrite drop the QUERY_STRING using the [P] flag on per-dir context
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    apache
>State:          closed
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue Sep 28 09:20:00 PDT 1999
>Last-Modified:  Wed Oct 27 02:20:24 PDT 1999
>Originator:     martin.zeh@sat1.de
>Organization:
>Release:        1.3.9
>Environment:
SunOS obelix 5.5.1 Generic_103640-27 sun4m sparc SUNW,SPARCstation-20
egcs-2.9.5
>Description:
The mod_rewrite in the apache 1.3.9 strip off the QUERY_STRING if
the force proxy flag is used in the per-directory context.
I think the same bug is reported earlier but the author forgot
the per-directory context. If [P] is used in global context all
is fine.
>How-To-Repeat:
This configuration doesn't work with 1.3.9.
With apache 1.3.6 it worked well!

<Location /hack>
   RewriteEngine On
   RewriteRule ^.*/htdocs/hack(.*)$ http://hugo.sat1.de:88/hack$1 [P,L]
</Location>
>Fix:
I comment the line 1377 in mod_rewrite.c but I didn't check the side
effects! After this change the QUERY_STRING is appended

1376: if (r->args != NULL) {
1377:    /* Martin Zeh changed 28.09.1999 && r->uri == r->unparsed_uri) { */
1378:    /* see proxy_http:proxy_http_canon() */
1379:    r->filename = ap_pstrcat(r->pool, r->filename,
1380:    "?", r->args, NULL);
1381: }
>Audit-Trail:
State-Changed-From-To: open-closed
State-Changed-By: rse
State-Changed-When: Wed Oct 27 02:20:23 PDT 1999
State-Changed-Why:
Patch taken over for Apache 1.3.10.
Thanks for your feedback.
>Unformatted:
[In order for any reply to be added to the PR database, you need]
[to include <apbugs@Apache.Org> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or      ]
["Re: general/1098:").  If the subject doesn't match this       ]
[pattern, your message will be misfiled and ignored.  The       ]
["apbugs" address is not added to the Cc line of messages from  ]
[the database automatically because of the potential for mail   ]
[loops.  If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request from a  ]
[developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]