Received: (qmail 3837 invoked by uid 2012); 26 Oct 1999 18:12:41 -0000 Message-Id: <19991026181241.3835.qmail@hyperreal.org> Date: 26 Oct 1999 18:12:41 -0000 From: Chris Bongaarts Reply-To: cab@tc.umn.edu To: apbugs@hyperreal.org Subject: Add port to vhost in status table X-Send-Pr-Version: 3.2 >Number: 5199 >Category: mod_status >Synopsis: Add port to vhost in status table >Confidential: no >Severity: non-critical >Priority: medium >Responsible: apache >State: open >Class: change-request >Submitter-Id: apache >Arrival-Date: Tue Oct 26 11:20:00 PDT 1999 >Last-Modified: Tue Oct 26 11:40:02 PDT 1999 >Originator: cab@tc.umn.edu >Organization: apache >Release: 1.3.9 >Environment: N/A >Description: The virtual host field in the status results shows just the hostname. For those of us who run multiple servers with the same hostname but different ports, it would be useful to be able to distinguish by both host and port; i.e. "www.umn.edu:80" instead of just "www.umn.edu:443". >How-To-Repeat: N/A >Fix: The fix is trivial. I have a patch, but it's for a mod_ssl-patched distribution. If the developers think this would be a worthwhile modification, I'd be happy to compose a patch for the straight up 1.3.9 distribution version of mod_status.c. Also, should it be protected by #ifdef's to allow users to include or not include the ports as they see fit? I have not looked closely at the configuration process from a developer's point of view, so I don't know how easy it is to add that sort of thing. >Audit-Trail: From: Chris Bongaarts To: apbugs@hyperreal.org, apache-bugdb@apache.org Cc: Subject: Re: mod_status/5199: Add port to vhost in status table Date: Tue, 26 Oct 1999 13:39:23 -0500 (CDT) Attached (textually) is a simple patch to add ports to vhosts in mod_status for Apache 1.3.9. %% Christopher A. Bongaarts %% cab@tc.umn.edu %% ADCS - Internet Enterprise %% http://umn.edu/~cab %% University of Minnesota %% +1 (612) 625-1809 ----snip---- *** mod_status.c.orig Sat Jun 5 10:48:12 1999 --- mod_status.c Tue Oct 26 13:34:13 1999 *************** *** 596,605 **** ap_rputs("|", r); format_byte_out(r, bytes); ap_rputs(")\n", r); ! ap_rprintf(r, " %s {%s} [%s]
\n\n", score_record.client, ap_escape_html(r->pool, score_record.request), ! vhost ? vhost->server_hostname : "(unavailable)"); } else { /* !no_table_report */ if (score_record.status == SERVER_DEAD) --- 596,606 ---- ap_rputs("|", r); format_byte_out(r, bytes); ap_rputs(")\n", r); ! ap_rprintf(r, " %s {%s} [%s:%d]
\n\n", score_record.client, ap_escape_html(r->pool, score_record.request), ! vhost ? vhost->server_hostname : "(unavailable)", ! vhost ? vhost->port : 0); } else { /* !no_table_report */ if (score_record.status == SERVER_DEAD) *************** *** 670,678 **** "??..reading.. \n\n"); else ap_rprintf(r, ! "%s%s%s\n\n", score_record.client, vhost ? vhost->server_hostname : "(unavailable)", ap_escape_html(r->pool, score_record.request)); } /* no_table_report */ } /* !short_report */ --- 671,680 ---- "??..reading.. \n\n"); else ap_rprintf(r, ! "%s%s:%d%s\n\n", score_record.client, vhost ? vhost->server_hostname : "(unavailable)", + vhost ? vhost->port : 0, ap_escape_html(r->pool, score_record.request)); } /* no_table_report */ } /* !short_report */ >Unformatted: [In order for any reply to be added to the PR database, you need] [to include in the Cc line and make sure the] [subject line starts with the report component and number, with ] [or without any 'Re:' prefixes (such as "general/1098:" or ] ["Re: general/1098:"). If the subject doesn't match this ] [pattern, your message will be misfiled and ignored. The ] ["apbugs" address is not added to the Cc line of messages from ] [the database automatically because of the potential for mail ] [loops. If you do not include this Cc, your reply may be ig- ] [nored unless you are responding to an explicit request from a ] [developer. Reply only with text; DO NOT SEND ATTACHMENTS! ]