Received: (qmail 22567 invoked by uid 2012); 14 Nov 1999 06:13:20 -0000
Message-Id: <19991114061320.22566.qmail@hyperreal.org>
Date: 14 Nov 1999 06:13:20 -0000
From: Paul Gilmartin <pg@sweng.stortek.com>
Reply-To: pg@sweng.stortek.com
To: apbugs@hyperreal.org
Subject: Shell metacharacters in string returned by GuessOS
X-Send-Pr-Version: 3.2

>Number:         5303
>Category:       config
>Synopsis:       Shell metacharacters in string returned by GuessOS
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Sat Nov 13 22:20:01 PST 1999
>Last-Modified:  Sun Nov 28 03:30:00 PST 1999
>Originator:     pg@sweng.stortek.com
>Organization:
apache
>Release:        1.3.9
>Environment:
uname -a
OS/390 MVS3 02.00 01 9672
>Description:
=========================================================================
===== If GuessOS returns shell metacharacters, configure incorporates these
===== in pathnames, which causes "make" to generate bad syntax in shell commands.
=========================================================================
diff -bru orig/apache_1.3.9/src/helpers/GuessOS apache_1.3.9/src/helpers/GuessOS
--- orig/apache_1.3.9/src/helpers/GuessOS       Mon Aug  9 01:38:44 1999
+++ apache_1.3.9/src/helpers/GuessOS    Sat Nov 13 20:26:53 1999
@@ -326,5 +326,5 @@
 # At this point we gone through all the one's
 # we know of: Punt

-echo "${MACHINE}-whatever-${SYSTEM}|${RELEASE}|${VERSION}"
+echo "${MACHINE}-whatever-${SYSTEM}-${RELEASE}-${VERSION}"
 exit 0
>How-To-Repeat:
Run "configure -shadow" on an unknown OS.
>Fix:
Patch above.
>Audit-Trail:

From: "Ralf S. Engelschall" <rse@engelschall.com>
To: apbugs@apache.org
Cc:  Subject: Re: config/5303: Shell metacharacters in string returned by GuessOS
Date: Sun, 28 Nov 1999 12:26:02 +0100

 In article <19991114061320.22566.qmail@hyperreal.org> you wrote:
  
 >>Number:         5303
 >>Category:       config
 >>Synopsis:       Shell metacharacters in string returned by GuessOS
 > [...]
 > ===== If GuessOS returns shell metacharacters, configure incorporates these
 > ===== in pathnames, which causes "make" to generate bad syntax in shell commands.
 > [...]
 
 > -echo "${MACHINE}-whatever-${SYSTEM}|${RELEASE}|${VERSION}"
 > +echo "${MACHINE}-whatever-${SYSTEM}-${RELEASE}-${VERSION}"
 
 Thanks for catching this. It's now fixed for Apache 1.3.10.  But not by using
 a minus instead of a pipe char. Instead I used a comma, because a minus is the
 meta-char in GuessOS's output (the output has to be a minus-separated
 _triple_).
                                        Ralf S. Engelschall
                                        rse@engelschall.com
                                        www.engelschall.com
>Unformatted:
[In order for any reply to be added to the PR database, you need]
[to include <apbugs@Apache.Org> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or      ]
["Re: general/1098:").  If the subject doesn't match this       ]
[pattern, your message will be misfiled and ignored.  The       ]
["apbugs" address is not added to the Cc line of messages from  ]
[the database automatically because of the potential for mail   ]
[loops.  If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request from a  ]
[developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]