Received: (qmail 24174 invoked by uid 2012); 14 Nov 1999 06:18:31 -0000
Message-Id: <19991114061831.24173.qmail@hyperreal.org>
Date: 14 Nov 1999 06:18:31 -0000
From: Paul Gilmartin <pg@sweng.stortek.com>
Reply-To: pg@sweng.stortek.com
To: apbugs@hyperreal.org
Subject: Improper use of "$AWK" in shadow makefile.
X-Send-Pr-Version: 3.2

>Number:         5304
>Category:       config
>Synopsis:       Improper use of "$AWK" in shadow makefile.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          closed
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Sat Nov 13 22:20:01 PST 1999
>Last-Modified:  Tue Dec 21 07:49:14 PST 1999
>Originator:     pg@sweng.stortek.com
>Organization:
>Release:        1.3.9
>Environment:
uname -a
OS/390 MVS3 02.00 01 9672
>Description:
=========================================================================
===== As the comment a few lines previously explains, we must use "awk"
===== here, not "$AWK".
=====
===== install-programs is a valuable target to expose for quick build-test
===== cycles.
=========================================================================
diff -bru orig/apache_1.3.9/configure apache_1.3.9/configure
--- orig/apache_1.3.9/configure Sat Aug 14 02:29:05 1999
+++ apache_1.3.9/configure      Sat Nov 13 22:42:30 1999
@@ -562,9 +562,9 @@
                 else
                     echo "SHADOW=." >> Makefile
                 fi
-                echo "GNUTRIPLE=\`$aux/GuessOS | sed -e 's:/:-:g' | $AWK '{ printf(\"%s\",\$\$1); }'\`" >> Makefile
+                echo "GNUTRIPLE=\`$aux/GuessOS | sed -e 's:/:-:g' | awk '{ printf(\"%s\",\$\$1); }'\`" >> Makefile
                 echo "" >> Makefile
-                echo "all build install install-quiet clean distclean:" >> Makefile
+                echo "all build install install-quiet install-programs clean distclean:" >> Makefile
                 echo " @cd \$(SHADOW); \$(MAKE) -f Makefile.\$(GNUTRIPLE) \$(MFLAGS) \$@" >> Makefile
                 echo "" >> Makefile
             fi
>How-To-Repeat:
Run "configure -shadow" on two systems with different paths to "awk",
then run "make" on each.  One will fail with "file not found: /usr/bin/nawk",
or the like.
>Fix:
Patch above.
>Audit-Trail:

From: "Ralf S. Engelschall" <rse@engelschall.com>
To: apbugs@apache.org
Cc:  Subject: Re: config/5304: Improper use of "$AWK" in shadow makefile.
Date: Sun, 28 Nov 1999 12:32:48 +0100

 In article <19991114061831.24173.qmail@hyperreal.org> you wrote:
 > 
 >>Number:         5304
 >>Category:       config
 >>Synopsis:       Improper use of "$AWK" in shadow makefile.
 >>Confidential:   no
 > [...]
 > ===== As the comment a few lines previously explains, we must use "awk"
 > ===== here, not "$AWK".
 
 Correct. Actually there is a second bug: The "awk" above the mentioned
 location in the script instead should read "$AWK".  Seems like we've replaced
 the wrong "awk" with $AWK in the past ;) Both things are now fixed for Apache
 1.3.10.
 
 > ===== install-programs is a valuable target to expose for quick build-test
 > ===== cycles.
 
 Sorry, just adding install-programs is inconsistent. Either we add _all_
 possible targets like install-programs or none.  And because there are lots of
 such targets, I think it's better to leave them out.
 
 Thanks for your feedback.
                                        Ralf S. Engelschall
                                        rse@engelschall.com
                                        www.engelschall.com
State-Changed-From-To: open-closed
State-Changed-By: jim
State-Changed-When: Tue Dec 21 07:49:13 PST 1999
State-Changed-Why:
Fixed in 1.3.10
>Unformatted:
[In order for any reply to be added to the PR database, you need]
[to include <apbugs@Apache.Org> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or      ]
["Re: general/1098:").  If the subject doesn't match this       ]
[pattern, your message will be misfiled and ignored.  The       ]
["apbugs" address is not added to the Cc line of messages from  ]
[the database automatically because of the potential for mail   ]
[loops.  If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request from a  ]
[developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]