Received: (qmail 78428 invoked by uid 65534); 25 Jan 2000 13:49:50 -0000
Message-Id: <20000125134950.78427.qmail@locus.apache.org>
Date: 25 Jan 2000 13:49:50 -0000
From: David MacKenzie <djm@web.us.uu.net>
Reply-To: djm@web.us.uu.net
To: submit@bugz.apache.org
Subject: Cleanup of type FLAG directives
X-Send-Pr-Version: 3.110

>Number:         5642
>Category:       general
>Synopsis:       Cleanup of type FLAG directives
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue Jan 25 05:50:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     djm@web.us.uu.net
>Release:        1.3.11 and earlier
>Organization:
apache
>Environment:
Any
>Description:
A few standard modules misuse, fail to use, or misdocument type FLAG directives.
>How-To-Repeat:

>Fix:
Index: modules/standard/mod_auth.c
===================================================================
RCS file: /export/src/CVS/usr.local/libexec/apache_1.3.x/src/modules/standard/mod_auth.c,v
retrieving revision 1.1.1.3
diff -u -r1.1.1.3 mod_auth.c
--- modules/standard/mod_auth.c	1999/09/08 03:46:59	1.1.1.3
+++ modules/standard/mod_auth.c	2000/01/25 11:37:55
@@ -110,7 +110,7 @@
     {"AuthAuthoritative", ap_set_flag_slot,
      (void *) XtOffsetOf(auth_config_rec, auth_authoritative),
      OR_AUTHCFG, FLAG,
-     "Set to 'no' to allow access control to be passed along to lower modules if the UserID is not known to this module"},
+     "Set to 'Off' to allow access control to be passed along to lower modules if the UserID is not known to this module"},
     {NULL}
 };
 
Index: modules/standard/mod_cern_meta.c
===================================================================
RCS file: /export/src/CVS/usr.local/libexec/apache_1.3.x/src/modules/standard/mod_cern_meta.c,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 mod_cern_meta.c
--- modules/standard/mod_cern_meta.c	1999/06/08 03:16:49	1.1.1.2
+++ modules/standard/mod_cern_meta.c	2000/01/25 11:37:57
@@ -208,7 +208,7 @@
     return NULL;
 }
 
-static const char *set_metafiles(cmd_parms *parms, cern_meta_dir_config * dconf, char *arg)
+static const char *set_metafiles(cmd_parms *parms, cern_meta_dir_config * dconf, int arg)
 {
     dconf->metafiles = arg;
     return NULL;
Index: modules/standard/mod_status.c
===================================================================
RCS file: /export/src/CVS/usr.local/libexec/apache_1.3.x/src/modules/standard/mod_status.c,v
retrieving revision 1.6
diff -u -r1.6 mod_status.c
--- modules/standard/mod_status.c	1999/09/08 05:38:46	1.6
+++ modules/standard/mod_status.c	2000/01/25 11:38:19
@@ -156,24 +156,19 @@
  *command-related code. This is here to prevent use of ExtendedStatus
  * without status_module included.
  */
-static const char *set_extended_status(cmd_parms *cmd, void *dummy, char *arg) 
+static const char *set_extended_status(cmd_parms *cmd, void *dummy, int arg) 
 {
     const char *err = ap_check_cmd_context(cmd, GLOBAL_ONLY);
     if (err != NULL) {
         return err;
     }
-    if (!strcasecmp(arg, "off") || !strcmp(arg, "0")) {
-	ap_extended_status = 0;
-    }
-    else {
-	ap_extended_status = 1;
-    }
+    ap_extended_status = arg;
     return NULL;
 }
 
 static const command_rec status_module_cmds[] =
 {
-    { "ExtendedStatus", set_extended_status, NULL, RSRC_CONF, TAKE1,
+    { "ExtendedStatus", set_extended_status, NULL, RSRC_CONF, FLAG,
       "\"On\" to enable extended status information, \"Off\" to disable" },
     {NULL}
 };
>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <apbugs@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]