Received: (qmail 80752 invoked by uid 501); 6 Feb 2001 14:46:20 -0000
Message-Id: <20010206144620.80751.qmail@apache.org>
Date: 6 Feb 2001 14:46:20 -0000
From: Jani Jaakkola <jjaakkol@cs.helsinki.fi>
Reply-To: jjaakkol@cs.helsinki.fi
To: submit@bugz.apache.org
Subject: Secret key file provided as third parameter to ApjServMount gets ignored
X-Send-Pr-Version: 3.110

>Number:         7205
>Category:       mod_jserv
>Synopsis:       Secret key file provided as third parameter to ApjServMount gets ignored
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jserv
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue Feb 06 06:50:00 PST 2001
>Closed-Date:    Tue Feb 06 13:20:52 PST 2001
>Last-Modified:  Tue Feb 06 13:20:52 PST 2001
>Originator:     jjaakkol@cs.helsinki.fi
>Release:        ApacheJserv-1.1.2
>Organization:
>Environment:
Linux-2.2.16, gcc-1.1,2, but it does not matter really.
>Description:
If you use a line like this in jserv.conf:
ApJServMount /luser ajpv12://localhost:8008/luser /home/luser/secretfile
the third paramter (/home/luser/secretfile) gets ignored.
>How-To-Repeat:
Just try to give a secret key with ApjServMount-directive. It gets ignored
and the global secret given with ApJServSecretKey gets used instead.
>Fix:
This patch against src/c/mod_jserv.c, which also saves 
the name of the secret key file (which is later checked 
by other parts of mod_jserv.so to check if secret key was 
given all):

--- /fs/svc/src/ApacheJServ-1.1.2/src/c/mod_jserv.c     Thu Jun 15 22:17:11 2000
+++ mod_jserv.c Tue Feb  6 16:44:39 2001
@@ -1056,11 +1056,14 @@
     }
 
     /* Check if our secret file field is valid */
-    if (value3!=NULL) {
+    if (value3) {
         const char *ret;
+
+       mnt->secretfile=ap_pstrdup(p,value3);
 
         /* Get the secret key file contents and length */
-        ret=jserv_readfile(cmd->pool, value3, JSERV_TRUE, &mnt->secret,
+        ret=jserv_readfile(cmd->pool, mnt->secretfile, JSERV_TRUE, 
+                          &mnt->secret,
                            &mnt->secretsize);
 
         /* If ret is not null, an error occourred and ret points t
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open-closed
State-Changed-By: jon@clearink.com
State-Changed-When: Tue Feb  6 13:20:50 PST 2001
State-Changed-Why:
Your patch has been checked into CVS. thanks!

-jon
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <apbugs@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]