Received: (qmail 76202 invoked by uid 501); 26 Mar 2001 11:34:30 -0000
Message-Id: <20010326113430.76201.qmail@apache.org>
Date: 26 Mar 2001 11:34:30 -0000
From: Patrik Hornik <patrik@netdive.com>
Reply-To: patrik@netdive.com
To: submit@bugz.apache.org
Subject: The response headers are not logged when proxy serves the document.
X-Send-Pr-Version: 3.110

>Number:         7461
>Category:       mod_proxy
>Synopsis:       Fix applied and checked
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    orlikowski
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Mon Mar 26 03:40:01 PST 2001
>Closed-Date:    Sat Jun 09 03:38:27 PDT 2001
>Last-Modified:  Sat Jun 09 03:38:27 PDT 2001
>Originator:     patrik@netdive.com
>Release:        1.3.14
>Organization:
>Environment:
Linux kernel 2.4.0
>Description:
The response headers are not logged when mod_proxy serves the document. This is because proxy writes them directly to the output and doesnt add them to the request->headers_out table. And mod_log_config parses request->headers_out for {}o log directives..
>How-To-Repeat:
Every document accessed through proxy... :))
>Fix:
Yes, add response headers to request->headers_out table in ap_proxy_send_hdr_line in proxy_util.c:
...
if (!parm->req->assbackwards)
  ap_rvputs(parm->req, key, ": ", value, CRLF, NULL);

// Here comes the fix...
ap_table_add(parm->req->headers_out,key,value);
...
>Release-Note:
>Audit-Trail:
Comment-Added-By: orlikowski
Comment-Added-When: Sat Jun  9 03:37:31 PDT 2001
Comment-Added:
Applied supplied fix, and tested it. Thanks!
Synopsis-Changed-From: The response headers are not logged when proxy serves the document.
Synopsis-Changed-To: Fix applied and checked
Synopsis-Changed-By: orlikowski
Synopsis-Changed-When: Sat Jun  9 03:37:31 PDT 2001
Responsible-Changed-From-To: apache-orlikowski
Responsible-Changed-By: orlikowski
Responsible-Changed-When: Sat Jun  9 03:37:31 PDT 2001
Responsible-Changed-Why:
Submitted fix.
State-Changed-From-To: open-closed
State-Changed-By: orlikowski
State-Changed-When: Sat Jun  9 03:38:26 PDT 2001
State-Changed-Why:
My error. Needed to mark this closed.
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <apbugs@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]