Received: (qmail 96355 invoked by uid 501); 24 Apr 2001 20:14:21 -0000
Message-Id: <20010424201421.96354.qmail@apache.org>
Date: 24 Apr 2001 20:14:21 -0000
From: Barrie Slaymaker <barries@slaysys.com>
Reply-To: barries@slaysys.com
To: submit@bugz.apache.org
Subject: '>' is left on directives with no args (eg "<Foo>")
X-Send-Pr-Version: 3.110

>Number:         7617
>Category:       config
>Synopsis:       '>' is left on directives with no args (eg "<Foo>")
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue Apr 24 13:20:00 PDT 2001
>Closed-Date:    Fri May 11 16:30:50 PDT 2001
>Last-Modified:  Fri May 11 16:30:50 PDT 2001
>Originator:     barries@slaysys.com
>Release:        2.0.18-dev
>Organization:
>Environment:
N/A
>Description:
Putting

   <Foo>
   </Foo>

in a config file yeilds:

   Syntax error on line 946 of /home/barries/2.0/www/conf/httpd.conf:
   Expected </Foo>> but saw </Foo>
>How-To-Repeat:
See above.
>Fix:
This patch changes the error report to:

   Syntax error on line 944 of /home/barries/2.0/www/conf/httpd.conf:
   Invalid command '<Foo', perhaps mis-spelled or defined by a module not included in the server configuration

--- server/config.c.orig        Tue Apr 24 15:20:20 2001
+++ server/config.c     Tue Apr 24 15:19:41 2001
@@ -809,6 +809,12 @@
        return NULL;
     }
 
+    if ( cmd_name[1] != '/' ) {
+        char *lastc = cmd_name + strlen(cmd_name) - 1;
+        if ( *lastc == '>' )
+            *lastc = '\0' ;
+    }
+
     newdir = apr_pcalloc(p, sizeof(ap_directive_t));
     newdir->filename = parms->config_file->name;
     newdir->line_num = parms->config_file->line_number;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open-closed
State-Changed-By: rbb
State-Changed-When: Fri May 11 16:30:49 PDT 2001
State-Changed-Why:
This patch has been committed to the CVS tree and will be
available in the next beta of Apache 2.0.

Thank you for using Apache.
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <apbugs@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]