Received: (qmail 4930 invoked by uid 501); 26 Apr 2001 20:12:39 -0000
Message-Id: <20010426201239.4929.qmail@apache.org>
Date: 26 Apr 2001 20:12:39 -0000
From: Fritz Zaucker <zaucker@ee.ethz.ch>
Reply-To: zaucker@ee.ethz.ch
To: submit@bugz.apache.org
Subject: suexec error message about read-only log file could be clearer
X-Send-Pr-Version: 3.110

>Number:         7638
>Category:       suexec
>Synopsis:       suexec error message about read-only log file could be clearer
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          change-request
>Submitter-Id:   apache
>Arrival-Date:   Thu Apr 26 13:20:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     zaucker@ee.ethz.ch
>Release:        1.3.19 and earlier
>Organization:
apache
>Environment:
Apache 1.3.19 and earlier version; the problem does not depend on OS, etc.
>Description:
If suexec is used with Apache and the suexec log file is erroneously placed in 
a read-only filesystem, the error message of suexec is:

	failed to open log file    	
	fopen: Read-only file system

Error diagnostic would be much improved by changing the first line of 
this error message to
	
	failed to open suexec log file
or
	suexec: failed to open log file

and perhaps adding the logfile name.
>How-To-Repeat:

>Fix:
The following trivial patch will give the desired behaviour:

--- suexec.c.dist   Wed Apr 18 00:04:05 2001
+++ suexec.c    Thu Apr 26 17:18:53 2001
@@ -177,7 +177,7 @@
 
     if (!log) {
        if ((log = fopen(LOG_EXEC, "a")) == NULL) {
-           fprintf(stderr, "suexec: failed to open log file LOG_EXEC\n");
+           fprintf(stderr, "failed to open suexec log file\n");
            perror("fopen");
            exit(1);
        }
>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <apbugs@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]