Received: (qmail 47293 invoked by uid 501); 2 May 2001 04:46:35 -0000
Message-Id: <20010502044635.47288.qmail@apache.org>
Date: 2 May 2001 04:46:35 -0000
From: Yusuf Goolamabbas <yusufg@outblaze.com>
Reply-To: yusufg@outblaze.com
To: submit@bugz.apache.org
Subject: mod_expires doesn't take negative numbers
X-Send-Pr-Version: 3.110

>Number:         7666
>Category:       mod_expires
>Synopsis:       mod_expires doesn't take negative numbers
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue May 01 21:50:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     yusufg@outblaze.com
>Release:        1.3.19
>Organization:
apache
>Environment:
Linux 2.2.19
gcc version 2.96 20000731 (Red Hat Linux 7.0)
>Description:
Hi, The description of mod_expires states
<num> should be an integer value [acceptable to atoi()]

For example, I would like to write this to provide for negative expire values
make things uncacheable

ExpiresDefault "modification plus -1 hour" 

The current Apache mod_expires doesn't allow this. It output's

bad expires code, numeric value expected <num

However, it allows 
ExpiresDefault M-3600

The following tiny patch to mod_expires seems to allow the first config to happen and do the right thing

>How-To-Repeat:
In a stock Apache 1.3.19 with mod_expires enabled, the following line in the config file will not be accepted

ExpiresDefault "modification plus -1 hour"

However this equivalent version will be
ExpiresDefault M-3600
>Fix:

288c288
<         if (('-' == word[0]) || ap_isdigit(word[0])) {
---
>         if (ap_isdigit(word[0])) {



>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <apbugs@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]