Received: (qmail 28412 invoked by uid 501); 19 Jun 2001 16:22:09 -0000
Message-Id: <20010619162209.28409.qmail@apache.org>
Date: 19 Jun 2001 16:22:09 -0000
From: Carlos Del Olmo <carlosdo@borak.es>
Reply-To: carlosdo@borak.es
To: submit@bugz.apache.org
Subject: mod_proxy don't fill the Client-ip Header
X-Send-Pr-Version: 3.110

>Number:         7885
>Category:       mod_proxy
>Synopsis:       mod_proxy don't fill the Client-ip Header
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue Jun 19 09:30:03 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     carlosdo@borak.es
>Release:        1.3.20
>Organization:
apache
>Environment:
All systems
>Description:
mod_proxy don't fill the Client-ip header in request to other
web servers

Some webservers and aplications want to know about this header
>How-To-Repeat:

>Fix:
Output from "diff proxy_http.c.old proxy_http.c.new" (1.3.20)
192a193,196
>
>     /* Var declaration carlosdo@borak.es */
>     int get_from_socket=1;
>     /* End of the new var declaration */
312a317
>
358a364,381
>     /* Patch to forward or get the client ip address carlosdo@borak.es */
>
>     reqhdrs_arr = ap_table_elts(r->headers_in);
>     reqhdrs = (table_entry *) reqhdrs_arr->elts;
>     for (i = 0; i < reqhdrs_arr->nelts; i++) {
>       if (reqhdrs[i].key == NULL || reqhdrs[i].val == NULL)
>               continue;
>            if(!strcasecmp(reqhdrs[i].key, "Client-ip"))
>              {
>               ip_del_socket=0;
>              }
>     }
>     if(get_from_socket) /* Get it from socket */
>         ap_bvputs(f, "Client-ip: ", r->connection->remote_ip, CRLF, NULL);
>
>     /* Patch end */
>
>
>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <apbugs@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]