Received: (qmail 46036 invoked by uid 501); 31 Jan 2002 21:46:35 -0000
Message-Id: <20020131214635.46035.qmail@apache.org>
Date: 31 Jan 2002 21:46:35 -0000
From: David MacKenzie <djm@pix.net>
Reply-To: djm@pix.net
To: submit@bugz.apache.org
Subject: wrong error check
X-Send-Pr-Version: 3.110

>Number:         9669
>Category:       mod_cgi
>Synopsis:       wrong error check
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Thu Jan 31 13:50:00 PST 2002
>Closed-Date:    Sun Feb 17 19:32:04 PST 2002
>Last-Modified:  Sun Feb 17 19:32:04 PST 2002
>Originator:     djm@pix.net
>Release:        2.0.28 and CVS
>Organization:
>Environment:
Unix
>Description:
Typo in error checking. After assigning to *script_in, it checks whether script_in is NULL instead of checking *script_in, as it does for *script_out and *script_err.
>How-To-Repeat:

>Fix:
--- httpd-2_0_28/modules/generators/mod_cgi.c   2002/01/31 21:38:18     1.1
+++ httpd-2_0_28/modules/generators/mod_cgi.c   2002/01/31 21:39:32
@@ -461,7 +461,7 @@
             apr_pool_note_subprocess(p, procnew, kill_after_timeout);
 
             *script_in = procnew->out;
-            if (!script_in)
+            if (!*script_in)
                 return APR_EBADF;
             apr_file_pipe_timeout_set(*script_in, (int)(r->server->timeout * APR_USEC_PER_SEC));
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open-closed
State-Changed-By: jerenkrantz
State-Changed-When: Sun Feb 17 19:32:04 PST 2002
State-Changed-Why:
Fixed in revision 1.117 of modules/generators/mod_cgi.c
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <apbugs@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]