|
The following document contains the results of
Checkstyle
.
Files | Infos | Warnings | Errors |
55 | 4 | 342 | 24 |
Error | Line |
| First sentence should end with a period. |
23
|
| 'public' modifier out of order with the JLS suggestions. |
30
|
| First sentence should end with a period. |
32
|
| Expected an @return tag. |
33
|
| 'public' modifier out of order with the JLS suggestions. |
33
|
| Unused @throws tag for 'Exception'. |
41
|
| Expected @throws tag for 'JellyTagException'. |
43
|
| '(' is followed by whitespace. |
48
|
| ')' is preceded with whitespace. |
48
|
| '(' is followed by whitespace. |
49
|
| '+' should be on a new line. |
49
|
| Line is longer than 100 characters. |
50
|
| ')' is preceded with whitespace. |
50
|
Error | Line |
| First sentence should end with a period. |
20
|
| First sentence should end with a period. |
28
|
| Expected an @return tag. |
29
|
Error | Line |
| First sentence should end with a period. |
19
|
| First sentence should end with a period. |
27
|
| Expected an @return tag. |
28
|
Error | Line |
| Wrong order for 'java.io.IOException' import. |
29
|
| First sentence should end with a period. |
33
|
| First sentence should end with a period. |
41
|
| Name '_contextPath' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
42
|
| First sentence should end with a period. |
44
|
| Name '_resourceBase' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
45
|
| First sentence should end with a period. |
47
|
| Name '_realmName' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
48
|
| First sentence should end with a period. |
50
|
| Name '_context' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
51
|
| First sentence should end with a period. |
53
|
| Unused @throws tag for 'Exception'. |
64
|
| Expected @throws tag for 'JellyTagException'. |
66
|
| '(' is followed by whitespace. |
70
|
| ')' is preceded with whitespace. |
70
|
| Line is longer than 100 characters. |
71
|
| '(' is followed by whitespace. |
71
|
| ')' is preceded with whitespace. |
71
|
| '}' should be on the same line. |
84
|
| '}' should be on the same line. |
87
|
| First sentence should end with a period. |
99
|
| Unused @param tag for 'handler'. |
102
|
| Expected @param tag for 'httHandler'. |
104
|
| First sentence should end with a period. |
108
|
| First sentence should end with a period. |
119
|
| '{' should be on the previous line. |
125
|
| Unused @param tag for 'path'. |
144
|
| Expected @param tag for 'contextPath'. |
146
|
| Unused @param tag for 'path'. |
180
|
| Expected @param tag for 'realmName'. |
182
|
Error | Line |
| First sentence should end with a period. |
23
|
| Name '_jellyResourceHttpHandler' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
33
|
| First sentence should end with a period. |
35
|
| Unused @throws tag for 'Exception'. |
44
|
| Expected @throws tag for 'JellyTagException'. |
46
|
| '(' is followed by whitespace. |
49
|
| ')' is preceded with whitespace. |
49
|
| Line is longer than 100 characters. |
50
|
| '(' is followed by whitespace. |
50
|
| ')' is preceded with whitespace. |
50
|
| Missing a Javadoc comment. |
66
|
Error | Line |
| Wrong order for 'java.io.BufferedReader' import. |
31
|
| Redundant import from the java.lang package - java.lang.StringBuffer. |
35
|
| First sentence should end with a period. |
39
|
| Field 'log' is used in only one method. |
48
|
| Field 'OVERRIDE_SET_HANDLED_VAR' is used in only one method. |
51
|
| First sentence should end with a period. |
53
|
| Name '_tagMap' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
54
|
| First sentence should end with a period. |
56
|
| Name '_xmlOutput' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
57
|
| First sentence should end with a period. |
59
|
| '(' is followed by whitespace. |
60
|
| Expected @param tag for 'xmlOutput'. |
60
|
| ')' is preceded with whitespace. |
60
|
| Missing a Javadoc comment. |
71
|
| '{' is not preceded with whitespace. |
71
|
| Missing a Javadoc comment. |
86
|
| Redundant throws: 'HttpException' is subclass of 'IOException'. |
90
|
| '{' should be on the previous line. |
91
|
| '(' is followed by whitespace. |
96
|
| '(' is followed by whitespace. |
97
|
| '(' is followed by whitespace. |
98
|
| '(' is followed by whitespace. |
99
|
| '(' is followed by whitespace. |
100
|
| ')' is preceded with whitespace. |
112
|
| Line is longer than 100 characters. |
114
|
| '+' should be on a new line. |
117
|
| '+' should be on a new line. |
118
|
| '+' should be on a new line. |
119
|
| Missing a Javadoc comment. |
126
|
| Unused local variable 'br'. |
131
|
| '1024' is a magic number. |
133
|
| 'while' construct must use '{}'s. |
136
|
| '1024' is a magic number. |
136
|
| method call child at indentation level 10 not at correct indentation, 12 |
137
|
| 'if' construct must use '{}'s. |
139
|
| if child at indentation level 10 not at correct indentation, 12 |
140
|
| 'else' construct must use '{}'s. |
141
|
| else child at indentation level 10 not at correct indentation, 12 |
142
|
Error | Line |
| First sentence should end with a period. |
39
|
| First sentence should end with a period. |
47
|
| First sentence should end with a period. |
50
|
| First sentence should end with a period. |
53
|
| First sentence should end with a period. |
56
|
| First sentence should end with a period. |
59
|
| First sentence should end with a period. |
66
|
| Name '_logSink' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
67
|
| try at indentation level 8 not at correct indentation, 4 |
72
|
| try child at indentation level 12 not at correct indentation, 8 |
73
|
| try child at indentation level 12 not at correct indentation, 8 |
75
|
| try rcurly at indentation level 8 not at correct indentation, 4 |
76
|
| ')' is preceded with whitespace. |
76
|
| catch child at indentation level 12 not at correct indentation, 8 |
77
|
| catch rcurly at indentation level 8 not at correct indentation, 4 |
78
|
| First sentence should end with a period. |
82
|
| Name '_var' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
83
|
| First sentence should end with a period. |
85
|
| Name '_server' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
86
|
| First sentence should end with a period. |
88
|
| Name '_logFileName' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
89
|
| First sentence should end with a period. |
91
|
| '=' is not preceded with whitespace. |
95
|
| '=' is not followed by whitespace. |
95
|
| Unused @throws tag for 'Exception'. |
108
|
| Cyclomatic Complexity is 13 (max allowed is 10). |
110
|
| Expected @throws tag for 'JellyTagException'. |
110
|
| ')' is preceded with whitespace. |
116
|
| '=' is not preceded with whitespace. |
126
|
| '=' is not followed by whitespace. |
126
|
| '}' should be on the same line. |
145
|
| '}' should be on the same line. |
148
|
| '+' should be on a new line. |
159
|
| '}' should be on the same line. |
169
|
| First sentence should end with a period. |
180
|
| First sentence should end with a period. |
189
|
| First sentence should end with a period. |
199
|
| '{' should be on the previous line. |
206
|
Error | Line |
| First sentence should end with a period. |
23
|
| First sentence should end with a period. |
31
|
| Javadoc has empty description section. |
54
|
Error | Line |
| First sentence should end with a period. |
24
|
| First sentence should end with a period. |
32
|
| Unused @throws tag for 'Exception'. |
41
|
| Expected @throws tag for 'JellyTagException'. |
43
|
| '(' is followed by whitespace. |
46
|
| ')' is preceded with whitespace. |
46
|
| Line is longer than 100 characters. |
47
|
| '(' is followed by whitespace. |
47
|
| ')' is preceded with whitespace. |
47
|
Error | Line |
| Found duplicate of 19 lines in C:\source\jakarta\jakarta-commons\jelly\jelly-tags\jetty\src\java\org\apache\commons\jelly\tags\jetty\GetRequestTag.java, starting from line 1 |
1
|
Error | Line |
| First sentence should end with a period. |
19
|
| First sentence should end with a period. |
27
|
| Expected an @return tag. |
28
|
Error | Line |
| Found duplicate of 19 lines in C:\source\jakarta\jakarta-commons\jelly\jelly-tags\jetty\src\java\org\apache\commons\jelly\tags\jetty\GetRequestTag.java, starting from line 1 |
1
|
| Found duplicate of 19 lines in C:\source\jakarta\jakarta-commons\jelly\jelly-tags\jetty\src\java\org\apache\commons\jelly\tags\jetty\PostRequestTag.java, starting from line 1 |
1
|
Error | Line |
| First sentence should end with a period. |
25
|
| First sentence should end with a period. |
28
|
| Expected an @return tag. |
29
|
Error | Line |
| Wrong order for 'java.io.IOException' import. |
25
|
| First sentence should end with a period. |
28
|
| First sentence should end with a period. |
36
|
| Name '_name' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
37
|
| First sentence should end with a period. |
39
|
| Name '_config' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
40
|
| First sentence should end with a period. |
42
|
| Unused @throws tag for 'Exception'. |
52
|
| Expected @throws tag for 'JellyTagException'. |
54
|
| '(' is followed by whitespace. |
57
|
| ')' is preceded with whitespace. |
57
|
| '(' is followed by whitespace. |
58
|
| ')' is preceded with whitespace. |
58
|
| '(' is followed by whitespace. |
61
|
| ')' is preceded with whitespace. |
61
|
| '(' is followed by whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
Error | Line |
| Wrong order for 'java.util.StringTokenizer' import. |
25
|
| First sentence should end with a period. |
27
|
| First sentence should end with a period. |
35
|
| Name '_allowedMethods' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
36
|
| First sentence should end with a period. |
38
|
| Unused @throws tag for 'Exception'. |
47
|
| Expected @throws tag for 'JellyTagException'. |
49
|
| '(' is followed by whitespace. |
52
|
| ')' is preceded with whitespace. |
52
|
| Line is longer than 100 characters. |
53
|
| '(' is followed by whitespace. |
53
|
| ')' is preceded with whitespace. |
53
|
| '(' is followed by whitespace. |
59
|
| ')' is preceded with whitespace. |
59
|
Error | Line |
| First sentence should end with a period. |
28
|
| Unused @throws tag for 'Exception'. |
40
|
| Expected @throws tag for 'JellyTagException'. |
42
|
| '1500' is a magic number. |
50
|
| try child at indentation level 13 not at correct indentation, 12 |
52
|
| try child at indentation level 13 not at correct indentation, 12 |
53
|
| try child at indentation level 13 not at correct indentation, 12 |
54
|
| try child at indentation level 13 not at correct indentation, 12 |
55
|
| '}' should be on the same line. |
56
|
Error | Line |
| First sentence should end with a period. |
25
|
| First sentence should end with a period. |
32
|
| Name '_value' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
33
|
| Unused @throws tag for 'Exception'. |
40
|
| Expected @throws tag for 'JellyTagException'. |
42
|
| '100' is a magic number. |
44
|
Error | Line |
| First sentence should end with a period. |
25
|
| First sentence should end with a period. |
32
|
| Name '_name' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
33
|
| First sentence should end with a period. |
35
|
| Name '_value' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
36
|
| Unused @throws tag for 'Exception'. |
43
|
| Expected @throws tag for 'JellyTagException'. |
45
|
| Unused @param tag for 'path'. |
83
|
| Expected @param tag for 'name'. |
85
|
Error | Line |
| Wrong order for 'java.io.IOException' import. |
36
|
| First sentence should end with a period. |
40
|
| First sentence should end with a period. |
48
|
| Field '_formAuthenticator' is used in only one method. |
49
|
| Name '_formAuthenticator' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
49
|
| First sentence should end with a period. |
51
|
| Name '_authenticationMethod' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
52
|
| First sentence should end with a period. |
54
|
| Unclosed HTML tag found: <constraints> tag to allow parsing of a well-formed snippet, |
63
|
| Unused @throws tag for 'Exception'. |
93
|
| Cyclomatic Complexity is 11 (max allowed is 10). |
95
|
| Expected @throws tag for 'JellyTagException'. |
95
|
| '(' is followed by whitespace. |
98
|
| ')' is preceded with whitespace. |
98
|
| Line is longer than 100 characters. |
99
|
| '(' is followed by whitespace. |
99
|
| ')' is preceded with whitespace. |
99
|
| '}' should be on the same line. |
119
|
| '}' should be on the same line. |
122
|
| '=' is not preceded with whitespace. |
127
|
| '=' is not followed by whitespace. |
127
|
| '{' should be on the previous line. |
130
|
| while child at indentation level 16 not at correct indentation, 12 |
131
|
| 'if' construct must use '{}'s. |
132
|
| if at indentation level 16 not at correct indentation, 12 |
132
|
| while child at indentation level 16 not at correct indentation, 12 |
135
|
| '=' is not preceded with whitespace. |
135
|
| '=' is not followed by whitespace. |
135
|
| 'cast' is not followed by whitespace. |
135
|
| while child at indentation level 16 not at correct indentation, 12 |
136
|
| '=' is not preceded with whitespace. |
136
|
| '=' is not followed by whitespace. |
136
|
| if at indentation level 16 not at correct indentation, 12 |
138
|
| if child at indentation level 20 not at correct indentation, 16 |
139
|
| if rcurly at indentation level 16 not at correct indentation, 12 |
140
|
| if child at indentation level 20 not at correct indentation, 16 |
141
|
| if rcurly at indentation level 16 not at correct indentation, 12 |
142
|
| Line is longer than 100 characters. |
143
|
| else rcurly at indentation level 16 not at correct indentation, 12 |
144
|
| Cyclomatic Complexity is 13 (max allowed is 10). |
159
|
| Missing a Javadoc comment. |
159
|
| '{' should be on the previous line. |
161
|
| '=' is not preceded with whitespace. |
164
|
| '=' is not followed by whitespace. |
164
|
| '!=' is not preceded with whitespace. |
165
|
| '!=' is not followed by whitespace. |
165
|
| '{' should be on the previous line. |
166
|
| '=' is not preceded with whitespace. |
169
|
| 'while' is not followed by whitespace. |
170
|
| '{' should be on the previous line. |
171
|
| '=' is not preceded with whitespace. |
172
|
| '=' is not followed by whitespace. |
172
|
| 'cast' is not followed by whitespace. |
172
|
| ',' is not followed by whitespace. |
172
|
| '=' is not preceded with whitespace. |
177
|
| '=' is not followed by whitespace. |
177
|
| '!=' is not preceded with whitespace. |
178
|
| '!=' is not followed by whitespace. |
178
|
| '{' should be on the previous line. |
179
|
| '=' is not preceded with whitespace. |
180
|
| '=' is not followed by whitespace. |
180
|
| ',' is not followed by whitespace. |
181
|
| 'if' construct must use '{}'s. |
182
|
| '==' is not preceded with whitespace. |
182
|
| '==' is not followed by whitespace. |
182
|
| '==' is not preceded with whitespace. |
182
|
| '==' is not followed by whitespace. |
182
|
| '||' should be on a new line. |
182
|
| 'if' construct must use '{}'s. |
185
|
| 'if' construct must use '{}'s. |
187
|
| '{' should be on the previous line. |
190
|
| '+' is not preceded with whitespace. |
191
|
| '+' is not followed by whitespace. |
191
|
| '=' is not preceded with whitespace. |
196
|
| 'while' is not followed by whitespace. |
197
|
| '{' should be on the previous line. |
198
|
| '=' is not preceded with whitespace. |
199
|
| '=' is not followed by whitespace. |
199
|
| 'cast' is not followed by whitespace. |
199
|
| '=' is not preceded with whitespace. |
200
|
| '=' is not followed by whitespace. |
200
|
| ',' is not followed by whitespace. |
200
|
| ',' is not followed by whitespace. |
200
|
| 'cast' is not followed by whitespace. |
201
|
| '=' is not preceded with whitespace. |
204
|
| 'while' construct must use '{}'s. |
205
|
| 'while' is not followed by whitespace. |
205
|
| 'cast' is not followed by whitespace. |
206
|
| ',' is not followed by whitespace. |
207
|
| '=' is not preceded with whitespace. |
209
|
| 'while' is not followed by whitespace. |
210
|
| '{' should be on the previous line. |
211
|
| '=' is not preceded with whitespace. |
212
|
| 'cast' is not followed by whitespace. |
213
|
| ',' is not followed by whitespace. |
213
|
| ',' is not followed by whitespace. |
214
|
| Cyclomatic Complexity is 13 (max allowed is 10). |
230
|
| Missing a Javadoc comment. |
230
|
| '{' should be on the previous line. |
232
|
| '=' is not preceded with whitespace. |
233
|
| '=' is not followed by whitespace. |
233
|
| '!=' is not preceded with whitespace. |
234
|
| '!=' is not followed by whitespace. |
234
|
| '{' should be on the previous line. |
235
|
| '=' is not preceded with whitespace. |
236
|
| '=' is not followed by whitespace. |
236
|
| '=' is not preceded with whitespace. |
237
|
| '=' is not followed by whitespace. |
237
|
| ',' is not followed by whitespace. |
237
|
| 'if' construct must use '{}'s. |
239
|
| '=' is not preceded with whitespace. |
240
|
| '=' is not followed by whitespace. |
240
|
| '=' is not preceded with whitespace. |
240
|
| Inner assignments should be avoided. |
240
|
| '=' is not followed by whitespace. |
240
|
| 'if' construct must use '{}'s. |
241
|
| '=' is not preceded with whitespace. |
242
|
| '=' is not followed by whitespace. |
242
|
| 'if' construct must use '{}'s. |
243
|
| '=' is not preceded with whitespace. |
244
|
| '=' is not followed by whitespace. |
244
|
| 'if' construct must use '{}'s. |
245
|
| '=' is not preceded with whitespace. |
246
|
| '=' is not followed by whitespace. |
246
|
| 'else' construct must use '{}'s. |
247
|
| '+' is not preceded with whitespace. |
248
|
| '+' is not followed by whitespace. |
248
|
| '=' is not preceded with whitespace. |
253
|
| '=' is not followed by whitespace. |
253
|
| 'if' construct must use '{}'s. |
254
|
| '!=' is not preceded with whitespace. |
254
|
| '!=' is not followed by whitespace. |
254
|
| ',' is not followed by whitespace. |
255
|
| 'if' is not followed by whitespace. |
258
|
| '{' should be on the previous line. |
259
|
| 'if' construct must use '{}'s. |
260
|
| '==' is not preceded with whitespace. |
260
|
| '==' is not followed by whitespace. |
260
|
| '{' should be on the previous line. |
263
|
| 'if' construct must use '{}'s. |
265
|
| ',' is not followed by whitespace. |
266
|
| 'if' construct must use '{}'s. |
268
|
| ',' is not followed by whitespace. |
269
|
Error | Line |
| First sentence should end with a period. |
28
|
| First sentence should end with a period. |
36
|
| Name '_port' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
37
|
| First sentence should end with a period. |
39
|
| Name '_host' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
40
|
| First sentence should end with a period. |
42
|
| Unused @throws tag for 'Exception'. |
51
|
| Expected @throws tag for 'JellyTagException'. |
53
|
| '(' is followed by whitespace. |
56
|
| ')' is preceded with whitespace. |
56
|
| Line is longer than 100 characters. |
57
|
| '(' is followed by whitespace. |
57
|
| ')' is preceded with whitespace. |
57
|
| '}' should be on the same line. |
63
|
|