Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files |
Infos |
Warnings |
Errors |
149 |
0 |
0 |
2776 |
Files
org/apache/torque/NoRowsException.java
Error |
Line |
|
Parameter msg should be final. |
43
|
|
Parameter nested should be final. |
55
|
|
Parameter msg should be final. |
68
|
|
Parameter nested should be final. |
68
|
org/apache/torque/TooManyRowsException.java
Error |
Line |
|
Parameter msg should be final. |
42
|
|
Parameter nested should be final. |
54
|
|
Parameter msg should be final. |
67
|
|
Parameter nested should be final. |
67
|
org/apache/torque/Torque.java
Error |
Line |
|
Utility classes should not have a public or default constructor. |
41
|
|
Line has trailing spaces. |
60
|
|
Line has trailing spaces. |
63
|
|
Parameter configFile should be final. |
119
|
|
Parameter conf should be final. |
132
|
|
Parameter conf should be final. |
153
|
|
Parameter name should be final. |
174
|
|
Parameter name should be final. |
187
|
|
Parameter defaultClassName should be final. |
188
|
|
Line has trailing spaces. |
199
|
|
Line has trailing spaces. |
200
|
|
Parameter name should be final. |
232
|
|
Parameter className should be final. |
243
|
|
Parameter name should be final. |
269
|
|
Parameter name should be final. |
287
|
|
Parameter username should be final. |
287
|
|
Parameter password should be final. |
288
|
|
Parameter name should be final. |
301
|
|
Parameter con should be final. |
321
|
|
Parameter name should be final. |
334
|
|
Parameter schema should be final. |
334
|
|
Parameter name should be final. |
348
|
org/apache/torque/TorqueException.java
Error |
Line |
|
Parameter msg should be final. |
45
|
|
Parameter nested should be final. |
57
|
|
Parameter msg should be final. |
70
|
|
Parameter nested should be final. |
70
|
org/apache/torque/TorqueInstance.java
Error |
Line |
|
Unused import - org.apache.torque.dsfactory.AbstractDataSourceFactory. |
36
|
|
Name 'defaultDBName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
67
|
|
Name 'dbMaps' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
70
|
|
Name 'dsFactoryMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
73
|
|
Name 'adapterMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
76
|
|
Name 'managers' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
79
|
|
Name 'conf' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
82
|
|
Name 'isInit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
85
|
|
Name 'mapBuilders' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
93
|
|
Line has trailing spaces. |
139
|
|
Line has trailing spaces. |
164
|
|
Line has trailing spaces. |
165
|
|
Line has trailing spaces. |
168
|
|
Redundant 'final' modifier. |
172
|
|
Parameter conf should be final. |
172
|
|
'conf' hides a field. |
172
|
|
Line has trailing spaces. |
178
|
|
Line has trailing spaces. |
186
|
|
Redundant 'final' modifier. |
202
|
|
Parameter conf should be final. |
202
|
|
'conf' hides a field. |
202
|
|
Line has trailing spaces. |
220
|
|
';' is followed by whitespace. |
223
|
|
Line is longer than 80 characters. |
233
|
|
Line has trailing spaces. |
243
|
|
Parameter conf should be final. |
267
|
|
'conf' hides a field. |
267
|
|
Line has trailing spaces. |
272
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
335
|
|
Parameter configFile should be final. |
335
|
|
'conf' hides a field. |
341
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
359
|
|
Parameter conf should be final. |
359
|
|
'conf' hides a field. |
359
|
|
Method 'initManagerMappings' is not designed for extension - needs to be abstract, final or empty. |
390
|
|
Parameter conf should be final. |
390
|
|
'conf' hides a field. |
390
|
|
Parameter name should be final. |
436
|
|
Parameter className should be final. |
436
|
|
Method 'isInit' is not designed for extension - needs to be abstract, final or empty. |
466
|
|
Method 'setConfiguration' is not designed for extension - needs to be abstract, final or empty. |
476
|
|
Parameter conf should be final. |
476
|
|
'conf' hides a field. |
476
|
|
Method 'getConfiguration' is not designed for extension - needs to be abstract, final or empty. |
487
|
|
Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
499
|
|
Parameter name should be final. |
499
|
|
Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
517
|
|
Parameter name should be final. |
517
|
|
Parameter defaultClassName should be final. |
518
|
|
Line has trailing spaces. |
548
|
|
Line has trailing spaces. |
549
|
|
Line has trailing spaces. |
552
|
|
Method 'shutdown' is not designed for extension - needs to be abstract, final or empty. |
552
|
|
Line has trailing spaces. |
571
|
|
Line has trailing spaces. |
573
|
|
Line has trailing spaces. |
581
|
|
Line contains a tab character. |
585
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
614
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
630
|
|
Parameter name should be final. |
630
|
|
Redundant 'final' modifier. |
664
|
|
Parameter name should be final. |
664
|
|
Method 'registerMapBuilder' is not designed for extension - needs to be abstract, final or empty. |
707
|
|
Parameter className should be final. |
707
|
|
Parameter db should be final. |
720
|
|
Parameter prop should be final. |
720
|
|
Redundant 'final' modifier. |
738
|
|
Parameter map should be final. |
738
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
755
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
768
|
|
Parameter name should be final. |
768
|
|
'catch' is not followed by whitespace. |
778
|
|
Line has trailing spaces. |
785
|
|
Method 'getDataSourceFactory' is not designed for extension - needs to be abstract, final or empty. |
790
|
|
Parameter name should be final. |
790
|
|
Expected @throws tag for 'TorqueException'. |
791
|
|
Line has trailing spaces. |
793
|
|
Line contains a tab character. |
793
|
|
Line contains a tab character. |
794
|
|
Line has trailing spaces. |
795
|
|
Line contains a tab character. |
795
|
|
Line contains a tab character. |
796
|
|
Line contains a tab character. |
798
|
|
Line has trailing spaces. |
808
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
831
|
|
Parameter name should be final. |
831
|
|
Parameter username should be final. |
831
|
|
Parameter password should be final. |
832
|
|
Line is longer than 80 characters. |
837
|
|
'catch' is not followed by whitespace. |
839
|
|
Method 'getDB' is not designed for extension - needs to be abstract, final or empty. |
853
|
|
Parameter name should be final. |
853
|
|
Method 'getDefaultDB' is not designed for extension - needs to be abstract, final or empty. |
865
|
|
Method 'closeConnection' is not designed for extension - needs to be abstract, final or empty. |
875
|
|
Parameter con should be final. |
875
|
|
Method 'setSchema' is not designed for extension - needs to be abstract, final or empty. |
898
|
|
Parameter name should be final. |
898
|
|
Parameter schema should be final. |
898
|
|
Method 'getSchema' is not designed for extension - needs to be abstract, final or empty. |
912
|
|
Parameter name should be final. |
912
|
org/apache/torque/TorqueRuntimeException.java
Error |
Line |
|
Name 'nested' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
|
Parameter msg should be final. |
66
|
|
Parameter nested should be final. |
78
|
|
'nested' hides a field. |
78
|
|
Parameter msg should be final. |
92
|
|
Parameter nested should be final. |
92
|
|
'nested' hides a field. |
92
|
|
Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
101
|
|
Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
114
|
|
Parameter out should be final. |
114
|
|
Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
Parameter out should be final. |
130
|
|
Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
Parameter out should be final. |
145
|
|
Parameter skip should be final. |
145
|
|
Parameter t should be final. |
194
|
|
Parameter stackTrace should be final. |
208
|
org/apache/torque/adapter/DB.java
Error |
Line |
|
Line is longer than 80 characters. |
73
|
|
Line contains a tab character. |
76
|
|
Line has trailing spaces. |
77
|
|
Line contains a tab character. |
77
|
|
Line contains a tab character. |
78
|
|
Line contains a tab character. |
79
|
|
Parameter in should be final. |
94
|
|
Method 'getStringDelimiter' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
Parameter obj should be final. |
125
|
|
Parameter con should be final. |
134
|
|
Parameter table should be final. |
134
|
|
Parameter con should be final. |
144
|
|
Parameter table should be final. |
144
|
|
Parameter in should be final. |
153
|
|
Method 'ignoreCaseInOrderBy' is not designed for extension - needs to be abstract, final or empty. |
164
|
|
Parameter in should be final. |
164
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
176
|
|
Method 'supportsNativeOffset' is not designed for extension - needs to be abstract, final or empty. |
189
|
|
Method 'escapeText' is not designed for extension - needs to be abstract, final or empty. |
202
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
213
|
|
Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
225
|
|
Parameter date should be final. |
225
|
|
Method 'getBooleanString' is not designed for extension - needs to be abstract, final or empty. |
246
|
|
Parameter b should be final. |
246
|
|
Avoid inline conditionals. |
248
|
org/apache/torque/adapter/DBAxion.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
Parameter in should be final. |
45
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
Parameter in should be final. |
56
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
Parameter obj should be final. |
72
|
|
Parameter con should be final. |
84
|
|
Parameter table should be final. |
84
|
|
Parameter con should be final. |
95
|
|
Parameter table should be final. |
95
|
org/apache/torque/adapter/DBCloudscape.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
Parameter in should be final. |
46
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
Parameter in should be final. |
57
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
Parameter obj should be final. |
73
|
|
'132' is a magic number. |
75
|
|
'3' is a magic number. |
102
|
|
Parameter con should be final. |
132
|
|
Parameter table should be final. |
132
|
|
Parameter con should be final. |
143
|
|
Parameter table should be final. |
143
|
org/apache/torque/adapter/DBDB2400.java
Error |
Line |
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
Parameter in should be final. |
48
|
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
Parameter in should be final. |
60
|
|
Parameter in should be final. |
73
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
84
|
org/apache/torque/adapter/DBDB2App.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
Parameter in should be final. |
49
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
Parameter in should be final. |
61
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
Parameter obj should be final. |
78
|
|
Parameter con should be final. |
90
|
|
Parameter table should be final. |
90
|
|
Parameter con should be final. |
101
|
|
Parameter table should be final. |
101
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
111
|
org/apache/torque/adapter/DBDB2Net.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
Parameter in should be final. |
50
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
Parameter in should be final. |
62
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
79
|
|
Parameter obj should be final. |
79
|
|
Parameter con should be final. |
91
|
|
Parameter table should be final. |
91
|
|
Parameter con should be final. |
102
|
|
Parameter table should be final. |
102
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
112
|
org/apache/torque/adapter/DBDerby.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
Parameter str should be final. |
46
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
Parameter str should be final. |
60
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
Parameter obj should be final. |
76
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
Parameter con should be final. |
88
|
|
Parameter table should be final. |
88
|
|
Parameter con should be final. |
105
|
|
Parameter table should be final. |
105
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
116
|
org/apache/torque/adapter/DBFactory.java
Error |
Line |
|
Utility classes should not have a public or default constructor. |
34
|
|
'40' is a magic number. |
39
|
|
Parameter driver should be final. |
107
|
org/apache/torque/adapter/DBHypersonicSQL.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
Parameter in should be final. |
46
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
Parameter in should be final. |
58
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
Parameter obj should be final. |
74
|
|
Parameter con should be final. |
89
|
|
Parameter table should be final. |
89
|
|
Parameter con should be final. |
100
|
|
Parameter table should be final. |
100
|
org/apache/torque/adapter/DBInformix.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
Parameter in should be final. |
47
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
Parameter in should be final. |
60
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
Parameter obj should be final. |
76
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
Parameter con should be final. |
88
|
|
Parameter table should be final. |
88
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
107
|
|
Parameter con should be final. |
107
|
|
Parameter table should be final. |
107
|
org/apache/torque/adapter/DBInstantDB.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
Parameter in should be final. |
49
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
Parameter in should be final. |
60
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
Parameter obj should be final. |
76
|
|
Parameter con should be final. |
88
|
|
Parameter table should be final. |
88
|
|
Parameter con should be final. |
99
|
|
Parameter table should be final. |
99
|
org/apache/torque/adapter/DBInterbase.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
Parameter in should be final. |
37
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
Parameter in should be final. |
48
|
|
Method 'ignoreCaseInOrderBy' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
Parameter in should be final. |
62
|
|
Method 'getStringDelimiter' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
Parameter obj should be final. |
88
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
Parameter con should be final. |
100
|
|
Parameter table should be final. |
100
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
122
|
|
Parameter con should be final. |
122
|
|
Parameter table should be final. |
122
|
org/apache/torque/adapter/DBMM.java
Error |
Line |
|
Line has trailing spaces. |
43
|
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
Parameter in should be final. |
60
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
Parameter in should be final. |
71
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
79
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
Parameter obj should be final. |
91
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
Parameter con should be final. |
104
|
|
Parameter table should be final. |
104
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
120
|
|
Parameter con should be final. |
120
|
|
Parameter table should be final. |
120
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
132
|
|
Method 'supportsNativeOffset' is not designed for extension - needs to be abstract, final or empty. |
144
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
155
|
|
Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
168
|
|
Parameter date should be final. |
168
|
org/apache/torque/adapter/DBMSSQL.java
Error |
Line |
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
45
|
org/apache/torque/adapter/DBNone.java
Error |
Line |
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
Parameter in should be final. |
54
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
Parameter in should be final. |
65
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
Parameter obj should be final. |
81
|
|
Parameter con should be final. |
93
|
|
Parameter table should be final. |
93
|
|
Parameter con should be final. |
104
|
|
Parameter table should be final. |
104
|
org/apache/torque/adapter/DBOdbc.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
Parameter in should be final. |
45
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
Parameter in should be final. |
56
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
Parameter obj should be final. |
72
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
Parameter con should be final. |
86
|
|
Parameter table should be final. |
86
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
Parameter con should be final. |
100
|
|
Parameter table should be final. |
100
|
org/apache/torque/adapter/DBOracle.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
Parameter in should be final. |
52
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
Parameter in should be final. |
63
|
|
Line has trailing spaces. |
74
|
|
Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
Parameter date should be final. |
74
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
101
|
|
Parameter sequenceName should be final. |
101
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
113
|
|
Parameter con should be final. |
113
|
|
Parameter table should be final. |
113
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
132
|
|
Parameter con should be final. |
132
|
|
Parameter table should be final. |
132
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
156
|
|
Method 'escapeText' is not designed for extension - needs to be abstract, final or empty. |
168
|
org/apache/torque/adapter/DBPostgres.java
Error |
Line |
|
Missing a Javadoc comment. |
39
|
|
Name 'sdf' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
39
|
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
Parameter in should be final. |
55
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
Parameter in should be final. |
67
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
Parameter name should be final. |
87
|
|
Parameter con should be final. |
99
|
|
Parameter table should be final. |
99
|
|
Parameter con should be final. |
110
|
|
Parameter table should be final. |
110
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
120
|
|
Method 'supportsNativeOffset' is not designed for extension - needs to be abstract, final or empty. |
132
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
143
|
|
Method 'getBooleanString' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
Parameter b should be final. |
153
|
|
Line is longer than 80 characters. |
155
|
|
Avoid inline conditionals. |
155
|
|
Avoid inline conditionals. |
155
|
|
Line has trailing spaces. |
160
|
|
Line has trailing spaces. |
162
|
|
Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
168
|
|
Parameter date should be final. |
168
|
org/apache/torque/adapter/DBSapDB.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
Parameter in should be final. |
46
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
Parameter in should be final. |
57
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
Parameter sequenceName should be final. |
83
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
Parameter con should be final. |
95
|
|
Parameter table should be final. |
95
|
|
Method 'escapeText' is not designed for extension - needs to be abstract, final or empty. |
115
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
128
|
|
Parameter con should be final. |
128
|
|
Parameter table should be final. |
128
|
org/apache/torque/adapter/DBSybase.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
Parameter in should be final. |
54
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
Parameter in should be final. |
65
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
Parameter unused should be final. |
85
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
Parameter con should be final. |
97
|
|
Parameter table should be final. |
97
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
Parameter con should be final. |
116
|
|
Parameter table should be final. |
116
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
140
|
|
Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
Parameter date should be final. |
153
|
org/apache/torque/adapter/DBWeblogic.java
Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
Parameter in should be final. |
44
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
Parameter in should be final. |
55
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
Parameter obj should be final. |
71
|
|
Parameter con should be final. |
83
|
|
Parameter table should be final. |
83
|
|
Parameter con should be final. |
94
|
|
Parameter table should be final. |
94
|
org/apache/torque/adapter/IDMethod.java
Error |
Line |
|
interfaces should describe a type and hence have methods. |
26
|
org/apache/torque/avalon/Torque.java
Error |
Line |
|
Line does not match expected header line of '/*'. |
3
|
|
interfaces should describe a type and hence have methods. |
28
|
|
Missing a Javadoc comment. |
31
|
org/apache/torque/avalon/TorqueComponent.java
Error |
Line |
|
Line does not match expected header line of ' * Copyright 2001-2004 The Apache Software Foundation.'. |
4
|
|
Name 'context' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
56
|
|
Name 'torqueInstance' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
59
|
|
Name 'configFile' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
62
|
|
Line is longer than 80 characters. |
71
|
|
Parameter torqueInstance should be final. |
84
|
|
'torqueInstance' hides a field. |
84
|
|
Line is longer than 80 characters. |
106
|
|
Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
Parameter configuration should be final. |
108
|
|
'configFile' hides a field. |
113
|
|
Line has trailing spaces. |
118
|
|
Avoid inline conditionals. |
119
|
|
Line has trailing spaces. |
139
|
|
Line has trailing spaces. |
144
|
|
Method 'contextualize' is not designed for extension - needs to be abstract, final or empty. |
156
|
|
Parameter context should be final. |
156
|
|
'context' hides a field. |
156
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
Method 'start' is not designed for extension - needs to be abstract, final or empty. |
175
|
|
Method 'stop' is not designed for extension - needs to be abstract, final or empty. |
183
|
|
Line has trailing spaces. |
186
|
|
Line contains a tab character. |
188
|
|
Method 'isInit' is not designed for extension - needs to be abstract, final or empty. |
210
|
|
Method 'getConfiguration' is not designed for extension - needs to be abstract, final or empty. |
220
|
|
Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
231
|
|
Parameter name should be final. |
231
|
|
Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
244
|
|
Parameter name should be final. |
244
|
|
Parameter defaultClassName should be final. |
245
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
257
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
273
|
|
Parameter name should be final. |
273
|
|
Method 'registerMapBuilder' is not designed for extension - needs to be abstract, final or empty. |
284
|
|
Parameter className should be final. |
284
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
296
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
309
|
|
Parameter name should be final. |
309
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
327
|
|
Parameter name should be final. |
327
|
|
Parameter username should be final. |
327
|
|
Parameter password should be final. |
328
|
|
Method 'getDB' is not designed for extension - needs to be abstract, final or empty. |
341
|
|
Parameter name should be final. |
341
|
|
Method 'getDefaultDB' is not designed for extension - needs to be abstract, final or empty. |
352
|
|
Method 'closeConnection' is not designed for extension - needs to be abstract, final or empty. |
362
|
|
Parameter con should be final. |
362
|
org/apache/torque/dsfactory/AbstractDataSourceFactory.java
Error |
Line |
|
Line has trailing spaces. |
63
|
|
Line has trailing spaces. |
67
|
|
Line has trailing spaces. |
71
|
|
Name 'schema' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
79
|
|
Method 'setProperty' is not designed for extension - needs to be abstract, final or empty. |
90
|
|
Parameter property should be final. |
90
|
|
Parameter c should be final. |
90
|
|
Parameter ds should be final. |
90
|
|
Line has trailing spaces. |
134
|
|
Line is longer than 80 characters. |
156
|
|
Line has trailing spaces. |
158
|
|
Method 'applyConfiguration' is not designed for extension - needs to be abstract, final or empty. |
191
|
|
Parameter c should be final. |
191
|
|
Parameter o should be final. |
191
|
|
Line has trailing spaces. |
213
|
|
Method 'initCPDS' is not designed for extension - needs to be abstract, final or empty. |
221
|
|
Parameter configuration should be final. |
221
|
|
Line has trailing spaces. |
238
|
|
Line has trailing spaces. |
241
|
|
Method 'setSchema' is not designed for extension - needs to be abstract, final or empty. |
250
|
|
Parameter schema should be final. |
250
|
|
'schema' hides a field. |
250
|
|
Unused @throws tag for 'TorqueException'. |
259
|
|
Method 'getSchema' is not designed for extension - needs to be abstract, final or empty. |
262
|
|
Line has trailing spaces. |
281
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
281
|
|
Parameter configuration should be final. |
281
|
org/apache/torque/dsfactory/DataSourceFactory.java
Error |
Line |
|
Redundant 'public' modifier. |
35
|
|
Line has trailing spaces. |
39
|
|
Redundant 'public' modifier. |
41
|
|
Line has trailing spaces. |
42
|
|
Line has trailing spaces. |
56
|
|
Unused @throws tag for 'TorqueException'. |
70
|
|
Line has trailing spaces. |
76
|
|
Line has trailing spaces. |
78
|
|
Line has trailing spaces. |
80
|
|
Line has trailing spaces. |
82
|
|
Line has trailing spaces. |
83
|
|
Line has trailing spaces. |
89
|
org/apache/torque/dsfactory/JndiDataSourceFactory.java
Error |
Line |
|
Name 'path' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
58
|
|
Name 'ctx' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
60
|
|
Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
63
|
|
Name 'lastLookup' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
66
|
|
Name 'ttl' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
69
|
|
Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
Line has trailing spaces. |
77
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
Parameter configuration should be final. |
97
|
|
Parameter configuration should be final. |
111
|
|
';' is followed by whitespace. |
126
|
|
Parameter configuration should be final. |
173
|
|
'ds' hides a field. |
179
|
|
';' is followed by whitespace. |
184
|
|
Line has trailing spaces. |
194
|
|
Line is longer than 80 characters. |
204
|
|
Line is longer than 80 characters. |
210
|
|
Line has trailing spaces. |
236
|
|
Parameter ctx should be final. |
242
|
|
'ctx' hides a field. |
242
|
|
Expected @throws tag for 'NamingException'. |
242
|
|
Parameter ctx should be final. |
263
|
|
'ctx' hides a field. |
263
|
|
Expected @param tag for 'ctx'. |
263
|
|
Parameter path should be final. |
263
|
|
'path' hides a field. |
263
|
|
Expected @param tag for 'path'. |
263
|
|
Parameter ds should be final. |
263
|
|
'ds' hides a field. |
263
|
|
Expected @param tag for 'ds'. |
263
|
|
Expected @throws tag for 'Exception'. |
264
|
|
Must have at least one statement. |
286
|
|
Must have at least one statement. |
290
|
org/apache/torque/dsfactory/PerUserPoolDataSourceFactory.java
Error |
Line |
|
Line has trailing spaces. |
45
|
|
Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
|
Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
Parameter configuration should be final. |
62
|
|
'ds' hides a field. |
67
|
|
Parameter configuration should be final. |
79
|
|
'ds' hides a field. |
83
|
|
Line has trailing spaces. |
101
|
|
Method 'close' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
Line has trailing spaces. |
108
|
org/apache/torque/dsfactory/SharedPoolDataSourceFactory.java
Error |
Line |
|
Line has trailing spaces. |
45
|
|
Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
|
Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
62
|
|
Parameter configuration should be final. |
62
|
|
'ds' hides a field. |
67
|
|
Parameter configuration should be final. |
79
|
|
'ds' hides a field. |
83
|
|
Line has trailing spaces. |
101
|
|
Line has trailing spaces. |
102
|
|
Method 'close' is not designed for extension - needs to be abstract, final or empty. |
107
|
|
Line has trailing spaces. |
109
|
|
Line contains a tab character. |
111
|
org/apache/torque/manager/AbstractBaseManager.java
Error |
Line |
|
Variable 'log' must be private and have accessor methods. |
54
|
|
Name 'cache' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
57
|
|
Variable 'cache' must be private and have accessor methods. |
57
|
|
Name 'mrCache' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
60
|
|
Variable 'mrCache' must be private and have accessor methods. |
60
|
|
Name 'omClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
63
|
|
Missing a Javadoc comment. |
65
|
|
Name 'className' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
65
|
|
Missing a Javadoc comment. |
67
|
|
Name 'region' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
67
|
|
Missing a Javadoc comment. |
69
|
|
Name 'isNew' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
69
|
|
Missing a Javadoc comment. |
71
|
|
Name 'validFields' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
71
|
|
Variable 'validFields' must be private and have accessor methods. |
71
|
|
Missing a Javadoc comment. |
72
|
|
Name 'listenersMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
72
|
|
Variable 'listenersMap' must be private and have accessor methods. |
72
|
|
Method 'getOMClass' is not designed for extension - needs to be abstract, final or empty. |
79
|
|
Method 'setOMClass' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
Parameter omClass should be final. |
89
|
|
'omClass' hides a field. |
89
|
|
Method 'getOMInstance' is not designed for extension - needs to be abstract, final or empty. |
101
|
|
Expected @throws tag for 'InstantiationException'. |
102
|
|
Expected @throws tag for 'IllegalAccessException'. |
102
|
|
Method 'getClassName' is not designed for extension - needs to be abstract, final or empty. |
111
|
|
Method 'setClassName' is not designed for extension - needs to be abstract, final or empty. |
122
|
|
Parameter v should be final. |
122
|
|
Expected an @return tag. |
145
|
|
Method 'getOMInstance' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
Parameter id should be final. |
145
|
|
Expected @param tag for 'id'. |
145
|
|
Expected an @return tag. |
157
|
|
Method 'getOMInstance' is not designed for extension - needs to be abstract, final or empty. |
157
|
|
Parameter key should be final. |
157
|
|
Expected @param tag for 'key'. |
157
|
|
Parameter fromCache should be final. |
157
|
|
Expected @param tag for 'fromCache'. |
157
|
|
Method 'cacheGet' is not designed for extension - needs to be abstract, final or empty. |
178
|
|
Missing a Javadoc comment. |
178
|
|
Parameter key should be final. |
178
|
|
Line has trailing spaces. |
192
|
|
Method 'clearImpl' is not designed for extension - needs to be abstract, final or empty. |
196
|
|
Line has trailing spaces. |
214
|
|
Expected an @return tag. |
220
|
|
Method 'removeInstanceImpl' is not designed for extension - needs to be abstract, final or empty. |
220
|
|
Parameter key should be final. |
220
|
|
Expected @param tag for 'key'. |
220
|
|
Line has trailing spaces. |
245
|
|
Expected an @return tag. |
251
|
|
Method 'putInstanceImpl' is not designed for extension - needs to be abstract, final or empty. |
251
|
|
Parameter om should be final. |
251
|
|
Expected @param tag for 'om'. |
251
|
|
Line has trailing spaces. |
259
|
|
Expected an @return tag. |
266
|
|
Method 'putInstanceImpl' is not designed for extension - needs to be abstract, final or empty. |
266
|
|
Parameter key should be final. |
266
|
|
Expected @param tag for 'key'. |
266
|
|
Parameter om should be final. |
266
|
|
Expected @param tag for 'om'. |
266
|
|
Line has trailing spaces. |
297
|
|
Expected an @return tag. |
303
|
|
Parameter id should be final. |
303
|
|
Expected @param tag for 'id'. |
303
|
|
Method 'getOMs' is not designed for extension - needs to be abstract, final or empty. |
314
|
|
Parameter ids should be final. |
314
|
|
Method 'getOMs' is not designed for extension - needs to be abstract, final or empty. |
328
|
|
Parameter ids should be final. |
328
|
|
Method 'getOMs' is not designed for extension - needs to be abstract, final or empty. |
342
|
|
Parameter ids should be final. |
342
|
|
Parameter fromCache should be final. |
342
|
|
Expected @param tag for 'fromCache'. |
342
|
|
Line has trailing spaces. |
400
|
|
Expected an @return tag. |
406
|
|
Parameter ids should be final. |
406
|
|
Expected @param tag for 'ids'. |
406
|
|
Line has trailing spaces. |
411
|
|
Method 'getRegion' is not designed for extension - needs to be abstract, final or empty. |
414
|
|
Method 'setRegion' is not designed for extension - needs to be abstract, final or empty. |
426
|
|
Parameter v should be final. |
426
|
|
Method 'getMethodResultCache' is not designed for extension - needs to be abstract, final or empty. |
455
|
|
The double-checked locking idiom is broken and should be avoided. |
461
|
|
Line has trailing spaces. |
480
|
|
Method 'addCacheListenerImpl' is not designed for extension - needs to be abstract, final or empty. |
483
|
|
Parameter listener should be final. |
483
|
|
'isNew' hides a field. |
499
|
|
Must have at least one statement. |
506
|
|
Line has trailing spaces. |
527
|
|
Parameter key should be final. |
531
|
|
Expected @param tag for 'key'. |
531
|
|
Line has trailing spaces. |
548
|
|
Method 'notifyListeners' is not designed for extension - needs to be abstract, final or empty. |
553
|
|
Parameter listeners should be final. |
553
|
|
Expected @param tag for 'listeners'. |
553
|
|
Parameter oldOm should be final. |
554
|
|
Expected @param tag for 'oldOm'. |
554
|
|
Parameter om should be final. |
554
|
|
Expected @param tag for 'om'. |
554
|
|
Line has trailing spaces. |
591
|
|
Parameter out should be final. |
595
|
|
Expected @param tag for 'out'. |
595
|
|
Expected @throws tag for 'IOException'. |
596
|
|
Line has trailing spaces. |
603
|
|
Parameter in should be final. |
608
|
|
Expected @throws tag for 'IOException'. |
609
|
|
Expected @throws tag for 'ClassNotFoundException'. |
609
|
org/apache/torque/manager/CacheListener.java
Error |
Line |
|
Line has trailing spaces. |
31
|
|
Expected @param tag for 'om'. |
34
|
|
Line has trailing spaces. |
35
|
|
Line has trailing spaces. |
37
|
|
Expected @param tag for 'om'. |
40
|
|
Line has trailing spaces. |
41
|
|
Line has trailing spaces. |
43
|
|
Line has trailing spaces. |
45
|
|
Expected an @return tag. |
47
|
org/apache/torque/manager/MethodCacheKey.java
Error |
Line |
|
Missing a Javadoc comment. |
32
|
|
Name 'n' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
32
|
|
Variable 'n' must be private and have accessor methods. |
32
|
|
Missing a Javadoc comment. |
33
|
|
Name 'instanceOrClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
33
|
|
Missing a Javadoc comment. |
34
|
|
Name 'method' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
34
|
|
Missing a Javadoc comment. |
35
|
|
Name 'arg1' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
35
|
|
Missing a Javadoc comment. |
36
|
|
Name 'arg2' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
36
|
|
Missing a Javadoc comment. |
37
|
|
Name 'arg3' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
37
|
|
Missing a Javadoc comment. |
38
|
|
Name 'moreThanThree' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
38
|
|
Missing a Javadoc comment. |
39
|
|
Name 'groupKey' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
39
|
|
Missing a Javadoc comment. |
41
|
|
Missing a Javadoc comment. |
45
|
|
Parameter instanceOrClass should be final. |
45
|
|
'instanceOrClass' hides a field. |
45
|
|
Parameter method should be final. |
45
|
|
'method' hides a field. |
45
|
|
Missing a Javadoc comment. |
50
|
|
Parameter instanceOrClass should be final. |
50
|
|
'instanceOrClass' hides a field. |
50
|
|
Parameter method should be final. |
50
|
|
'method' hides a field. |
50
|
|
Parameter arg1 should be final. |
51
|
|
'arg1' hides a field. |
51
|
|
Missing a Javadoc comment. |
56
|
|
Parameter instanceOrClass should be final. |
56
|
|
'instanceOrClass' hides a field. |
56
|
|
Parameter method should be final. |
56
|
|
'method' hides a field. |
56
|
|
Parameter arg1 should be final. |
57
|
|
'arg1' hides a field. |
57
|
|
Parameter arg2 should be final. |
57
|
|
'arg2' hides a field. |
57
|
|
Missing a Javadoc comment. |
62
|
|
Parameter instanceOrClass should be final. |
62
|
|
'instanceOrClass' hides a field. |
62
|
|
Parameter method should be final. |
62
|
|
'method' hides a field. |
62
|
|
Parameter arg1 should be final. |
63
|
|
'arg1' hides a field. |
63
|
|
Parameter arg2 should be final. |
63
|
|
'arg2' hides a field. |
63
|
|
Parameter arg3 should be final. |
64
|
|
'arg3' hides a field. |
64
|
|
Missing a Javadoc comment. |
69
|
|
Parameter moreThanThree should be final. |
69
|
|
'moreThanThree' hides a field. |
69
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
Parameter instanceOrClass should be final. |
81
|
|
'instanceOrClass' hides a field. |
81
|
|
Parameter method should be final. |
81
|
|
'method' hides a field. |
81
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
Parameter instanceOrClass should be final. |
97
|
|
'instanceOrClass' hides a field. |
97
|
|
Parameter method should be final. |
97
|
|
'method' hides a field. |
97
|
|
Parameter arg1 should be final. |
98
|
|
'arg1' hides a field. |
98
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
114
|
|
Parameter instanceOrClass should be final. |
114
|
|
'instanceOrClass' hides a field. |
114
|
|
Parameter method should be final. |
114
|
|
'method' hides a field. |
114
|
|
Parameter arg1 should be final. |
115
|
|
'arg1' hides a field. |
115
|
|
Parameter arg2 should be final. |
115
|
|
'arg2' hides a field. |
115
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
133
|
|
Parameter instanceOrClass should be final. |
133
|
|
'instanceOrClass' hides a field. |
133
|
|
Parameter method should be final. |
133
|
|
'method' hides a field. |
133
|
|
Parameter arg1 should be final. |
134
|
|
'arg1' hides a field. |
134
|
|
Parameter arg2 should be final. |
134
|
|
'arg2' hides a field. |
134
|
|
Parameter arg3 should be final. |
135
|
|
'arg3' hides a field. |
135
|
|
Expected @param tag for 'arg3'. |
135
|
|
'3' is a magic number. |
138
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
Parameter keys should be final. |
153
|
|
'3' is a magic number. |
162
|
|
'4' is a magic number. |
165
|
|
'3' is a magic number. |
166
|
|
Method 'getGroupKey' is not designed for extension - needs to be abstract, final or empty. |
175
|
|
Missing a Javadoc comment. |
175
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
180
|
|
Missing a Javadoc comment. |
180
|
|
Parameter obj should be final. |
180
|
|
'3' is a magic number. |
198
|
|
'5' is a magic number. |
200
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
214
|
|
Missing a Javadoc comment. |
214
|
|
Avoid inline conditionals. |
220
|
|
Avoid inline conditionals. |
223
|
|
Avoid inline conditionals. |
226
|
|
'3' is a magic number. |
227
|
|
'5' is a magic number. |
229
|
|
Avoid inline conditionals. |
231
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
241
|
|
Missing a Javadoc comment. |
241
|
|
'50' is a magic number. |
243
|
|
'3' is a magic number. |
256
|
|
'5' is a magic number. |
258
|
|
Missing a Javadoc comment. |
272
|
|
Method 'makeObject' is not designed for extension - needs to be abstract, final or empty. |
279
|
|
Expected @throws tag for 'Exception'. |
280
|
|
Method 'passivateObject' is not designed for extension - needs to be abstract, final or empty. |
289
|
|
Parameter obj should be final. |
289
|
|
Expected @throws tag for 'Exception'. |
290
|
org/apache/torque/manager/MethodResultCache.java
Error |
Line |
|
Missing a Javadoc comment. |
43
|
|
Name 'pool' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
|
Missing a Javadoc comment. |
44
|
|
Name 'jcsCache' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
|
Missing a Javadoc comment. |
45
|
|
Name 'groups' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
Missing a Javadoc comment. |
50
|
|
Parameter cache should be final. |
50
|
|
'10000' is a magic number. |
55
|
|
Method 'clear' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
Missing a Javadoc comment. |
67
|
|
Method 'getImpl' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
Missing a Javadoc comment. |
84
|
|
Parameter key should be final. |
84
|
|
Line is longer than 80 characters. |
99
|
|
Method 'putImpl' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
Missing a Javadoc comment. |
106
|
|
Parameter key should be final. |
106
|
|
Parameter value should be final. |
106
|
|
Method 'removeImpl' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
Missing a Javadoc comment. |
136
|
|
Parameter key should be final. |
136
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
152
|
|
Missing a Javadoc comment. |
152
|
|
Parameter instanceOrClass should be final. |
152
|
|
Parameter method should be final. |
152
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
180
|
|
Missing a Javadoc comment. |
180
|
|
Parameter instanceOrClass should be final. |
180
|
|
Parameter method should be final. |
180
|
|
Parameter arg1 should be final. |
181
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
209
|
|
Missing a Javadoc comment. |
209
|
|
Parameter instanceOrClass should be final. |
209
|
|
Parameter method should be final. |
209
|
|
Parameter arg1 should be final. |
210
|
|
Parameter arg2 should be final. |
210
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
238
|
|
Missing a Javadoc comment. |
238
|
|
Parameter instanceOrClass should be final. |
238
|
|
Parameter method should be final. |
238
|
|
Parameter arg1 should be final. |
239
|
|
Parameter arg2 should be final. |
239
|
|
Parameter arg3 should be final. |
240
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
268
|
|
Missing a Javadoc comment. |
268
|
|
Parameter keys should be final. |
268
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
296
|
|
Missing a Javadoc comment. |
296
|
|
Parameter value should be final. |
296
|
|
Parameter instanceOrClass should be final. |
296
|
|
Parameter method should be final. |
296
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
310
|
|
Missing a Javadoc comment. |
310
|
|
Parameter value should be final. |
310
|
|
Parameter instanceOrClass should be final. |
310
|
|
Parameter method should be final. |
311
|
|
Parameter arg1 should be final. |
311
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
325
|
|
Missing a Javadoc comment. |
325
|
|
Parameter value should be final. |
325
|
|
Parameter instanceOrClass should be final. |
325
|
|
Parameter method should be final. |
325
|
|
Parameter arg1 should be final. |
326
|
|
Parameter arg2 should be final. |
326
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
340
|
|
Missing a Javadoc comment. |
340
|
|
Parameter value should be final. |
340
|
|
Parameter instanceOrClass should be final. |
340
|
|
Parameter method should be final. |
340
|
|
Parameter arg1 should be final. |
341
|
|
Parameter arg2 should be final. |
341
|
|
Parameter arg3 should be final. |
341
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
355
|
|
Missing a Javadoc comment. |
355
|
|
Parameter value should be final. |
355
|
|
Parameter keys should be final. |
355
|
|
Method 'removeAll' is not designed for extension - needs to be abstract, final or empty. |
370
|
|
Missing a Javadoc comment. |
370
|
|
Parameter instanceOrClass should be final. |
370
|
|
Parameter method should be final. |
370
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
399
|
|
Missing a Javadoc comment. |
399
|
|
Parameter instanceOrClass should be final. |
399
|
|
Parameter method should be final. |
399
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
427
|
|
Missing a Javadoc comment. |
427
|
|
Parameter instanceOrClass should be final. |
427
|
|
Parameter method should be final. |
427
|
|
Parameter arg1 should be final. |
428
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
456
|
|
Missing a Javadoc comment. |
456
|
|
Parameter instanceOrClass should be final. |
456
|
|
Parameter method should be final. |
456
|
|
Parameter arg1 should be final. |
457
|
|
Parameter arg2 should be final. |
457
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
485
|
|
Missing a Javadoc comment. |
485
|
|
Parameter instanceOrClass should be final. |
485
|
|
Parameter method should be final. |
485
|
|
Parameter arg1 should be final. |
486
|
|
Parameter arg2 should be final. |
486
|
|
Parameter arg3 should be final. |
487
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
515
|
|
Missing a Javadoc comment. |
515
|
|
Parameter keys should be final. |
515
|
org/apache/torque/manager/NoOpMethodResultCache.java
Error |
Line |
|
Missing a Javadoc comment. |
32
|
|
Parameter cache should be final. |
32
|
|
Missing a Javadoc comment. |
38
|
|
Method 'getImpl' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
Missing a Javadoc comment. |
42
|
|
Parameter key should be final. |
42
|
|
Method 'putImpl' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
Missing a Javadoc comment. |
48
|
|
Parameter key should be final. |
48
|
|
Parameter value should be final. |
48
|
|
Method 'removeImpl' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
Missing a Javadoc comment. |
54
|
|
Parameter key should be final. |
54
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
Missing a Javadoc comment. |
61
|
|
Parameter instanceOrClass should be final. |
61
|
|
Parameter method should be final. |
61
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
Missing a Javadoc comment. |
66
|
|
Parameter instanceOrClass should be final. |
66
|
|
Parameter method should be final. |
66
|
|
Parameter arg1 should be final. |
67
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
Missing a Javadoc comment. |
72
|
|
Parameter instanceOrClass should be final. |
72
|
|
Parameter method should be final. |
72
|
|
Parameter arg1 should be final. |
73
|
|
Parameter arg2 should be final. |
73
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
Missing a Javadoc comment. |
78
|
|
Parameter instanceOrClass should be final. |
78
|
|
Parameter method should be final. |
78
|
|
Parameter arg1 should be final. |
79
|
|
Parameter arg2 should be final. |
79
|
|
Parameter arg3 should be final. |
80
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
Missing a Javadoc comment. |
85
|
|
Parameter keys should be final. |
85
|
|
Missing a Javadoc comment. |
90
|
|
Parameter value should be final. |
90
|
|
Parameter instanceOrClass should be final. |
90
|
|
Parameter method should be final. |
90
|
|
Missing a Javadoc comment. |
94
|
|
Parameter value should be final. |
94
|
|
Parameter instanceOrClass should be final. |
94
|
|
Parameter method should be final. |
95
|
|
Parameter arg1 should be final. |
95
|
|
Missing a Javadoc comment. |
99
|
|
Parameter value should be final. |
99
|
|
Parameter instanceOrClass should be final. |
99
|
|
Parameter method should be final. |
99
|
|
Parameter arg1 should be final. |
100
|
|
Parameter arg2 should be final. |
100
|
|
Missing a Javadoc comment. |
104
|
|
Parameter value should be final. |
104
|
|
Parameter instanceOrClass should be final. |
104
|
|
Parameter method should be final. |
104
|
|
Parameter arg1 should be final. |
105
|
|
Parameter arg2 should be final. |
105
|
|
Parameter arg3 should be final. |
105
|
|
Missing a Javadoc comment. |
109
|
|
Parameter value should be final. |
109
|
|
Parameter keys should be final. |
109
|
|
Missing a Javadoc comment. |
114
|
|
Parameter instanceOrClass should be final. |
114
|
|
Parameter method should be final. |
114
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
Missing a Javadoc comment. |
119
|
|
Parameter instanceOrClass should be final. |
119
|
|
Parameter method should be final. |
119
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
124
|
|
Missing a Javadoc comment. |
124
|
|
Parameter instanceOrClass should be final. |
124
|
|
Parameter method should be final. |
124
|
|
Parameter arg1 should be final. |
125
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
Missing a Javadoc comment. |
130
|
|
Parameter instanceOrClass should be final. |
130
|
|
Parameter method should be final. |
130
|
|
Parameter arg1 should be final. |
131
|
|
Parameter arg2 should be final. |
131
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
Missing a Javadoc comment. |
136
|
|
Parameter instanceOrClass should be final. |
136
|
|
Parameter method should be final. |
136
|
|
Parameter arg1 should be final. |
137
|
|
Parameter arg2 should be final. |
137
|
|
Parameter arg3 should be final. |
138
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
143
|
|
Missing a Javadoc comment. |
143
|
|
Parameter keys should be final. |
143
|
org/apache/torque/map/ColumnMap.java
Error |
Line |
|
Name 'type' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
28
|
|
Name 'size' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
31
|
|
Name 'pk' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
34
|
|
Name 'notNull' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
37
|
|
Name 'relatedTableName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
40
|
|
Name 'relatedColumnName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
|
Name 'table' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
46
|
|
Name 'columnName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
|
Parameter name should be final. |
58
|
|
Parameter containingTable should be final. |
58
|
|
Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
Method 'getFullyQualifiedName' is not designed for extension - needs to be abstract, final or empty. |
79
|
|
Method 'getTableName' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
Parameter type should be final. |
99
|
|
'type' hides a field. |
99
|
|
Method 'setSize' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
Parameter size should be final. |
109
|
|
'size' hides a field. |
109
|
|
Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
Parameter pk should be final. |
119
|
|
'pk' hides a field. |
119
|
|
Method 'setNotNull' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
Parameter nn should be final. |
129
|
|
Method 'setForeignKey' is not designed for extension - needs to be abstract, final or empty. |
140
|
|
Parameter fullyQualifiedName should be final. |
140
|
|
Method 'setForeignKey' is not designed for extension - needs to be abstract, final or empty. |
162
|
|
Parameter tableName should be final. |
162
|
|
Parameter columnName should be final. |
162
|
|
'columnName' hides a field. |
162
|
|
Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
182
|
|
Method 'getSize' is not designed for extension - needs to be abstract, final or empty. |
192
|
|
Method 'isPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
202
|
|
Method 'isNotNull' is not designed for extension - needs to be abstract, final or empty. |
212
|
|
Method 'isForeignKey' is not designed for extension - needs to be abstract, final or empty. |
222
|
|
Method 'getRelatedName' is not designed for extension - needs to be abstract, final or empty. |
232
|
|
Method 'getRelatedTableName' is not designed for extension - needs to be abstract, final or empty. |
242
|
|
Method 'getRelatedColumnName' is not designed for extension - needs to be abstract, final or empty. |
252
|
org/apache/torque/map/DatabaseMap.java
Error |
Line |
|
Name 'name' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
36
|
|
Name 'tables' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
39
|
|
Name 'idTable' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
Name 'idBroker' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
|
Name 'idGenerators' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
51
|
|
Parameter name should be final. |
66
|
|
'name' hides a field. |
66
|
|
Parameter numberOfTables should be final. |
66
|
|
'1.25' is a magic number. |
69
|
|
'6' is a magic number. |
70
|
|
Parameter name should be final. |
78
|
|
'name' hides a field. |
78
|
|
'6' is a magic number. |
82
|
|
Method 'containsTable' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
Parameter table should be final. |
91
|
|
Method 'containsTable' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
Parameter name should be final. |
102
|
|
'name' hides a field. |
102
|
|
Method 'getIdTable' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
Method 'getIDBroker' is not designed for extension - needs to be abstract, final or empty. |
126
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
136
|
|
Method 'getTable' is not designed for extension - needs to be abstract, final or empty. |
147
|
|
Parameter name should be final. |
147
|
|
'name' hides a field. |
147
|
|
Method 'getTables' is not designed for extension - needs to be abstract, final or empty. |
157
|
|
';' is preceded with whitespace. |
164
|
|
Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
175
|
|
Parameter tableName should be final. |
175
|
|
Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
188
|
|
Parameter tableName should be final. |
188
|
|
Parameter numberOfColumns should be final. |
188
|
|
Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
199
|
|
Parameter map should be final. |
199
|
|
Method 'setIdTable' is not designed for extension - needs to be abstract, final or empty. |
209
|
|
Parameter idTable should be final. |
209
|
|
'idTable' hides a field. |
209
|
|
Method 'setIdTable' is not designed for extension - needs to be abstract, final or empty. |
222
|
|
Parameter tableName should be final. |
222
|
|
Method 'addIdGenerator' is not designed for extension - needs to be abstract, final or empty. |
234
|
|
Parameter type should be final. |
234
|
|
Parameter idGen should be final. |
234
|
|
Method 'getIdGenerator' is not designed for extension - needs to be abstract, final or empty. |
246
|
|
Parameter type should be final. |
246
|
org/apache/torque/map/TableMap.java
Error |
Line |
|
Name 'columns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
44
|
|
Name 'dbMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
47
|
|
Name 'tableName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
50
|
|
Name 'prefix' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
53
|
|
Name 'primaryKeyMethod' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
56
|
|
Name 'pkInfo' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
62
|
|
Parameter tableName should be final. |
78
|
|
'tableName' hides a field. |
78
|
|
Parameter numberOfColumns should be final. |
79
|
|
Parameter containingDB should be final. |
80
|
|
'1.25' is a magic number. |
84
|
|
Parameter tableName should be final. |
93
|
|
'tableName' hides a field. |
93
|
|
Parameter containingDB should be final. |
93
|
|
'20' is a magic number. |
97
|
|
Parameter tableName should be final. |
108
|
|
'tableName' hides a field. |
108
|
|
Parameter prefix should be final. |
109
|
|
'prefix' hides a field. |
109
|
|
Parameter containingDB should be final. |
110
|
|
'20' is a magic number. |
115
|
|
Method 'containsColumn' is not designed for extension - needs to be abstract, final or empty. |
124
|
|
Parameter column should be final. |
124
|
|
Method 'containsColumn' is not designed for extension - needs to be abstract, final or empty. |
135
|
|
Parameter name should be final. |
135
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
149
|
|
Method 'containsObjectColumn' is not designed for extension - needs to be abstract, final or empty. |
161
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
181
|
|
Method 'getPrefix' is not designed for extension - needs to be abstract, final or empty. |
191
|
|
Method 'setPrefix' is not designed for extension - needs to be abstract, final or empty. |
202
|
|
Parameter prefix should be final. |
202
|
|
'prefix' hides a field. |
202
|
|
Method 'getPrimaryKeyMethod' is not designed for extension - needs to be abstract, final or empty. |
212
|
|
Method 'getIdGenerator' is not designed for extension - needs to be abstract, final or empty. |
221
|
|
Method 'getPrimaryKeyMethodInfo' is not designed for extension - needs to be abstract, final or empty. |
231
|
|
Method 'getColumns' is not designed for extension - needs to be abstract, final or empty. |
241
|
|
Method 'getColumn' is not designed for extension - needs to be abstract, final or empty. |
259
|
|
Parameter name should be final. |
259
|
|
Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
277
|
|
Parameter cmap should be final. |
277
|
|
Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
288
|
|
Parameter columnName should be final. |
288
|
|
Parameter type should be final. |
288
|
|
Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
300
|
|
Parameter columnName should be final. |
300
|
|
Parameter type should be final. |
300
|
|
Parameter size should be final. |
300
|
|
Method 'addPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
311
|
|
Parameter columnName should be final. |
311
|
|
Parameter type should be final. |
311
|
|
Method 'addPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
323
|
|
Parameter columnName should be final. |
323
|
|
Parameter type should be final. |
323
|
|
Parameter size should be final. |
323
|
|
Method 'addForeignKey' is not designed for extension - needs to be abstract, final or empty. |
336
|
|
Parameter columnName should be final. |
336
|
|
Parameter type should be final. |
337
|
|
Parameter fkTable should be final. |
338
|
|
Parameter fkColumn should be final. |
339
|
|
Method 'addForeignKey' is not designed for extension - needs to be abstract, final or empty. |
353
|
|
Parameter columnName should be final. |
353
|
|
Parameter type should be final. |
354
|
|
Parameter fkTable should be final. |
355
|
|
Parameter fkColumn should be final. |
356
|
|
Parameter size should be final. |
357
|
|
Method 'addForeignPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
370
|
|
Parameter columnName should be final. |
370
|
|
Parameter type should be final. |
371
|
|
Parameter fkTable should be final. |
372
|
|
Parameter fkColumn should be final. |
373
|
|
Method 'addForeignPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
387
|
|
Parameter columnName should be final. |
387
|
|
Parameter type should be final. |
388
|
|
Parameter fkTable should be final. |
389
|
|
Parameter fkColumn should be final. |
390
|
|
Parameter size should be final. |
391
|
|
Parameter name should be final. |
406
|
|
Parameter type should be final. |
407
|
|
Parameter pk should be final. |
408
|
|
Parameter fkTable should be final. |
409
|
|
Parameter fkColumn should be final. |
410
|
|
Parameter size should be final. |
411
|
|
Method 'setPrimaryKeyMethod' is not designed for extension - needs to be abstract, final or empty. |
443
|
|
Parameter method should be final. |
443
|
|
Method 'setPrimaryKeyMethodInfo' is not designed for extension - needs to be abstract, final or empty. |
463
|
|
Parameter pkInfo should be final. |
463
|
|
'pkInfo' hides a field. |
463
|
|
Redundant 'final' modifier. |
476
|
|
Parameter data should be final. |
476
|
|
Redundant 'final' modifier. |
487
|
|
Parameter data should be final. |
487
|
|
Parameter data should be final. |
501
|
org/apache/torque/oid/AutoIncrementIdGenerator.java
Error |
Line |
|
Name 'dbAdapter' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
38
|
|
Name 'name' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
41
|
|
'dbAdapter' hides a field. |
49
|
|
'name' hides a field. |
49
|
|
Method 'getIdAsInt' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
Parameter connection should be final. |
63
|
|
Parameter keyInfo should be final. |
63
|
|
Method 'getIdAsLong' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
Parameter connection should be final. |
77
|
|
Parameter keyInfo should be final. |
77
|
|
Method 'getIdAsBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
Parameter connection should be final. |
92
|
|
Parameter keyInfo should be final. |
92
|
|
Method 'getIdAsString' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
Parameter connection should be final. |
108
|
|
Parameter keyInfo should be final. |
108
|
|
Method 'isPriorToInsert' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
Method 'isPostInsert' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
Parameter connection should be final. |
154
|
|
Parameter keyInfo should be final. |
154
|
|
Line is longer than 80 characters. |
157
|
org/apache/torque/oid/IDBroker.java
Error |
Line |
|
Name 'tableMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
109
|
|
Name 'ids' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
123
|
|
Name 'quantityStore' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
131
|
|
Name 'lastQueryTime' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
139
|
|
'60000' is a magic number. |
144
|
|
Name 'houseKeeperThread' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
154
|
|
Name 'transactionsSupported' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
159
|
|
Name 'configuration' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
167
|
|
Name 'log' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
182
|
|
Parameter tMap should be final. |
189
|
|
Must have at least one statement. |
229
|
|
Method 'setConfiguration' is not designed for extension - needs to be abstract, final or empty. |
249
|
|
Parameter configuration should be final. |
249
|
|
'configuration' hides a field. |
249
|
|
Method 'getIdAsInt' is not designed for extension - needs to be abstract, final or empty. |
266
|
|
Parameter connection should be final. |
266
|
|
Parameter tableName should be final. |
266
|
|
Method 'getIdAsLong' is not designed for extension - needs to be abstract, final or empty. |
285
|
|
Parameter connection should be final. |
285
|
|
Parameter tableName should be final. |
285
|
|
Method 'getIdAsBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
303
|
|
Parameter connection should be final. |
303
|
|
Parameter tableName should be final. |
304
|
|
Method 'getIdAsString' is not designed for extension - needs to be abstract, final or empty. |
323
|
|
Parameter connection should be final. |
323
|
|
Parameter tableName should be final. |
323
|
|
Method 'isPriorToInsert' is not designed for extension - needs to be abstract, final or empty. |
334
|
|
Method 'isPostInsert' is not designed for extension - needs to be abstract, final or empty. |
344
|
|
Method 'isConnectionRequired' is not designed for extension - needs to be abstract, final or empty. |
355
|
|
Method 'getNextIds' is not designed for extension - needs to be abstract, final or empty. |
368
|
|
Parameter tableName should be final. |
368
|
|
Parameter numOfIdsToReturn should be final. |
369
|
|
Method 'getNextIds' is not designed for extension - needs to be abstract, final or empty. |
388
|
|
Parameter tableName should be final. |
388
|
|
Parameter numOfIdsToReturn should be final. |
389
|
|
Parameter connection should be final. |
390
|
|
Avoid inline conditionals. |
424
|
|
Method 'exists' is not designed for extension - needs to be abstract, final or empty. |
452
|
|
Parameter tableName should be final. |
452
|
|
Redundant throws: 'TorqueException' is subclass of 'Exception'. |
453
|
|
'100' is a magic number. |
455
|
|
Method 'run' is not designed for extension - needs to be abstract, final or empty. |
494
|
|
Must have at least one statement. |
506
|
|
Line is longer than 80 characters. |
532
|
|
Method 'stop' is not designed for extension - needs to be abstract, final or empty. |
553
|
|
Parameter tableName should be final. |
567
|
|
Parameter tableName should be final. |
614
|
|
Parameter adjustQuantity should be final. |
615
|
|
Parameter connection should be final. |
616
|
|
Parameter tableName should be final. |
705
|
|
Parameter connection should be final. |
705
|
|
'10' is a magic number. |
741
|
|
Parameter con should be final. |
768
|
|
Parameter tableName should be final. |
768
|
|
Parameter con should be final. |
826
|
|
Parameter tableName should be final. |
826
|
|
Parameter id should be final. |
826
|
|
'50' is a magic number. |
832
|
|
Parameter con should be final. |
874
|
|
Parameter tableName should be final. |
874
|
|
Parameter quantity should be final. |
875
|
|
'50' is a magic number. |
879
|
org/apache/torque/oid/IDGeneratorFactory.java
Error |
Line |
|
Utility classes should not have a public or default constructor. |
29
|
|
Parameter dbAdapter should be final. |
50
|
|
Parameter name should be final. |
50
|
|
Expected @param tag for 'name'. |
50
|
org/apache/torque/oid/SequenceIdGenerator.java
Error |
Line |
|
Name 'dbAdapter' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
45
|
|
Name 'name' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
|
Unused @param tag for 'adapter'. |
53
|
|
'dbAdapter' hides a field. |
56
|
|
Expected @param tag for 'dbAdapter'. |
56
|
|
'name' hides a field. |
56
|
|
Method 'getIdAsInt' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
Parameter connection should be final. |
70
|
|
Parameter keyInfo should be final. |
70
|
|
Method 'getIdAsLong' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
Parameter connection should be final. |
84
|
|
Parameter keyInfo should be final. |
84
|
|
Method 'getIdAsBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
Parameter connection should be final. |
98
|
|
Parameter keyInfo should be final. |
98
|
|
Method 'getIdAsString' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
Parameter connection should be final. |
112
|
|
Parameter keyInfo should be final. |
112
|
|
Method 'isPriorToInsert' is not designed for extension - needs to be abstract, final or empty. |
123
|
|
Method 'isPostInsert' is not designed for extension - needs to be abstract, final or empty. |
133
|
|
Method 'isConnectionRequired' is not designed for extension - needs to be abstract, final or empty. |
144
|
|
Parameter connection should be final. |
157
|
|
Parameter keyInfo should be final. |
157
|
|
Line is longer than 80 characters. |
160
|
org/apache/torque/om/BaseObject.java
Error |
Line |
|
Name 'isNew' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
|
Name 'primaryKey' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
51
|
|
Name 'modified' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
60
|
|
Name 'log' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
63
|
|
Method 'getPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
Method 'isModified' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
Method 'isNew' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
Method 'setNew' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
Parameter b should be final. |
103
|
|
Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
115
|
|
Parameter primaryKey should be final. |
115
|
|
'primaryKey' hides a field. |
115
|
|
Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
127
|
|
Parameter primaryKey should be final. |
127
|
|
'primaryKey' hides a field. |
127
|
|
Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
Parameter primaryKey should be final. |
139
|
|
'primaryKey' hides a field. |
139
|
|
Method 'setModified' is not designed for extension - needs to be abstract, final or empty. |
149
|
|
Parameter m should be final. |
149
|
|
Method 'resetModified' is not designed for extension - needs to be abstract, final or empty. |
157
|
|
Method 'getByName' is not designed for extension - needs to be abstract, final or empty. |
170
|
|
Parameter field should be final. |
170
|
|
Method 'getByPeerName' is not designed for extension - needs to be abstract, final or empty. |
183
|
|
Parameter name should be final. |
183
|
|
Method 'getByPosition' is not designed for extension - needs to be abstract, final or empty. |
196
|
|
Parameter pos should be final. |
196
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
209
|
|
Parameter obj should be final. |
209
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
227
|
|
Parameter bo should be final. |
227
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
253
|
|
Method 'getLog' is not designed for extension - needs to be abstract, final or empty. |
269
|
|
Parameter dbName should be final. |
286
|
|
Parameter con should be final. |
291
|
org/apache/torque/om/ComboKey.java
Error |
Line |
|
Name 'key' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
43
|
|
Parameter keys should be final. |
59
|
|
Parameter keys should be final. |
70
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
Parameter keys should be final. |
80
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
Parameter keys should be final. |
91
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
147
|
|
Parameter keys should be final. |
147
|
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
157
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
169
|
|
Parameter keyObj should be final. |
169
|
|
Method 'looseEquals' is not designed for extension - needs to be abstract, final or empty. |
207
|
|
Parameter keyObj should be final. |
207
|
|
Method 'appendTo' is not designed for extension - needs to be abstract, final or empty. |
255
|
|
Parameter sb should be final. |
255
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
296
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
322
|
org/apache/torque/om/DateKey.java
Error |
Line |
|
Parameter key should be final. |
46
|
|
Redundant throws: 'NumberFormatException' is unchecked exception. |
46
|
|
Parameter key should be final. |
56
|
|
Parameter key should be final. |
66
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
Parameter key should be final. |
83
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
93
|
|
Parameter key should be final. |
93
|
|
Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
Definition of 'equals()' without corresponding definition of 'hashCode()'. |
123
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
123
|
|
Parameter keyObj should be final. |
123
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
150
|
|
Avoid inline conditionals. |
153
|
org/apache/torque/om/NumberKey.java
Error |
Line |
|
Parameter key should be final. |
46
|
|
Parameter key should be final. |
56
|
|
Parameter key should be final. |
66
|
|
Parameter key should be final. |
83
|
|
Parameter key should be final. |
93
|
|
Parameter key should be final. |
104
|
|
Parameter key should be final. |
115
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
134
|
|
Parameter key should be final. |
134
|
|
Redundant throws: 'NumberFormatException' is unchecked exception. |
134
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
144
|
|
Parameter key should be final. |
144
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
154
|
|
Parameter key should be final. |
154
|
|
Avoid inline conditionals. |
156
|
|
Method 'getBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
164
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
176
|
|
Parameter keyObj should be final. |
176
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
211
|
|
Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
227
|
|
Parameter o should be final. |
227
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
238
|
|
Method 'byteValue' is not designed for extension - needs to be abstract, final or empty. |
254
|
|
Method 'intValue' is not designed for extension - needs to be abstract, final or empty. |
271
|
|
Method 'shortValue' is not designed for extension - needs to be abstract, final or empty. |
288
|
|
Method 'longValue' is not designed for extension - needs to be abstract, final or empty. |
300
|
|
Method 'floatValue' is not designed for extension - needs to be abstract, final or empty. |
315
|
|
Method 'doubleValue' is not designed for extension - needs to be abstract, final or empty. |
330
|
org/apache/torque/om/ObjectKey.java
Error |
Line |
|
Line does not match expected header line of ' * Copyright 2001-2004 The Apache Software Foundation.'. |
4
|
|
Line has trailing spaces. |
5
|
|
Line has trailing spaces. |
9
|
|
Line has trailing spaces. |
11
|
|
Name 'key' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
36
|
|
Variable 'key' must be private and have accessor methods. |
36
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
Method 'appendTo' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
Parameter sb should be final. |
76
|
|
Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
Parameter obj should be final. |
87
|
|
Parameter s should be final. |
98
|
org/apache/torque/om/SimpleKey.java
Error |
Line |
|
Line has trailing spaces. |
21
|
|
Line has trailing spaces. |
33
|
|
Parameter key should be final. |
34
|
|
Line has trailing spaces. |
43
|
|
Parameter key should be final. |
44
|
|
Line has trailing spaces. |
53
|
|
Parameter key should be final. |
54
|
|
Line has trailing spaces. |
63
|
|
Parameter key should be final. |
64
|
|
Line has trailing spaces. |
73
|
|
Parameter key should be final. |
74
|
|
Line has trailing spaces. |
83
|
|
Parameter key should be final. |
84
|
|
Line has trailing spaces. |
93
|
|
Parameter key should be final. |
94
|
|
Line has trailing spaces. |
103
|
|
Parameter key should be final. |
104
|
|
Line has trailing spaces. |
113
|
|
Parameter key should be final. |
114
|
|
Line has trailing spaces. |
123
|
|
Parameter key should be final. |
124
|
org/apache/torque/om/StringKey.java
Error |
Line |
|
Parameter key should be final. |
43
|
|
Parameter key should be final. |
53
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
Parameter key should be final. |
70
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
Parameter key should be final. |
80
|
|
Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
Definition of 'equals()' without corresponding definition of 'hashCode()'. |
110
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
Parameter keyObj should be final. |
110
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
136
|
org/apache/torque/package.html
Error |
Line |
|
Missing package documentation file. |
0 |
org/apache/torque/util/BasePeer.java
Error |
Line |
|
Line has trailing spaces. |
73
|
|
Utility classes should not have a public or default constructor. |
73
|
|
'5' is a magic number. |
89
|
|
Variable 'log' must be private and have accessor methods. |
92
|
|
Missing a Javadoc comment. |
94
|
|
Parameter e should be final. |
94
|
|
Line has trailing spaces. |
97
|
|
Line has trailing spaces. |
101
|
|
Parameter tableName should be final. |
114
|
|
Parameter tableName should be final. |
128
|
|
Parameter dbName should be final. |
128
|
|
Parameter schema should be final. |
159
|
|
Parameter columns should be final. |
186
|
|
Parameter tableName should be final. |
205
|
|
Parameter columnNames should be final. |
206
|
|
Parameter con should be final. |
229
|
|
Parameter table should be final. |
230
|
|
Parameter column should be final. |
231
|
|
Parameter value should be final. |
232
|
|
Must have at least one statement. |
263
|
|
Parameter table should be final. |
281
|
|
Parameter column should be final. |
281
|
|
Parameter value should be final. |
281
|
|
Parameter criteria should be final. |
305
|
|
Parameter criteria should be final. |
331
|
|
Parameter con should be final. |
331
|
|
Line has trailing spaces. |
338
|
|
Parameter tables should be final. |
343
|
|
Parameter key should be final. |
343
|
|
Parameter crit should be final. |
343
|
|
Line is longer than 80 characters. |
360
|
|
Line is longer than 80 characters. |
363
|
|
Parameter table should be final. |
377
|
|
Parameter dbName should be final. |
377
|
|
Parameter rec should be final. |
377
|
|
Parameter criteria should be final. |
415
|
|
Parameter criteria should be final. |
462
|
|
Parameter con should be final. |
462
|
|
Line has trailing spaces. |
502
|
|
Line is longer than 80 characters. |
515
|
|
Line is longer than 80 characters. |
548
|
|
Parameter pk should be final. |
548
|
|
Parameter keyGen should be final. |
548
|
|
Parameter con should be final. |
548
|
|
Parameter keyInfo should be final. |
548
|
|
Parameter rec should be final. |
586
|
|
Parameter table should be final. |
587
|
|
Parameter dbName should be final. |
588
|
|
Expected @param tag for 'dbName'. |
588
|
|
Parameter criteria should be final. |
589
|
|
Parameter criteria should be final. |
643
|
|
Parameter criteria should be final. |
657
|
|
Parameter criteria should be final. |
673
|
|
Line is longer than 80 characters. |
676
|
|
Parameter criterion should be final. |
677
|
|
Parameter params should be final. |
677
|
|
Parameter criteria should be final. |
692
|
|
Parameter criteria should be final. |
722
|
|
Parameter con should be final. |
722
|
|
Parameter queryString should be final. |
758
|
|
Parameter queryString should be final. |
774
|
|
Parameter dbName should be final. |
774
|
|
Parameter queryString should be final. |
792
|
|
Parameter dbName should be final. |
793
|
|
Parameter singleRecord should be final. |
794
|
|
Parameter queryString should be final. |
812
|
|
Parameter singleRecord should be final. |
813
|
|
Parameter con should be final. |
814
|
|
Parameter queryString should be final. |
834
|
|
Parameter start should be final. |
835
|
|
Parameter numberOfResults should be final. |
836
|
|
Parameter dbName should be final. |
837
|
|
Parameter singleRecord should be final. |
838
|
|
Parameter queryString should be final. |
875
|
|
Parameter start should be final. |
876
|
|
Parameter numberOfResults should be final. |
877
|
|
Parameter singleRecord should be final. |
878
|
|
Parameter con should be final. |
879
|
|
Line has trailing spaces. |
891
|
|
Parameter qds should be final. |
918
|
|
Parameter qds should be final. |
935
|
|
Parameter singleRecord should be final. |
935
|
|
Expected @param tag for 'singleRecord'. |
935
|
|
Parameter qds should be final. |
955
|
|
Parameter numberOfResults should be final. |
956
|
|
Expected @param tag for 'numberOfResults'. |
956
|
|
Parameter singleRecord should be final. |
957
|
|
Expected @param tag for 'singleRecord'. |
957
|
|
Parameter qds should be final. |
985
|
|
Parameter start should be final. |
986
|
|
Parameter numberOfResults should be final. |
987
|
|
Parameter singleRecord should be final. |
988
|
|
Parameter criteria should be final. |
1041
|
|
Parameter updateValues should be final. |
1094
|
|
Parameter updateValues should be final. |
1131
|
|
Parameter con should be final. |
1131
|
|
Parameter selectCriteria should be final. |
1167
|
|
Parameter updateValues should be final. |
1167
|
|
Parameter criteria should be final. |
1204
|
|
Parameter con should be final. |
1206
|
|
Line is longer than 80 characters. |
1218
|
|
Parameter table should be final. |
1218
|
|
Parameter dbName should be final. |
1218
|
|
Parameter rec should be final. |
1218
|
|
Line is longer than 80 characters. |
1221
|
|
Line is longer than 80 characters. |
1222
|
|
Line is longer than 80 characters. |
1242
|
|
Parameter statementString should be final. |
1242
|
|
Parameter statementString should be final. |
1258
|
|
Parameter dbName should be final. |
1258
|
|
Parameter statementString should be final. |
1286
|
|
Parameter con should be final. |
1286
|
|
Parameter ds should be final. |
1327
|
|
Parameter name should be final. |
1344
|
|
Line has trailing spaces. |
1387
|
|
Parameter criteria should be final. |
1403
|
|
Expected @param tag for 'criteria'. |
1403
|
|
Parameter con should be final. |
1403
|
|
Expected @param tag for 'con'. |
1403
|
|
Parameter criteria should be final. |
1476
|
|
Expected @param tag for 'criteria'. |
1476
|
|
Parameter criteria should be final. |
1503
|
|
Expected @param tag for 'criteria'. |
1503
|
|
Parameter queryString should be final. |
1504
|
|
Expected @param tag for 'queryString'. |
1504
|
|
Parameter params should be final. |
1505
|
|
Expected @param tag for 'params'. |
1505
|
|
Line is longer than 80 characters. |
1508
|
|
Parameter criterion should be final. |
1509
|
|
Parameter params should be final. |
1509
|
|
Line has trailing spaces. |
1524
|
|
Line is longer than 80 characters. |
1528
|
|
Line is longer than 80 characters. |
1535
|
|
Line is longer than 80 characters. |
1537
|
|
Parameter crit should be final. |
1537
|
|
Parameter tables should be final. |
1537
|
|
Parameter con should be final. |
1537
|
|
Parameter pc should be final. |
1537
|
|
';' is followed by whitespace. |
1545
|
|
Line is longer than 80 characters. |
1595
|
|
Line has trailing spaces. |
1627
|
|
Line has trailing spaces. |
1629
|
|
Missing a Javadoc comment. |
1634
|
org/apache/torque/util/CountHelper.java
Error |
Line |
|
Line is longer than 80 characters. |
24
|
|
Line has trailing spaces. |
36
|
|
Missing a Javadoc comment. |
36
|
|
Line has trailing spaces. |
37
|
|
Line has trailing spaces. |
39
|
|
Line has trailing spaces. |
40
|
|
Line has trailing spaces. |
45
|
|
Method 'count' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
'(' is followed by whitespace. |
50
|
|
Parameter c should be final. |
50
|
|
')' is preceded with whitespace. |
50
|
|
'(' is followed by whitespace. |
52
|
|
')' is preceded with whitespace. |
52
|
|
Line has trailing spaces. |
56
|
|
Line has trailing spaces. |
61
|
|
Line has trailing spaces. |
66
|
|
Method 'count' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
'(' is followed by whitespace. |
67
|
|
Parameter c should be final. |
67
|
|
Parameter conn should be final. |
67
|
|
')' is preceded with whitespace. |
67
|
|
Line has trailing spaces. |
69
|
|
'(' is followed by whitespace. |
69
|
|
')' is preceded with whitespace. |
69
|
|
Line has trailing spaces. |
74
|
|
Line has trailing spaces. |
81
|
|
Method 'count' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
'(' is followed by whitespace. |
81
|
|
Parameter c should be final. |
81
|
|
Parameter columnName should be final. |
81
|
|
')' is preceded with whitespace. |
81
|
|
'(' is followed by whitespace. |
84
|
|
')' is preceded with whitespace. |
84
|
|
Line has trailing spaces. |
88
|
|
Line has trailing spaces. |
89
|
|
Line has trailing spaces. |
97
|
|
Method 'count' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
'(' is followed by whitespace. |
97
|
|
Parameter c should be final. |
97
|
|
Parameter conn should be final. |
97
|
|
Parameter columnName should be final. |
97
|
|
')' is preceded with whitespace. |
97
|
|
Line has trailing spaces. |
99
|
|
Line has trailing spaces. |
109
|
|
'if' is not followed by whitespace. |
109
|
|
'(' is followed by whitespace. |
109
|
|
'&&' should be on a new line. |
109
|
|
Line has trailing spaces. |
110
|
|
'&&' should be on a new line. |
110
|
|
'(' is followed by whitespace. |
111
|
|
')' is preceded with whitespace. |
111
|
|
')' is preceded with whitespace. |
111
|
|
Line contains a tab character. |
112
|
|
'(' is followed by whitespace. |
113
|
|
')' is preceded with whitespace. |
113
|
|
'(' is followed by whitespace. |
117
|
|
')' is preceded with whitespace. |
117
|
|
'(' is followed by whitespace. |
118
|
|
Expression can be simplified. |
118
|
|
Avoid inline conditionals. |
118
|
|
')' is preceded with whitespace. |
118
|
|
'(' is followed by whitespace. |
119
|
|
')' is preceded with whitespace. |
119
|
|
'(' is followed by whitespace. |
120
|
|
')' is preceded with whitespace. |
120
|
|
'(' is followed by whitespace. |
122
|
|
')' is preceded with whitespace. |
122
|
|
'if' is not followed by whitespace. |
125
|
|
'(' is followed by whitespace. |
125
|
|
')' is preceded with whitespace. |
125
|
|
'(' is followed by whitespace. |
127
|
|
')' is preceded with whitespace. |
127
|
|
Line contains a tab character. |
130
|
|
'(' is followed by whitespace. |
131
|
|
')' is preceded with whitespace. |
131
|
|
Line has trailing spaces. |
132
|
|
'{' should be on a new line. |
134
|
|
'{' should be on a new line. |
137
|
org/apache/torque/util/Criteria.java
Error |
Line |
|
File length is 3,679 lines (max allowed is 2,000). |
1
|
|
Line has trailing spaces. |
136
|
|
Line has trailing spaces. |
139
|
|
Missing a Javadoc comment. |
140
|
|
Missing a Javadoc comment. |
142
|
|
Name 'ignoreCase' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
142
|
|
Missing a Javadoc comment. |
143
|
|
Name 'singleRecord' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
143
|
|
Missing a Javadoc comment. |
144
|
|
Name 'cascade' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
144
|
|
Missing a Javadoc comment. |
145
|
|
Name 'selectModifiers' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
145
|
|
Missing a Javadoc comment. |
146
|
|
Name 'selectColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
146
|
|
Missing a Javadoc comment. |
147
|
|
Name 'orderByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
147
|
|
Missing a Javadoc comment. |
148
|
|
Name 'groupByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
148
|
|
Missing a Javadoc comment. |
149
|
|
Name 'having' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
149
|
|
Missing a Javadoc comment. |
150
|
|
Name 'asColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
150
|
|
Missing a Javadoc comment. |
151
|
|
Name 'joins' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
151
|
|
Name 'dbName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
154
|
|
Name 'originalDbName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
157
|
|
Name 'limit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
163
|
|
Name 'offset' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
166
|
|
Missing a Javadoc comment. |
168
|
|
Name 'aliases' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
168
|
|
Missing a Javadoc comment. |
170
|
|
Name 'useTransaction' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
170
|
|
Parameter initialCapacity should be final. |
188
|
|
Parameter dbName should be final. |
199
|
|
'dbName' hides a field. |
199
|
|
Parameter dbName should be final. |
211
|
|
'dbName' hides a field. |
211
|
|
Parameter initialCapacity should be final. |
211
|
|
Method 'clear' is not designed for extension - needs to be abstract, final or empty. |
223
|
|
Line is longer than 80 characters. |
249
|
|
Method 'addAsColumn' is not designed for extension - needs to be abstract, final or empty. |
260
|
|
Parameter name should be final. |
260
|
|
Parameter clause should be final. |
260
|
|
Method 'getAsColumns' is not designed for extension - needs to be abstract, final or empty. |
272
|
|
Method 'addAlias' is not designed for extension - needs to be abstract, final or empty. |
284
|
|
Parameter alias should be final. |
284
|
|
Parameter table should be final. |
284
|
|
'8' is a magic number. |
288
|
|
Method 'getTableForAlias' is not designed for extension - needs to be abstract, final or empty. |
299
|
|
Parameter alias should be final. |
299
|
|
Method 'containsKey' is not designed for extension - needs to be abstract, final or empty. |
315
|
|
Parameter table should be final. |
315
|
|
Parameter column should be final. |
315
|
|
Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
326
|
|
Parameter column should be final. |
326
|
|
Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
338
|
|
Parameter table should be final. |
338
|
|
Parameter column should be final. |
338
|
|
Method 'setUseTransaction' is not designed for extension - needs to be abstract, final or empty. |
351
|
|
Parameter v should be final. |
351
|
|
Expected @param tag for 'v'. |
351
|
|
Method 'isUseTransaction' is not designed for extension - needs to be abstract, final or empty. |
362
|
|
Method 'getCriterion' is not designed for extension - needs to be abstract, final or empty. |
373
|
|
Parameter column should be final. |
373
|
|
Method 'getCriterion' is not designed for extension - needs to be abstract, final or empty. |
385
|
|
Parameter table should be final. |
385
|
|
Parameter column should be final. |
385
|
|
Method 'getNewCriterion' is not designed for extension - needs to be abstract, final or empty. |
401
|
|
Parameter column should be final. |
401
|
|
Parameter value should be final. |
401
|
|
Expected @param tag for 'value'. |
401
|
|
Parameter comparison should be final. |
402
|
|
Expected @param tag for 'comparison'. |
402
|
|
Method 'getNewCriterion' is not designed for extension - needs to be abstract, final or empty. |
416
|
|
Parameter table should be final. |
416
|
|
Parameter column should be final. |
416
|
|
Parameter value should be final. |
417
|
|
Expected @param tag for 'value'. |
417
|
|
Parameter comparison should be final. |
417
|
|
Expected @param tag for 'comparison'. |
417
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
440
|
|
Parameter c should be final. |
440
|
|
Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
457
|
|
Parameter name should be final. |
457
|
|
Method 'getComparison' is not designed for extension - needs to be abstract, final or empty. |
468
|
|
Parameter key should be final. |
468
|
|
Method 'getComparison' is not designed for extension - needs to be abstract, final or empty. |
480
|
|
Parameter table should be final. |
480
|
|
Parameter column should be final. |
480
|
|
Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
494
|
|
Parameter name should be final. |
494
|
|
Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
506
|
|
Parameter table should be final. |
506
|
|
Parameter column should be final. |
506
|
|
Method 'getDbName' is not designed for extension - needs to be abstract, final or empty. |
520
|
|
Method 'setDbName' is not designed for extension - needs to be abstract, final or empty. |
531
|
|
Parameter dbName should be final. |
531
|
|
'dbName' hides a field. |
531
|
|
Avoid inline conditionals. |
533
|
|
Method 'getDouble' is not designed for extension - needs to be abstract, final or empty. |
542
|
|
Parameter name should be final. |
542
|
|
Method 'getDouble' is not designed for extension - needs to be abstract, final or empty. |
559
|
|
Parameter table should be final. |
559
|
|
Parameter column should be final. |
559
|
|
Method 'getFloat' is not designed for extension - needs to be abstract, final or empty. |
572
|
|
Parameter name should be final. |
572
|
|
Method 'getFloat' is not designed for extension - needs to be abstract, final or empty. |
589
|
|
Parameter table should be final. |
589
|
|
Parameter column should be final. |
589
|
|
Method 'getInteger' is not designed for extension - needs to be abstract, final or empty. |
602
|
|
Parameter name should be final. |
602
|
|
Method 'getInteger' is not designed for extension - needs to be abstract, final or empty. |
619
|
|
Parameter table should be final. |
619
|
|
Parameter column should be final. |
619
|
|
Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
633
|
|
Parameter name should be final. |
633
|
|
Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
650
|
|
Parameter table should be final. |
650
|
|
Parameter column should be final. |
650
|
|
Method 'getBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
664
|
|
Parameter name should be final. |
664
|
|
Method 'getBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
681
|
|
Parameter table should be final. |
681
|
|
Parameter column should be final. |
681
|
|
Method 'getLong' is not designed for extension - needs to be abstract, final or empty. |
695
|
|
Parameter name should be final. |
695
|
|
Method 'getLong' is not designed for extension - needs to be abstract, final or empty. |
712
|
|
Parameter table should be final. |
712
|
|
Parameter column should be final. |
712
|
|
Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
726
|
|
Parameter name should be final. |
726
|
|
Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
738
|
|
Parameter table should be final. |
738
|
|
Parameter column should be final. |
738
|
|
Method 'getTableName' is not designed for extension - needs to be abstract, final or empty. |
752
|
|
Parameter name should be final. |
752
|
|
Method 'getList' is not designed for extension - needs to be abstract, final or empty. |
763
|
|
Parameter name should be final. |
763
|
|
Method 'getList' is not designed for extension - needs to be abstract, final or empty. |
775
|
|
Parameter table should be final. |
775
|
|
Parameter column should be final. |
775
|
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
789
|
|
Parameter name should be final. |
789
|
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
801
|
|
Parameter table should be final. |
801
|
|
Parameter column should be final. |
801
|
|
Method 'getObjectKey' is not designed for extension - needs to be abstract, final or empty. |
815
|
|
Parameter name should be final. |
815
|
|
Method 'getObjectKey' is not designed for extension - needs to be abstract, final or empty. |
827
|
|
Parameter table should be final. |
827
|
|
Parameter column should be final. |
827
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
842
|
|
Parameter key should be final. |
842
|
|
Unused @throws tag for 'NullPointerException'. |
859
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
862
|
|
Parameter key should be final. |
862
|
|
Parameter value should be final. |
862
|
|
Method 'putAll' is not designed for extension - needs to be abstract, final or empty. |
882
|
|
Parameter t should be final. |
882
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
944
|
|
Parameter column should be final. |
944
|
|
Parameter value should be final. |
944
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
974
|
|
Parameter column should be final. |
974
|
|
Parameter value should be final. |
974
|
|
Parameter comparison should be final. |
974
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1000
|
|
Parameter table should be final. |
1000
|
|
Parameter column should be final. |
1000
|
|
Parameter value should be final. |
1000
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1028
|
|
Parameter table should be final. |
1028
|
|
Parameter column should be final. |
1029
|
|
Parameter value should be final. |
1030
|
|
Parameter comparison should be final. |
1031
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1057
|
|
Parameter column should be final. |
1057
|
|
Parameter value should be final. |
1057
|
|
Avoid inline conditionals. |
1059
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1078
|
|
Parameter column should be final. |
1078
|
|
Parameter value should be final. |
1078
|
|
Parameter comparison should be final. |
1078
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1097
|
|
Parameter column should be final. |
1097
|
|
Parameter value should be final. |
1097
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1118
|
|
Parameter column should be final. |
1118
|
|
Parameter value should be final. |
1118
|
|
Parameter comparison should be final. |
1118
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1137
|
|
Parameter column should be final. |
1137
|
|
Parameter value should be final. |
1137
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1158
|
|
Parameter column should be final. |
1158
|
|
Parameter value should be final. |
1158
|
|
Parameter comparison should be final. |
1158
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1177
|
|
Parameter column should be final. |
1177
|
|
Parameter value should be final. |
1177
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1198
|
|
Parameter column should be final. |
1198
|
|
Parameter value should be final. |
1198
|
|
Parameter comparison should be final. |
1198
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1217
|
|
Parameter column should be final. |
1217
|
|
Parameter value should be final. |
1217
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1238
|
|
Parameter column should be final. |
1238
|
|
Parameter value should be final. |
1238
|
|
Parameter comparison should be final. |
1238
|
|
Method 'addDate' is not designed for extension - needs to be abstract, final or empty. |
1261
|
|
Parameter column should be final. |
1261
|
|
Parameter year should be final. |
1261
|
|
Parameter month should be final. |
1261
|
|
Parameter date should be final. |
1261
|
|
Method 'addDate' is not designed for extension - needs to be abstract, final or empty. |
1286
|
|
Parameter column should be final. |
1286
|
|
Parameter year should be final. |
1286
|
|
Parameter month should be final. |
1286
|
|
Parameter date should be final. |
1286
|
|
Parameter comparison should be final. |
1287
|
|
Method 'addJoin' is not designed for extension - needs to be abstract, final or empty. |
1309
|
|
Parameter left should be final. |
1309
|
|
Parameter right should be final. |
1309
|
|
Method 'addJoin' is not designed for extension - needs to be abstract, final or empty. |
1332
|
|
Parameter left should be final. |
1332
|
|
Parameter right should be final. |
1332
|
|
Parameter operator should be final. |
1332
|
|
'3' is a magic number. |
1336
|
|
',' is not followed by whitespace. |
1338
|
|
Line has trailing spaces. |
1339
|
|
Method 'getJoins' is not designed for extension - needs to be abstract, final or empty. |
1349
|
|
Expected an @return tag. |
1360
|
|
Method 'getJoinL' is not designed for extension - needs to be abstract, final or empty. |
1360
|
|
Line is longer than 80 characters. |
1362
|
|
Expected an @return tag. |
1371
|
|
Method 'getJoinR' is not designed for extension - needs to be abstract, final or empty. |
1371
|
|
Line is longer than 80 characters. |
1373
|
|
Method 'addIn' is not designed for extension - needs to be abstract, final or empty. |
1394
|
|
Parameter column should be final. |
1394
|
|
Parameter values should be final. |
1394
|
|
Method 'addIn' is not designed for extension - needs to be abstract, final or empty. |
1417
|
|
Parameter column should be final. |
1417
|
|
Parameter values should be final. |
1417
|
|
Method 'addIn' is not designed for extension - needs to be abstract, final or empty. |
1441
|
|
Parameter column should be final. |
1441
|
|
Parameter values should be final. |
1441
|
|
Method 'addNotIn' is not designed for extension - needs to be abstract, final or empty. |
1465
|
|
Parameter column should be final. |
1465
|
|
Parameter values should be final. |
1465
|
|
Method 'addNotIn' is not designed for extension - needs to be abstract, final or empty. |
1488
|
|
Parameter column should be final. |
1488
|
|
Parameter values should be final. |
1488
|
|
Method 'addNotIn' is not designed for extension - needs to be abstract, final or empty. |
1512
|
|
Parameter column should be final. |
1512
|
|
Parameter values should be final. |
1512
|
|
Method 'setAll' is not designed for extension - needs to be abstract, final or empty. |
1521
|
|
Method 'setDistinct' is not designed for extension - needs to be abstract, final or empty. |
1529
|
|
Method 'setIgnoreCase' is not designed for extension - needs to be abstract, final or empty. |
1540
|
|
Parameter b should be final. |
1540
|
|
Method 'isIgnoreCase' is not designed for extension - needs to be abstract, final or empty. |
1551
|
|
Method 'setSingleRecord' is not designed for extension - needs to be abstract, final or empty. |
1569
|
|
Parameter b should be final. |
1569
|
|
Method 'isSingleRecord' is not designed for extension - needs to be abstract, final or empty. |
1580
|
|
Method 'setCascade' is not designed for extension - needs to be abstract, final or empty. |
1591
|
|
Parameter b should be final. |
1591
|
|
Method 'isCascade' is not designed for extension - needs to be abstract, final or empty. |
1602
|
|
Method 'setLimit' is not designed for extension - needs to be abstract, final or empty. |
1613
|
|
Parameter limit should be final. |
1613
|
|
'limit' hides a field. |
1613
|
|
Method 'getLimit' is not designed for extension - needs to be abstract, final or empty. |
1624
|
|
Method 'setOffset' is not designed for extension - needs to be abstract, final or empty. |
1635
|
|
Parameter offset should be final. |
1635
|
|
'offset' hides a field. |
1635
|
|
Method 'getOffset' is not designed for extension - needs to be abstract, final or empty. |
1646
|
|
Method 'addSelectColumn' is not designed for extension - needs to be abstract, final or empty. |
1657
|
|
Parameter name should be final. |
1657
|
|
Method 'getSelectColumns' is not designed for extension - needs to be abstract, final or empty. |
1669
|
|
Method 'getSelectModifiers' is not designed for extension - needs to be abstract, final or empty. |
1679
|
|
Method 'addGroupByColumn' is not designed for extension - needs to be abstract, final or empty. |
1690
|
|
Parameter groupBy should be final. |
1690
|
|
Method 'addAscendingOrderByColumn' is not designed for extension - needs to be abstract, final or empty. |
1702
|
|
Parameter name should be final. |
1702
|
|
Method 'addDescendingOrderByColumn' is not designed for extension - needs to be abstract, final or empty. |
1714
|
|
Parameter name should be final. |
1714
|
|
Method 'getOrderByColumns' is not designed for extension - needs to be abstract, final or empty. |
1725
|
|
Method 'getGroupByColumns' is not designed for extension - needs to be abstract, final or empty. |
1735
|
|
Method 'getHaving' is not designed for extension - needs to be abstract, final or empty. |
1745
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
1756
|
|
Parameter key should be final. |
1756
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
1771
|
|
Line is longer than 80 characters. |
1784
|
|
Must have at least one statement. |
1788
|
|
Expected an @return tag. |
1798
|
|
Definition of 'equals()' without corresponding definition of 'hashCode()'. |
1798
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
1798
|
|
Parameter crit should be final. |
1798
|
|
Expected @param tag for 'crit'. |
1798
|
|
Method 'addHaving' is not designed for extension - needs to be abstract, final or empty. |
1872
|
|
Parameter having should be final. |
1872
|
|
'having' hides a field. |
1872
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1896
|
|
Parameter c should be final. |
1896
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1933
|
|
Parameter column should be final. |
1933
|
|
Parameter value should be final. |
1933
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1963
|
|
Parameter column should be final. |
1963
|
|
Parameter value should be final. |
1963
|
|
Parameter comparison should be final. |
1963
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1998
|
|
Parameter table should be final. |
1998
|
|
Parameter column should be final. |
1998
|
|
Parameter value should be final. |
1998
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2026
|
|
Parameter table should be final. |
2026
|
|
Parameter column should be final. |
2026
|
|
Parameter value should be final. |
2026
|
|
Parameter comparison should be final. |
2027
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2062
|
|
Parameter column should be final. |
2062
|
|
Parameter value should be final. |
2062
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2083
|
|
Parameter column should be final. |
2083
|
|
Parameter value should be final. |
2083
|
|
Parameter comparison should be final. |
2083
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2102
|
|
Parameter column should be final. |
2102
|
|
Parameter value should be final. |
2102
|
|
Line is longer than 80 characters. |
2119
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2122
|
|
Parameter column should be final. |
2122
|
|
Parameter value should be final. |
2122
|
|
Parameter comparison should be final. |
2122
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2141
|
|
Parameter column should be final. |
2141
|
|
Parameter value should be final. |
2141
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2162
|
|
Parameter column should be final. |
2162
|
|
Parameter value should be final. |
2162
|
|
Parameter comparison should be final. |
2162
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2181
|
|
Parameter column should be final. |
2181
|
|
Parameter value should be final. |
2181
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2202
|
|
Parameter column should be final. |
2202
|
|
Parameter value should be final. |
2202
|
|
Parameter comparison should be final. |
2202
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2221
|
|
Parameter column should be final. |
2221
|
|
Parameter value should be final. |
2221
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2242
|
|
Parameter column should be final. |
2242
|
|
Parameter value should be final. |
2242
|
|
Parameter comparison should be final. |
2242
|
|
Method 'andDate' is not designed for extension - needs to be abstract, final or empty. |
2264
|
|
Parameter column should be final. |
2264
|
|
Parameter year should be final. |
2264
|
|
Parameter month should be final. |
2264
|
|
Parameter date should be final. |
2264
|
|
Method 'andDate' is not designed for extension - needs to be abstract, final or empty. |
2288
|
|
Parameter column should be final. |
2288
|
|
Parameter year should be final. |
2288
|
|
Parameter month should be final. |
2288
|
|
Parameter date should be final. |
2288
|
|
Parameter comparison should be final. |
2289
|
|
Method 'andIn' is not designed for extension - needs to be abstract, final or empty. |
2313
|
|
Parameter column should be final. |
2313
|
|
Parameter values should be final. |
2313
|
|
Method 'andIn' is not designed for extension - needs to be abstract, final or empty. |
2336
|
|
Parameter column should be final. |
2336
|
|
Parameter values should be final. |
2336
|
|
Method 'andIn' is not designed for extension - needs to be abstract, final or empty. |
2360
|
|
Parameter column should be final. |
2360
|
|
Parameter values should be final. |
2360
|
|
Method 'andNotIn' is not designed for extension - needs to be abstract, final or empty. |
2384
|
|
Parameter column should be final. |
2384
|
|
Parameter values should be final. |
2384
|
|
Method 'andNotIn' is not designed for extension - needs to be abstract, final or empty. |
2407
|
|
Parameter column should be final. |
2407
|
|
Parameter values should be final. |
2407
|
|
Method 'andNotIn' is not designed for extension - needs to be abstract, final or empty. |
2431
|
|
Parameter column should be final. |
2431
|
|
Parameter values should be final. |
2431
|
|
Line is longer than 80 characters. |
2455
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2462
|
|
Parameter c should be final. |
2462
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2499
|
|
Parameter column should be final. |
2499
|
|
Parameter value should be final. |
2499
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2528
|
|
Parameter column should be final. |
2528
|
|
Parameter value should be final. |
2528
|
|
Parameter comparison should be final. |
2528
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2563
|
|
Parameter table should be final. |
2563
|
|
Parameter column should be final. |
2563
|
|
Parameter value should be final. |
2563
|
|
Line is longer than 80 characters. |
2587
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2590
|
|
Parameter table should be final. |
2590
|
|
Parameter column should be final. |
2590
|
|
Parameter value should be final. |
2590
|
|
Parameter comparison should be final. |
2591
|
|
Line is longer than 80 characters. |
2593
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2624
|
|
Parameter column should be final. |
2624
|
|
Parameter value should be final. |
2624
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2645
|
|
Parameter column should be final. |
2645
|
|
Parameter value should be final. |
2645
|
|
Parameter comparison should be final. |
2645
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2665
|
|
Parameter column should be final. |
2665
|
|
Parameter value should be final. |
2665
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2687
|
|
Parameter column should be final. |
2687
|
|
Parameter value should be final. |
2687
|
|
Parameter comparison should be final. |
2687
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2706
|
|
Parameter column should be final. |
2706
|
|
Parameter value should be final. |
2706
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2727
|
|
Parameter column should be final. |
2727
|
|
Parameter value should be final. |
2727
|
|
Parameter comparison should be final. |
2727
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2746
|
|
Parameter column should be final. |
2746
|
|
Parameter value should be final. |
2746
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2767
|
|
Parameter column should be final. |
2767
|
|
Parameter value should be final. |
2767
|
|
Parameter comparison should be final. |
2767
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2786
|
|
Parameter column should be final. |
2786
|
|
Parameter value should be final. |
2786
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2807
|
|
Parameter column should be final. |
2807
|
|
Parameter value should be final. |
2807
|
|
Parameter comparison should be final. |
2807
|
|
Method 'orDate' is not designed for extension - needs to be abstract, final or empty. |
2829
|
|
Parameter column should be final. |
2829
|
|
Parameter year should be final. |
2829
|
|
Parameter month should be final. |
2829
|
|
Parameter date should be final. |
2829
|
|
Method 'orDate' is not designed for extension - needs to be abstract, final or empty. |
2853
|
|
Parameter column should be final. |
2853
|
|
Parameter year should be final. |
2853
|
|
Parameter month should be final. |
2853
|
|
Parameter date should be final. |
2853
|
|
Parameter comparison should be final. |
2854
|
|
Method 'orIn' is not designed for extension - needs to be abstract, final or empty. |
2878
|
|
Parameter column should be final. |
2878
|
|
Parameter values should be final. |
2878
|
|
Method 'orIn' is not designed for extension - needs to be abstract, final or empty. |
2901
|
|
Parameter column should be final. |
2901
|
|
Parameter values should be final. |
2901
|
|
Method 'orIn' is not designed for extension - needs to be abstract, final or empty. |
2925
|
|
Parameter column should be final. |
2925
|
|
Parameter values should be final. |
2925
|
|
Method 'orNotIn' is not designed for extension - needs to be abstract, final or empty. |
2949
|
|
Parameter column should be final. |
2949
|
|
Parameter values should be final. |
2949
|
|
Method 'orNotIn' is not designed for extension - needs to be abstract, final or empty. |
2972
|
|
Parameter column should be final. |
2972
|
|
Parameter values should be final. |
2972
|
|
Method 'orNotIn' is not designed for extension - needs to be abstract, final or empty. |
2996
|
|
Parameter column should be final. |
2996
|
|
Parameter values should be final. |
2996
|
|
Missing a Javadoc comment. |
3008
|
|
Missing a Javadoc comment. |
3009
|
|
Name 'value' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3012
|
|
Name 'comparison' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3015
|
|
Name 'table' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3018
|
|
Name 'column' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3021
|
|
Name 'ignoreStringCase' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3024
|
|
Name 'db' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3030
|
|
Name 'clauses' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3035
|
|
Missing a Javadoc comment. |
3036
|
|
Name 'conjunctions' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3036
|
|
Parameter val should be final. |
3041
|
|
Expected @param tag for 'val'. |
3041
|
|
Parameter comp should be final. |
3041
|
|
Expected @param tag for 'comp'. |
3041
|
|
Parameter table should be final. |
3055
|
|
'table' hides a field. |
3055
|
|
Parameter column should be final. |
3055
|
|
'column' hides a field. |
3055
|
|
Parameter val should be final. |
3055
|
|
Parameter comp should be final. |
3055
|
|
Avoid inline conditionals. |
3058
|
|
Avoid inline conditionals. |
3059
|
|
Parameter tableColumn should be final. |
3070
|
|
Parameter val should be final. |
3070
|
|
Parameter comp should be final. |
3070
|
|
Parameter table should be final. |
3093
|
|
'table' hides a field. |
3093
|
|
Parameter column should be final. |
3093
|
|
'column' hides a field. |
3093
|
|
Parameter val should be final. |
3093
|
|
Parameter tableColumn should be final. |
3105
|
|
Parameter val should be final. |
3105
|
|
Parameter name should be final. |
3125
|
|
'db' hides a field. |
3168
|
|
Parameter v should be final. |
3199
|
|
Parameter b should be final. |
3215
|
|
Expected an @return tag. |
3234
|
|
Expected an @return tag. |
3242
|
|
Expected an @return tag. |
3250
|
|
Parameter criterion should be final. |
3250
|
|
Expected @param tag for 'criterion'. |
3250
|
|
Expected an @return tag. |
3260
|
|
Parameter criterion should be final. |
3260
|
|
Expected @param tag for 'criterion'. |
3260
|
|
Parameter sb should be final. |
3270
|
|
Expected @param tag for 'sb'. |
3270
|
|
Parameter sb should be final. |
3328
|
|
Parameter params should be final. |
3328
|
|
'db' hides a field. |
3335
|
|
Line is longer than 80 characters. |
3387
|
|
Line is longer than 80 characters. |
3413
|
|
'25' is a magic number. |
3446
|
|
Expected an @return tag. |
3455
|
|
Parameter obj should be final. |
3455
|
|
Expected @param tag for 'obj'. |
3455
|
|
Expected an @return tag. |
3510
|
|
Parameter c should be final. |
3548
|
|
Expected @param tag for 'c'. |
3548
|
|
Parameter s should be final. |
3548
|
|
Expected @param tag for 's'. |
3548
|
|
Expected an @return tag. |
3564
|
|
Parameter c should be final. |
3581
|
|
Expected @param tag for 'c'. |
3581
|
|
Parameter a should be final. |
3581
|
|
Expected @param tag for 'a'. |
3581
|
|
Line has trailing spaces. |
3593
|
|
Line has trailing spaces. |
3599
|
|
Name 'leftColumn' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3605
|
|
Line has trailing spaces. |
3606
|
|
Name 'rightColumn' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3608
|
|
Line has trailing spaces. |
3609
|
|
Name 'joinType' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3611
|
|
Line has trailing spaces. |
3612
|
|
Line has trailing spaces. |
3615
|
|
Line has trailing spaces. |
3619
|
|
Line has trailing spaces. |
3624
|
|
'leftColumn' hides a field. |
3624
|
|
Line has trailing spaces. |
3625
|
|
'rightColumn' hides a field. |
3625
|
|
'joinType' hides a field. |
3626
|
|
Line has trailing spaces. |
3632
|
|
Line has trailing spaces. |
3634
|
|
Line has trailing spaces. |
3637
|
|
Line has trailing spaces. |
3641
|
|
Line has trailing spaces. |
3645
|
|
Line has trailing spaces. |
3649
|
|
Line has trailing spaces. |
3653
|
|
Line has trailing spaces. |
3657
|
|
Line has trailing spaces. |
3663
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
3663
|
org/apache/torque/util/JoinBuilder.java
Error |
Line |
|
Utility classes should not have a public or default constructor. |
35
|
|
Line has trailing spaces. |
42
|
|
Line has trailing spaces. |
45
|
|
Expected @param tag for 'db'. |
45
|
|
Expected @param tag for 'dbMap'. |
46
|
|
Line has trailing spaces. |
66
|
|
Line is longer than 80 characters. |
70
|
|
Line is longer than 80 characters. |
74
|
|
Line has trailing spaces. |
76
|
|
Line has trailing spaces. |
77
|
|
Line has trailing spaces. |
79
|
|
Line has trailing spaces. |
83
|
|
Line is longer than 80 characters. |
84
|
|
Line has trailing spaces. |
88
|
|
Line has trailing spaces. |
97
|
|
Line has trailing spaces. |
106
|
|
Line has trailing spaces. |
109
|
|
Line has trailing spaces. |
113
|
|
Line has trailing spaces. |
116
|
|
Line has trailing spaces. |
119
|
|
Line has trailing spaces. |
120
|
|
Line has trailing spaces. |
122
|
|
Line has trailing spaces. |
128
|
|
Line has trailing spaces. |
129
|
|
Line has trailing spaces. |
131
|
|
Line has trailing spaces. |
145
|
|
Line has trailing spaces. |
147
|
|
Line has trailing spaces. |
148
|
|
Line has trailing spaces. |
151
|
|
Line has trailing spaces. |
154
|
|
Line has trailing spaces. |
159
|
|
Line has trailing spaces. |
164
|
|
Line has trailing spaces. |
171
|
|
Line has trailing spaces. |
172
|
|
Line has trailing spaces. |
174
|
|
Line has trailing spaces. |
178
|
|
Line has trailing spaces. |
179
|
|
Line has trailing spaces. |
180
|
|
Line has trailing spaces. |
190
|
|
Line has trailing spaces. |
205
|
|
Redundant 'final' modifier. |
209
|
|
Line has trailing spaces. |
210
|
|
Line has trailing spaces. |
212
|
|
Line has trailing spaces. |
216
|
|
Line has trailing spaces. |
217
|
org/apache/torque/util/LargeSelect.java
Error |
Line |
|
Name 'pageSize' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
139
|
|
Name 'memoryLimit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
141
|
|
Name 'blockBegin' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
144
|
|
Name 'blockEnd' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
146
|
|
Name 'currentlyFilledTo' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
148
|
|
Name 'query' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
151
|
|
Name 'dbName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
153
|
|
Name 'qds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
155
|
|
Name 'results' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
158
|
|
Name 'thread' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
161
|
|
Name 'killThread' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
166
|
|
Name 'threadRunning' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
168
|
|
Name 'queryCompleted' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
173
|
|
Name 'totalsFinalized' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
178
|
|
Name 'position' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
181
|
|
Name 'totalPages' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
183
|
|
Name 'totalRecords' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
185
|
|
Name 'currentPageNumber' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
187
|
|
Name 'criteria' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
190
|
|
Name 'lastResults' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
192
|
|
Name 'returnBuilderClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
198
|
|
Name 'populateObjectsMethod' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
203
|
|
Missing a Javadoc comment. |
212
|
|
Missing a Javadoc comment. |
221
|
|
Name 'params' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
224
|
|
Parameter criteria should be final. |
243
|
|
'criteria' hides a field. |
243
|
|
Parameter pageSize should be final. |
243
|
|
'pageSize' hides a field. |
243
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
244
|
|
Parameter criteria should be final. |
266
|
|
'criteria' hides a field. |
266
|
|
Parameter pageSize should be final. |
266
|
|
'pageSize' hides a field. |
266
|
|
Parameter memoryPageLimit should be final. |
266
|
|
'memoryPageLimit' hides a field. |
266
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
267
|
|
Parameter criteria should be final. |
297
|
|
'criteria' hides a field. |
297
|
|
Parameter pageSize should be final. |
298
|
|
'pageSize' hides a field. |
298
|
|
Parameter returnBuilderClassName should be final. |
299
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
300
|
|
Parameter criteria should be final. |
337
|
|
'criteria' hides a field. |
337
|
|
Parameter pageSize should be final. |
338
|
|
'pageSize' hides a field. |
338
|
|
Parameter memoryPageLimit should be final. |
339
|
|
'memoryPageLimit' hides a field. |
339
|
|
Parameter returnBuilderClassName should be final. |
340
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
341
|
|
'{' is followed by whitespace. |
350
|
|
'{' is followed by whitespace. |
353
|
|
'{' is followed by whitespace. |
359
|
|
Parameter criteria should be final. |
387
|
|
'criteria' hides a field. |
387
|
|
Parameter pageSize should be final. |
387
|
|
'pageSize' hides a field. |
387
|
|
Parameter memoryLimitPages should be final. |
387
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
388
|
|
Unused @throws tag for 'IllegalArgumentException'. |
424
|
|
Method 'getPage' is not designed for extension - needs to be abstract, final or empty. |
429
|
|
Parameter pageNumber should be final. |
429
|
|
Method 'getNextResults' is not designed for extension - needs to be abstract, final or empty. |
448
|
|
Method 'getCurrentPageResults' is not designed for extension - needs to be abstract, final or empty. |
464
|
|
Method 'getPreviousResults' is not designed for extension - needs to be abstract, final or empty. |
477
|
|
Parameter start should be final. |
507
|
|
Parameter start should be final. |
526
|
|
Parameter size should be final. |
526
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
527
|
|
'500' is a magic number. |
557
|
|
Line has trailing spaces. |
630
|
|
'{' is followed by whitespace. |
638
|
|
Method 'run' is not designed for extension - needs to be abstract, final or empty. |
659
|
|
Line has trailing spaces. |
714
|
|
Parameter initialSize should be final. |
811
|
|
'100' is a magic number. |
839
|
|
Method 'getCurrentPageNumber' is not designed for extension - needs to be abstract, final or empty. |
855
|
|
Method 'getTotalRecords' is not designed for extension - needs to be abstract, final or empty. |
870
|
|
Method 'getPaginated' is not designed for extension - needs to be abstract, final or empty. |
881
|
|
Method 'getTotalPages' is not designed for extension - needs to be abstract, final or empty. |
901
|
|
Avoid inline conditionals. |
910
|
|
Method 'getPageSize' is not designed for extension - needs to be abstract, final or empty. |
926
|
|
Method 'getTotalsFinalized' is not designed for extension - needs to be abstract, final or empty. |
938
|
|
Parameter moreIndicator should be final. |
949
|
|
'moreIndicator' hides a field. |
949
|
|
Expected an @return tag. |
957
|
|
Parameter memoryPageLimit should be final. |
970
|
|
'memoryPageLimit' hides a field. |
970
|
|
Expected an @return tag. |
980
|
|
Method 'getPageProgressText' is not designed for extension - needs to be abstract, final or empty. |
992
|
|
Method 'getCurrentPageSize' is not designed for extension - needs to be abstract, final or empty. |
1013
|
|
Method 'getFirstRecordNoForPage' is not designed for extension - needs to be abstract, final or empty. |
1027
|
|
Method 'getLastRecordNoForPage' is not designed for extension - needs to be abstract, final or empty. |
1041
|
|
Method 'getRecordProgressText' is not designed for extension - needs to be abstract, final or empty. |
1058
|
|
Method 'getNextResultsAvailable' is not designed for extension - needs to be abstract, final or empty. |
1079
|
|
Method 'getPreviousResultsAvailable' is not designed for extension - needs to be abstract, final or empty. |
1093
|
|
Method 'hasResultsAvailable' is not designed for extension - needs to be abstract, final or empty. |
1107
|
|
Method 'invalidateResult' is not designed for extension - needs to be abstract, final or empty. |
1119
|
|
Line has trailing spaces. |
1131
|
|
Method 'getSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1149
|
|
Parameter name should be final. |
1149
|
|
Method 'getSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1165
|
|
Parameter name should be final. |
1165
|
|
Parameter defaultValue should be final. |
1165
|
|
Avoid inline conditionals. |
1172
|
|
Line has trailing spaces. |
1176
|
|
Method 'setSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1182
|
|
Parameter name should be final. |
1182
|
|
Parameter value should be final. |
1182
|
|
Method 'removeSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1206
|
|
Parameter name should be final. |
1206
|
|
Line has trailing spaces. |
1216
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
1219
|
org/apache/torque/util/LimitHelper.java
Error |
Line |
|
Line does not match expected header line of '/*'. |
3
|
|
Utility classes should not have a public or default constructor. |
32
|
|
Unused @param tag for 'critera'. |
39
|
|
Parameter criteria should be final. |
42
|
|
Expected @param tag for 'criteria'. |
42
|
|
Parameter query should be final. |
42
|
|
Expected @throws tag for 'TorqueException'. |
43
|
|
Line has trailing spaces. |
54
|
|
Redundant 'final' modifier. |
90
|
|
Parameter query should be final. |
90
|
|
Parameter offset should be final. |
91
|
|
Parameter limit should be final. |
91
|
|
Line has trailing spaces. |
94
|
|
Redundant 'final' modifier. |
123
|
|
Parameter query should be final. |
123
|
|
Parameter offset should be final. |
124
|
|
Parameter limit should be final. |
124
|
|
Line has trailing spaces. |
159
|
|
Line has trailing spaces. |
163
|
|
Redundant 'final' modifier. |
164
|
|
Parameter query should be final. |
164
|
|
Parameter offset should be final. |
165
|
|
Parameter limit should be final. |
165
|
|
Line has trailing spaces. |
209
|
|
Line has trailing spaces. |
213
|
|
Redundant 'final' modifier. |
214
|
|
Parameter query should be final. |
214
|
|
Parameter offset should be final. |
215
|
|
Parameter limit should be final. |
215
|
|
Line is longer than 80 characters. |
219
|
org/apache/torque/util/Query.java
Error |
Line |
|
Missing a Javadoc comment. |
38
|
|
Missing a Javadoc comment. |
39
|
|
Missing a Javadoc comment. |
40
|
|
Missing a Javadoc comment. |
41
|
|
Missing a Javadoc comment. |
42
|
|
Missing a Javadoc comment. |
43
|
|
Missing a Javadoc comment. |
44
|
|
Missing a Javadoc comment. |
45
|
|
Missing a Javadoc comment. |
46
|
|
Missing a Javadoc comment. |
48
|
|
Name 'selectModifiers' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
48
|
|
Missing a Javadoc comment. |
49
|
|
Name 'selectColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
49
|
|
Missing a Javadoc comment. |
50
|
|
Name 'fromTables' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
50
|
|
Missing a Javadoc comment. |
51
|
|
Name 'whereCriteria' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
51
|
|
Missing a Javadoc comment. |
52
|
|
Name 'orderByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
52
|
|
Missing a Javadoc comment. |
53
|
|
Name 'groupByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
53
|
|
Missing a Javadoc comment. |
54
|
|
Name 'having' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
54
|
|
Missing a Javadoc comment. |
55
|
|
Name 'limit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
55
|
|
Missing a Javadoc comment. |
56
|
|
Name 'preLimit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
56
|
|
Missing a Javadoc comment. |
57
|
|
Name 'postLimit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
57
|
|
Missing a Javadoc comment. |
58
|
|
Name 'rowcount' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
58
|
|
Method 'getSelectModifiers' is not designed for extension - needs to be abstract, final or empty. |
66
|
|
Method 'setSelectModifiers' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
Parameter modifiers should be final. |
76
|
|
Method 'getSelectClause' is not designed for extension - needs to be abstract, final or empty. |
88
|
|
Method 'setSelectClause' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
Parameter columns should be final. |
98
|
|
Method 'getFromClause' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
Method 'setFromClause' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
Parameter tables should be final. |
119
|
|
Method 'getWhereClause' is not designed for extension - needs to be abstract, final or empty. |
131
|
|
Method 'setWhereClause' is not designed for extension - needs to be abstract, final or empty. |
141
|
|
Parameter where should be final. |
141
|
|
Method 'getOrderByClause' is not designed for extension - needs to be abstract, final or empty. |
152
|
|
Method 'getGroupByClause' is not designed for extension - needs to be abstract, final or empty. |
163
|
|
Method 'setHaving' is not designed for extension - needs to be abstract, final or empty. |
174
|
|
Parameter having should be final. |
174
|
|
'having' hides a field. |
174
|
|
Method 'setLimit' is not designed for extension - needs to be abstract, final or empty. |
185
|
|
Parameter limit should be final. |
185
|
|
'limit' hides a field. |
185
|
|
Unused Javadoc tag. |
194
|
|
Method 'setPreLimit' is not designed for extension - needs to be abstract, final or empty. |
196
|
|
Parameter preLimit should be final. |
196
|
|
'preLimit' hides a field. |
196
|
|
Expected @param tag for 'preLimit'. |
196
|
|
Unused Javadoc tag. |
205
|
|
Method 'setPostLimit' is not designed for extension - needs to be abstract, final or empty. |
207
|
|
Parameter postLimit should be final. |
207
|
|
'postLimit' hides a field. |
207
|
|
Expected @param tag for 'postLimit'. |
207
|
|
Method 'setRowcount' is not designed for extension - needs to be abstract, final or empty. |
218
|
|
Parameter rowcount should be final. |
218
|
|
'rowcount' hides a field. |
218
|
|
Method 'getHaving' is not designed for extension - needs to be abstract, final or empty. |
229
|
|
Method 'getLimit' is not designed for extension - needs to be abstract, final or empty. |
240
|
|
Method 'getPostLimit' is not designed for extension - needs to be abstract, final or empty. |
251
|
|
Method 'getPreLimit' is not designed for extension - needs to be abstract, final or empty. |
262
|
|
Method 'hasLimit' is not designed for extension - needs to be abstract, final or empty. |
272
|
|
Method 'getRowcount' is not designed for extension - needs to be abstract, final or empty. |
285
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
295
|
|
Method 'toStringBuffer' is not designed for extension - needs to be abstract, final or empty. |
300
|
|
Missing a Javadoc comment. |
300
|
|
Parameter stmt should be final. |
300
|
|
';' is followed by whitespace. |
319
|
|
Line has trailing spaces. |
365
|
|
Line has trailing spaces. |
379
|
|
Name 'tableName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
381
|
|
Variable 'tableName' must be private and have accessor methods. |
381
|
|
Line has trailing spaces. |
382
|
|
Name 'joinType' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
384
|
|
Variable 'joinType' must be private and have accessor methods. |
384
|
|
Line has trailing spaces. |
385
|
|
Name 'joinCondition' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
387
|
|
Variable 'joinCondition' must be private and have accessor methods. |
387
|
|
Line has trailing spaces. |
388
|
|
Line has trailing spaces. |
399
|
|
Line has trailing spaces. |
403
|
|
Parameter tableName should be final. |
403
|
|
'tableName' hides a field. |
403
|
|
Line has trailing spaces. |
404
|
|
Parameter joinType should be final. |
404
|
|
'joinType' hides a field. |
404
|
|
Line has trailing spaces. |
405
|
|
Parameter joinCondition should be final. |
405
|
|
'joinCondition' hides a field. |
405
|
|
Line has trailing spaces. |
411
|
|
Line has trailing spaces. |
412
|
|
Line has trailing spaces. |
417
|
|
Method 'getJoinCondition' is not designed for extension - needs to be abstract, final or empty. |
417
|
|
Line has trailing spaces. |
421
|
|
Line has trailing spaces. |
426
|
|
Method 'getJoinType' is not designed for extension - needs to be abstract, final or empty. |
426
|
|
Line has trailing spaces. |
430
|
|
Line has trailing spaces. |
436
|
|
Line has trailing spaces. |
438
|
|
Method 'getTableName' is not designed for extension - needs to be abstract, final or empty. |
438
|
|
Line has trailing spaces. |
442
|
|
Line has trailing spaces. |
446
|
|
Line has trailing spaces. |
447
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
447
|
|
'{' should be on a new line. |
450
|
|
Line has trailing spaces. |
451
|
|
'{' should be on a new line. |
454
|
org/apache/torque/util/SQLBuilder.java
Error |
Line |
|
Utility classes should not have a public or default constructor. |
45
|
|
Variable 'log' must be private and have accessor methods. |
49
|
|
Line is longer than 80 characters. |
54
|
|
Line is longer than 80 characters. |
62
|
|
Line has trailing spaces. |
71
|
|
Avoid inline conditionals. |
72
|
|
Line has trailing spaces. |
74
|
|
Line has trailing spaces. |
76
|
|
Line is longer than 80 characters. |
107
|
|
Line has trailing spaces. |
161
|
|
Line has trailing spaces. |
188
|
|
Line has trailing spaces. |
192
|
|
Line has trailing spaces. |
195
|
|
Line is longer than 80 characters. |
195
|
|
Line is longer than 80 characters. |
196
|
|
Expected @param tag for 'dbName'. |
204
|
|
Line has trailing spaces. |
233
|
|
Line has trailing spaces. |
234
|
|
';' is followed by whitespace. |
252
|
|
Line has trailing spaces. |
258
|
|
';' is followed by whitespace. |
259
|
|
Line is longer than 80 characters. |
264
|
|
Line has trailing spaces. |
267
|
|
Line is longer than 80 characters. |
268
|
|
'4' is a magic number. |
268
|
|
Line has trailing spaces. |
283
|
|
Line has trailing spaces. |
297
|
|
Line has trailing spaces. |
329
|
|
Redundant 'final' modifier. |
331
|
|
Expected @param tag for 'dbName'. |
334
|
|
Line has trailing spaces. |
339
|
|
Line has trailing spaces. |
344
|
|
Line is longer than 80 characters. |
344
|
|
Line has trailing spaces. |
347
|
|
Redundant 'final' modifier. |
353
|
|
Line has trailing spaces. |
355
|
|
Line has trailing spaces. |
359
|
|
Line is longer than 80 characters. |
360
|
|
';' is followed by whitespace. |
360
|
|
Line has trailing spaces. |
371
|
|
Redundant 'final' modifier. |
377
|
|
Line has trailing spaces. |
379
|
|
Line has trailing spaces. |
388
|
|
Unused @param tag for 'criteria'. |
391
|
|
Line has trailing spaces. |
395
|
|
Redundant 'final' modifier. |
397
|
|
Expected @param tag for 'db'. |
398
|
|
Expected @param tag for 'dbMap'. |
399
|
|
Expected @param tag for 'dbName'. |
400
|
|
Line has trailing spaces. |
401
|
|
Expected @param tag for 'crit'. |
401
|
|
Line has trailing spaces. |
404
|
|
Expected @param tag for 'qc'. |
404
|
|
';' is followed by whitespace. |
410
|
|
Line has trailing spaces. |
421
|
|
Line has trailing spaces. |
422
|
|
Line is longer than 80 characters. |
426
|
|
Line is longer than 80 characters. |
434
|
|
Line has trailing spaces. |
442
|
|
Line has trailing spaces. |
447
|
|
Unused @param tag for 'criteria'. |
450
|
|
Line has trailing spaces. |
452
|
|
Redundant 'final' modifier. |
454
|
|
Expected @param tag for 'db'. |
455
|
|
Expected @param tag for 'dbMap'. |
456
|
|
Expected @param tag for 'crit'. |
457
|
|
Line has trailing spaces. |
458
|
|
Line has trailing spaces. |
463
|
|
Line has trailing spaces. |
465
|
|
Line has trailing spaces. |
474
|
|
Line has trailing spaces. |
507
|
|
Line has trailing spaces. |
511
|
|
Line is longer than 80 characters. |
528
|
|
Unused @param tag for 'criteria'. |
540
|
|
Line has trailing spaces. |
542
|
|
Redundant 'final' modifier. |
544
|
|
Expected @param tag for 'crit'. |
545
|
|
Line has trailing spaces. |
546
|
|
Unused @param tag for 'criteria'. |
580
|
|
Line has trailing spaces. |
582
|
|
Redundant 'final' modifier. |
584
|
|
Expected @param tag for 'crit'. |
585
|
|
Line has trailing spaces. |
586
|
|
Line is longer than 80 characters. |
620
|
|
Avoid inline conditionals. |
620
|
|
Line has trailing spaces. |
628
|
|
Line has trailing spaces. |
640
|
|
Line has trailing spaces. |
641
|
|
Line contains a tab character. |
656
|
|
Line has trailing spaces. |
667
|
|
Line has trailing spaces. |
670
|
|
Line has trailing spaces. |
672
|
|
Line has trailing spaces. |
673
|
|
Line has trailing spaces. |
685
|
|
Line has trailing spaces. |
686
|
|
Line has trailing spaces. |
688
|
|
Line has trailing spaces. |
690
|
|
'(' is followed by whitespace. |
695
|
|
Line has trailing spaces. |
697
|
|
Line has trailing spaces. |
699
|
|
Unused @param tag for 'tableOrAliasName'. |
710
|
|
Redundant 'final' modifier. |
718
|
|
Expected @param tag for 'tableName'. |
719
|
|
Line has trailing spaces. |
721
|
|
Parameter query should be final. |
721
|
|
Line has trailing spaces. |
723
|
|
Line has trailing spaces. |
727
|
|
Line has trailing spaces. |
731
|
|
Line has trailing spaces. |
734
|
|
Line has trailing spaces. |
743
|
|
Line has trailing spaces. |
759
|
org/apache/torque/util/SqlEnum.java
Error |
Line |
|
Class SqlEnum should be declared as final. |
30
|
|
Missing a Javadoc comment. |
32
|
|
Name 's' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
32
|
|
Line has trailing spaces. |
33
|
|
Line has trailing spaces. |
34
|
|
Missing a Javadoc comment. |
34
|
|
Parameter s should be final. |
34
|
|
's' hides a field. |
34
|
|
Line has trailing spaces. |
35
|
|
Line has trailing spaces. |
39
|
|
Missing a Javadoc comment. |
39
|
|
Line has trailing spaces. |
40
|
|
Line has trailing spaces. |
43
|
|
Line has trailing spaces. |
44
|
|
Missing a Javadoc comment. |
44
|
|
Line has trailing spaces. |
46
|
|
Missing a Javadoc comment. |
46
|
|
Line has trailing spaces. |
48
|
|
Missing a Javadoc comment. |
48
|
|
Missing a Javadoc comment. |
50
|
|
Missing a Javadoc comment. |
52
|
|
Missing a Javadoc comment. |
54
|
|
Missing a Javadoc comment. |
56
|
|
Line has trailing spaces. |
57
|
|
Missing a Javadoc comment. |
58
|
|
Missing a Javadoc comment. |
60
|
|
Missing a Javadoc comment. |
62
|
|
Missing a Javadoc comment. |
64
|
|
Missing a Javadoc comment. |
66
|
|
Missing a Javadoc comment. |
68
|
|
Missing a Javadoc comment. |
70
|
|
Missing a Javadoc comment. |
72
|
|
Missing a Javadoc comment. |
74
|
|
Missing a Javadoc comment. |
76
|
|
Missing a Javadoc comment. |
78
|
|
Missing a Javadoc comment. |
80
|
|
Missing a Javadoc comment. |
82
|
|
Missing a Javadoc comment. |
84
|
|
Missing a Javadoc comment. |
86
|
|
Missing a Javadoc comment. |
88
|
|
Missing a Javadoc comment. |
90
|
|
Missing a Javadoc comment. |
92
|
|
Missing a Javadoc comment. |
94
|
|
Missing a Javadoc comment. |
96
|
|
Missing a Javadoc comment. |
98
|
|
Line has trailing spaces. |
100
|
|
Expected an @return tag. |
106
|
|
Line has trailing spaces. |
106
|
|
Parameter o should be final. |
106
|
|
Line has trailing spaces. |
108
|
|
Line has trailing spaces. |
113
|
|
'!' is followed by whitespace. |
113
|
|
Line has trailing spaces. |
124
|
|
Avoid inline conditionals. |
125
|
|
Line has trailing spaces. |
128
|
|
Expected an @return tag. |
132
|
|
Line has trailing spaces. |
132
|
|
Line has trailing spaces. |
134
|
|
Avoid inline conditionals. |
135
|
org/apache/torque/util/SqlExpression.java
Error |
Line |
|
Utility classes should not have a public or default constructor. |
50
|
|
Parameter column should be final. |
65
|
|
Parameter relatedColumn should be final. |
65
|
|
Parameter column should be final. |
83
|
|
Parameter relatedColumn should be final. |
84
|
|
Parameter ignoreCase should be final. |
85
|
|
Parameter db should be final. |
86
|
|
Avoid inline conditionals. |
88
|
|
'25' is a magic number. |
88
|
|
Parameter column should be final. |
107
|
|
Parameter relatedColumn should be final. |
108
|
|
Parameter ignoreCase should be final. |
109
|
|
Parameter db should be final. |
110
|
|
Parameter whereClause should be final. |
111
|
|
Parameter columnName should be final. |
140
|
|
Parameter criteria should be final. |
141
|
|
Parameter comparison should be final. |
142
|
|
Parameter columnName should be final. |
165
|
|
Parameter criteria should be final. |
166
|
|
Parameter comparison should be final. |
167
|
|
Parameter ignoreCase should be final. |
168
|
|
Parameter db should be final. |
169
|
|
Avoid inline conditionals. |
172
|
|
'40' is a magic number. |
172
|
|
'20' is a magic number. |
172
|
|
Parameter columnName should be final. |
192
|
|
Parameter criteria should be final. |
193
|
|
Parameter comparison should be final. |
194
|
|
Parameter ignoreCase should be final. |
195
|
|
Parameter db should be final. |
196
|
|
Parameter whereClause should be final. |
197
|
|
Parameter columnName should be final. |
318
|
|
Parameter criteria should be final. |
319
|
|
Parameter comparison should be final. |
320
|
|
Parameter ignoreCase should be final. |
321
|
|
Parameter db should be final. |
322
|
|
Parameter columnName should be final. |
351
|
|
Parameter criteria should be final. |
352
|
|
Parameter comparison should be final. |
353
|
|
Parameter ignoreCase should be final. |
354
|
|
Parameter db should be final. |
355
|
|
Parameter whereClause should be final. |
356
|
|
Line has trailing spaces. |
358
|
|
Line has trailing spaces. |
366
|
|
Line has trailing spaces. |
370
|
|
switch without "default" clause. |
395
|
|
switch without "default" clause. |
399
|
|
Parameter columnName should be final. |
453
|
|
Parameter criteria should be final. |
454
|
|
Parameter comparison should be final. |
455
|
|
Parameter ignoreCase should be final. |
456
|
|
Parameter db should be final. |
457
|
|
Parameter columnName should be final. |
480
|
|
Parameter criteria should be final. |
481
|
|
Parameter comparison should be final. |
482
|
|
Parameter ignoreCase should be final. |
483
|
|
Parameter db should be final. |
484
|
|
Parameter whereClause should be final. |
485
|
|
Parameter value should be final. |
539
|
|
Parameter ignoreCase should be final. |
540
|
|
Parameter db should be final. |
541
|
|
Parameter rawText should be final. |
568
|
|
Parameter db should be final. |
568
|
|
'1.1' is a magic number. |
570
|
org/apache/torque/util/Transaction.java
Error |
Line |
|
Line has trailing spaces. |
34
|
|
Line has trailing spaces. |
35
|
|
Utility classes should not have a public or default constructor. |
44
|
|
Parameter dbName should be final. |
60
|
|
Parameter dbName should be final. |
76
|
|
Parameter useTransaction should be final. |
77
|
|
Parameter con should be final. |
104
|
|
Expression can be simplified. |
117
|
|
Parameter con should be final. |
143
|
|
Expression can be simplified. |
157
|
|
Line has trailing spaces. |
181
|
|
Line has trailing spaces. |
185
|
|
Parameter con should be final. |
185
|
|
Line has trailing spaces. |
187
|
|
Line has trailing spaces. |
191
|
|
Line has trailing spaces. |
201
|
org/apache/torque/util/UniqueList.java
Error |
Line |
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
Parameter o should be final. |
35
|
org/apache/torque/util/VillageUtils.java
Error |
Line |
|
Unused import - org.apache.torque.TorqueException. |
28
|
|
Utility classes should not have a public or default constructor. |
41
|
|
Must have at least one statement. |
59
|
|
Must have at least one statement. |
79
|
|
Must have at least one statement. |
100
|
|
Unused @throws tag for 'TorqueException'. |
109
|
|
Expected @throws tag for 'Exception'. |
113
|
|
Line has trailing spaces. |
165
|
|
Expected @throws tag for 'Exception'. |
169
|