PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
522

Files

FilesViolations
org/apache/portals/bridges/beans/TabBean.java 1
org/apache/portals/bridges/common/GenericServletPortlet.java 12
org/apache/portals/bridges/common/ScriptPostProcess.java 7
org/apache/portals/bridges/util/PreferencesHelper.java 1
org/apache/portals/messaging/PortletMessaging.java 1

org/apache/portals/bridges/beans/TabBean.java

ViolationLine
Ensure you override both equals() and hashCode() 52

org/apache/portals/bridges/common/GenericServletPortlet.java

ViolationLine
Avoid instantiating Boolean objects; you can usually invoke Boolean.valueOf() instead. 166
Avoid unnecessary comparisons in boolean expressions 199
Avoid empty 'if' statements 210
Avoid unnecessary return statements 217
Avoid unnecessary comparisons in boolean expressions 231
Avoid unnecessary return statements 249
Avoid unnecessary comparisons in boolean expressions 271
Avoid unnecessary return statements 287
Avoid unnecessary comparisons in boolean expressions 309
Avoid unnecessary return statements 326
Avoid unnecessary comparisons in boolean expressions 348
Avoid unnecessary return statements 365

org/apache/portals/bridges/common/ScriptPostProcess.java

ViolationLine
Avoid if (x != y) ..; else ..; 50
The same String literal appears 5 times in this file; the first occurrence is on line 79 79
Avoid really long methods. 97
Avoid using 'if...else' statements without curly braces 139
Avoid using if statements without curly braces 140
Avoid unnecessary comparisons in boolean expressions 162
Avoid unnecessary comparisons in boolean expressions 166

org/apache/portals/bridges/util/PreferencesHelper.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. 69

org/apache/portals/messaging/PortletMessaging.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. 107