PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
1214

Files

FilesViolations
com/ibatis/jpetstore/domain/CartItem.java 1
com/ibatis/jpetstore/domain/LineItem.java 1
com/ibatis/jpetstore/domain/Order.java 1
com/ibatis/jpetstore/persistence/DaoConfig.java 1
com/ibatis/jpetstore/presentation/CartBean.java 1
com/ibatis/jpetstore/presentation/OrderBean.java 3
com/ibatis/struts/BaseBean.java 1
com/ibatis/struts/BeanAction.java 1
com/ibatis/struts/httpmap/CookieMap.java 1
com/ibatis/struts/httpmap/ParameterMap.java 1
com/ibatis/struts/httpmap/RequestMap.java 1
com/ibatis/struts/httpmap/SessionMap.java 1

com/ibatis/jpetstore/domain/CartItem.java

ViolationLine
Avoid if (x != y) ..; else ..; 73

com/ibatis/jpetstore/domain/LineItem.java

ViolationLine
Avoid if (x != y) ..; else ..; 106

com/ibatis/jpetstore/domain/Order.java

ViolationLine
A high number of public methods and attributes in an object can indicate the class may need to be broken up for exhaustive testing may prove difficult. 329

com/ibatis/jpetstore/persistence/DaoConfig.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. 49

com/ibatis/jpetstore/presentation/CartBean.java

ViolationLine
Avoid empty catch blocks 110

com/ibatis/jpetstore/presentation/OrderBean.java

ViolationLine
Avoid if (x != y) ..; else ..; 128
Avoid if (x != y) ..; else ..; 145
Avoid if (x != y) ..; else ..; 147

com/ibatis/struts/BaseBean.java

ViolationLine
The same String literal appears 4 times in this file; the first occurrence is on line 62 62

com/ibatis/struts/BeanAction.java

ViolationLine
Deeply nested if..then statements are hard to read 147

com/ibatis/struts/httpmap/CookieMap.java

ViolationLine
No need to import a type that's in the same package 18

com/ibatis/struts/httpmap/ParameterMap.java

ViolationLine
No need to import a type that's in the same package 18

com/ibatis/struts/httpmap/RequestMap.java

ViolationLine
No need to import a type that's in the same package 18

com/ibatis/struts/httpmap/SessionMap.java

ViolationLine
No need to import a type that's in the same package 18