PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
2692

Files

FilesViolations
org/apache/portals/bridges/struts/PortletRequestProcessor.java 2
org/apache/portals/bridges/struts/PortletServlet.java 10
org/apache/portals/bridges/struts/PortletServletConfigImpl.java 1
org/apache/portals/bridges/struts/PortletServletContextImpl.java 4
org/apache/portals/bridges/struts/PortletServletRequestDispatcher.java 5
org/apache/portals/bridges/struts/PortletServletRequestWrapper.java 6
org/apache/portals/bridges/struts/PortletServletResponseWrapper.java 5
org/apache/portals/bridges/struts/PortletTilesRequestProcessor.java 2
org/apache/portals/bridges/struts/StrutsPortlet.java 28
org/apache/portals/bridges/struts/StrutsPortletURL.java 6
org/apache/portals/bridges/struts/config/AbstractConfigComponent.java 1
org/apache/portals/bridges/struts/config/PortletURLTypes.java 2
org/apache/portals/bridges/struts/config/RenderContextAttributes.java 2
org/apache/portals/bridges/struts/config/StrutsPortletConfig.java 1
org/apache/portals/bridges/struts/taglib/ELFormTag.java 1
org/apache/portals/bridges/struts/taglib/ELImageTag.java 1
org/apache/portals/bridges/struts/taglib/ELImgTag.java 1
org/apache/portals/bridges/struts/taglib/ELLinkTag.java 1
org/apache/portals/bridges/struts/taglib/ELRewriteTag.java 1
org/apache/portals/bridges/struts/taglib/FormTag.java 1
org/apache/portals/bridges/struts/taglib/ImageTag.java 1
org/apache/portals/bridges/struts/taglib/ImgTag.java 1
org/apache/portals/bridges/struts/taglib/LinkTag.java 1
org/apache/portals/bridges/struts/taglib/RewriteTag.java 1
org/apache/portals/bridges/struts/taglib/ScriptTag.java 3
org/apache/portals/bridges/struts/taglib/TagsSupport.java 4

org/apache/portals/bridges/struts/PortletRequestProcessor.java

ViolationLine
Avoid reassigning parameters such as 'response' 40
Avoid using 'if...else' statements without curly braces 63

org/apache/portals/bridges/struts/PortletServlet.java

ViolationLine
The class 'PortletServlet' has a Cyclomatic Complexity of 4 (Highest = 12). 44
The method 'performActionRenderRequest' has a Cyclomatic Complexity of 12. 124
Avoid if (x != y) ..; else ..; 148
Deeply nested if..then statements are hard to read 149
Deeply nested if..then statements are hard to read 157
Avoid using if statements without curly braces 163
Avoid using if statements without curly braces 165
Avoid using if statements without curly braces 168
Avoid using 'if...else' statements without curly braces 175
Avoid using 'if...else' statements without curly braces 178

org/apache/portals/bridges/struts/PortletServletConfigImpl.java

ViolationLine
Avoid using if statements without curly braces 48

org/apache/portals/bridges/struts/PortletServletContextImpl.java

ViolationLine
Avoid using 'if...else' statements without curly braces 55
Avoid using 'if...else' statements without curly braces 57
Avoid using if statements without curly braces 82
Avoid using if statements without curly braces 94

org/apache/portals/bridges/struts/PortletServletRequestDispatcher.java

ViolationLine
The class 'PortletServletRequestDispatcher' has a Cyclomatic Complexity of 3 (Highest = 10). 40
Avoid unused formal parameters such as 'include' 55
The method 'invoke' has a Cyclomatic Complexity of 10. 55
Avoid using if statements without curly braces 86
Deeply nested if..then statements are hard to read 86

org/apache/portals/bridges/struts/PortletServletRequestWrapper.java

ViolationLine
Avoid unused private fields such as 'log' 34
Avoid if (x != y) ..; else ..; 79
Avoid using 'if...else' statements without curly braces 85
Avoid if (x != y) ..; else ..; 94
Avoid using 'if...else' statements without curly braces 95
Avoid using 'if...else' statements without curly braces 97

org/apache/portals/bridges/struts/PortletServletResponseWrapper.java

ViolationLine
Avoid unused private fields such as 'log' 35
Avoid using 'if...else' statements without curly braces 50
Avoid using 'if...else' statements without curly braces 52
Avoid using 'if...else' statements without curly braces 61
Avoid using 'if...else' statements without curly braces 63

org/apache/portals/bridges/struts/PortletTilesRequestProcessor.java

ViolationLine
Avoid reassigning parameters such as 'response' 40
Avoid using 'if...else' statements without curly braces 63

org/apache/portals/bridges/struts/StrutsPortlet.java

ViolationLine
The class 'StrutsPortlet' has a Cyclomatic Complexity of 3 (Highest = 27). 49
The method 'init' has a Cyclomatic Complexity of 13. 119
Avoid using if statements without curly braces 123
Avoid using 'if...else' statements without curly braces 140
Avoid using if statements without curly braces 144
Avoid using if statements without curly braces 150
Avoid using if statements without curly braces 171
Avoid using if statements without curly braces 173
Avoid using if statements without curly braces 175
Avoid using if statements without curly braces 177
Avoid really long methods. 282
The method 'processRequest' has a Cyclomatic Complexity of 27. 282
Avoid using 'if...else' statements without curly braces 327
Avoid using if statements without curly braces 333
Avoid using if statements without curly braces 379
Avoid using if statements without curly braces 384
Avoid if (x != y) ..; else ..; 390
Avoid using if statements without curly braces 397
Avoid empty catch blocks 410
Avoid if (x != y) ..; else ..; 414
Avoid using if statements without curly braces 417
Avoid using if statements without curly braces 430
Avoid using if statements without curly braces 437
Avoid using if statements without curly braces 448
Avoid using if statements without curly braces 459
Avoid using if statements without curly braces 462
Avoid using if statements without curly braces 468
Avoid using 'for' statements without curly braces 478

org/apache/portals/bridges/struts/StrutsPortletURL.java

ViolationLine
Avoid reassigning parameters such as 'pageURL' 44
Avoid using 'if...else' statements without curly braces 50
Avoid using 'if...else' statements without curly braces 52
Avoid using if statements without curly braces 57
Avoid using if statements without curly braces 64
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. 79

org/apache/portals/bridges/struts/config/AbstractConfigComponent.java

ViolationLine
Avoid using if statements without curly braces 32

org/apache/portals/bridges/struts/config/PortletURLTypes.java

ViolationLine
Ensure you override both equals() and hashCode() 54
Avoid if (x != y) ..; else ..; 56

org/apache/portals/bridges/struts/config/RenderContextAttributes.java

ViolationLine
The class 'RenderContextAttributes' has a Cyclomatic Complexity of 3 (Highest = 13). 13
The method 'saveAttributes' has a Cyclomatic Complexity of 13. 149

org/apache/portals/bridges/struts/config/StrutsPortletConfig.java

ViolationLine
Avoid empty catch blocks 48

org/apache/portals/bridges/struts/taglib/ELFormTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ELImageTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ELImgTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ELLinkTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ELRewriteTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/FormTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ImageTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ImgTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/LinkTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/RewriteTag.java

ViolationLine
Avoid unused imports such as 'ServletRequest' 18

org/apache/portals/bridges/struts/taglib/ScriptTag.java

ViolationLine
Avoid if (x != y) ..; else ..; 76
Avoid using 'if...else' statements without curly braces 77
Avoid using 'if...else' statements without curly braces 79

org/apache/portals/bridges/struts/taglib/TagsSupport.java

ViolationLine
Avoid reassigning parameters such as 'url' 50
Avoid reassigning parameters such as 'type' 107
Avoid reassigning parameters such as 'url' 107
Avoid reassigning parameters such as 'formStartElement' 146