The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
143 | 38 | 0 | 0 |
Bug | Category | Details | Line |
---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 169 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.shale.usecases.rolodex.GenericComparator.log isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 48 |
Possible null pointer dereference of col1 in org.apache.shale.usecases.rolodex.GenericComparator.compare(Object, Object) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 149 |
Possible null pointer dereference of col2 in org.apache.shale.usecases.rolodex.GenericComparator.compare(Object, Object) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 149 |
org.apache.shale.usecases.rolodex.GenericComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Dead store of null to sobj in org.apache.shale.usecases.rolodex.HeaderSorter.restoreState(FacesContext, Object) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 66 |
org.apache.shale.usecases.rolodex.HeaderSorter.saveState(FacesContext) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 80 |
Bug | Category | Details | Line |
---|---|---|---|
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.shale.usecases.rolodex.HeaderSorter in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 157 |
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.shale.usecases.rolodex.HeaderSorter in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | BC_UNCONFIRMED_CAST | 210 |
org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(FacesContext, UIData, HeaderSorter) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 122 |
Dead store of null to data in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 191 |
Dead store of null to writer in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeBegin(FacesContext, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 190 |
Dead store of null to url in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 245 |
Dead store of null to writer in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 250 |
Dead store of null to params in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(FacesContext, UIData, HeaderSorter) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 134 |
Dead store of null to tag in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(FacesContext, UIData, HeaderSorter) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 133 |
Dead store of null to value in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(FacesContext, UIData, HeaderSorter) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 128 |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.shale.usecases.rolodex.RolodexDao.TAB_INDEX should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 77 |
Bug | Category | Details | Line |
---|---|---|---|
Dead store of null to data in org.apache.shale.usecases.rolodex.WebPagerRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 117 |
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.encodeEnd(FacesContext, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 116 |
Dead store of null to params in org.apache.shale.usecases.rolodex.WebPagerRenderer.getPageIndex(FacesContext, UIData) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 377 |
Dead store of null to tag in org.apache.shale.usecases.rolodex.WebPagerRenderer.getPageIndex(FacesContext, UIData) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 376 |
Dead store of null to p in org.apache.shale.usecases.rolodex.WebPagerRenderer.writeNextPageLink(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 331 |
Dead store of null to styleClass in org.apache.shale.usecases.rolodex.WebPagerRenderer.writeNextPageLink(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 333 |
Dead store of null to url in org.apache.shale.usecases.rolodex.WebPagerRenderer.writeNextPageLink(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 326 |
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.writeNextPageLink(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 332 |
Dead store of null to styleClass in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageCaption(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 220 |
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageCaption(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 219 |
Dead store of null to fmt in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageLinks(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 280 |
Dead store of null to pi in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageLinks(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 278 |
Dead store of null to url in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageLinks(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 279 |
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageLinks(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 281 |
Dead store of null to p in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePrevPageLink(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 174 |
Dead store of null to styleClass in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePrevPageLink(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 176 |
Dead store of null to url in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePrevPageLink(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 169 |
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePrevPageLink(FacesContext, UIData, UIComponent) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 175 |
Bug | Category | Details | Line |
---|---|---|---|
Should org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfo be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
Bug | Category | Details | Line |
---|---|---|---|
org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfoIterator.next() can't throw NoSuchElement exception | BAD_PRACTICE | IT_NO_SUCH_ELEMENT | 587-592 |