FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

ClassesBugsErrorsMissing Classes
1433800

Files

ClassBugs
org.apache.shale.usecases.rolodex.Contact1
org.apache.shale.usecases.rolodex.GenericComparator4
org.apache.shale.usecases.rolodex.HeaderSorter2
org.apache.shale.usecases.rolodex.HeaderSorterRenderer10
org.apache.shale.usecases.rolodex.RolodexDao1
org.apache.shale.usecases.rolodex.WebPagerRenderer18
org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfo1
org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfoIterator1

org.apache.shale.usecases.rolodex.Contact

BugCategoryDetailsLine
Use of non-localized String.toUpperCase() or String.toLowerCaseI18NDM_CONVERT_CASE169

org.apache.shale.usecases.rolodex.GenericComparator

BugCategoryDetailsLine
org.apache.shale.usecases.rolodex.GenericComparator.log isn't final but should beMALICIOUS_CODEMS_SHOULD_BE_FINAL48
Possible null pointer dereference of col1 in org.apache.shale.usecases.rolodex.GenericComparator.compare(Object, Object)CORRECTNESSNP_NULL_ON_SOME_PATH149
Possible null pointer dereference of col2 in org.apache.shale.usecases.rolodex.GenericComparator.compare(Object, Object)CORRECTNESSNP_NULL_ON_SOME_PATH149
org.apache.shale.usecases.rolodex.GenericComparator implements Comparator but not SerializableBAD_PRACTICESE_COMPARATOR_SHOULD_BE_SERIALIZABLENot available

org.apache.shale.usecases.rolodex.HeaderSorter

BugCategoryDetailsLine
Dead store of null to sobj in org.apache.shale.usecases.rolodex.HeaderSorter.restoreState(FacesContext, Object)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL66
org.apache.shale.usecases.rolodex.HeaderSorter.saveState(FacesContext) invokes inefficient Boolean constructor; use Boolean.valueOf(...) insteadPERFORMANCEDM_BOOLEAN_CTOR80

org.apache.shale.usecases.rolodex.HeaderSorterRenderer

BugCategoryDetailsLine
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.shale.usecases.rolodex.HeaderSorter in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeBegin(FacesContext, UIComponent)STYLEBC_UNCONFIRMED_CAST157
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to org.apache.shale.usecases.rolodex.HeaderSorter in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeEnd(FacesContext, UIComponent)STYLEBC_UNCONFIRMED_CAST210
org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(FacesContext, UIData, HeaderSorter) might ignore java.lang.ExceptionBAD_PRACTICEDE_MIGHT_IGNORE122
Dead store of null to data in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeBegin(FacesContext, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL191
Dead store of null to writer in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeBegin(FacesContext, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL190
Dead store of null to url in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeEnd(FacesContext, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL245
Dead store of null to writer in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.encodeEnd(FacesContext, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL250
Dead store of null to params in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(FacesContext, UIData, HeaderSorter)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL134
Dead store of null to tag in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(FacesContext, UIData, HeaderSorter)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL133
Dead store of null to value in org.apache.shale.usecases.rolodex.HeaderSorterRenderer.wasSelected(FacesContext, UIData, HeaderSorter)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL128

org.apache.shale.usecases.rolodex.RolodexDao

BugCategoryDetailsLine
org.apache.shale.usecases.rolodex.RolodexDao.TAB_INDEX should be package protectedMALICIOUS_CODEMS_PKGPROTECT77

org.apache.shale.usecases.rolodex.WebPagerRenderer

BugCategoryDetailsLine
Dead store of null to data in org.apache.shale.usecases.rolodex.WebPagerRenderer.encodeEnd(FacesContext, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL117
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.encodeEnd(FacesContext, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL116
Dead store of null to params in org.apache.shale.usecases.rolodex.WebPagerRenderer.getPageIndex(FacesContext, UIData)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL377
Dead store of null to tag in org.apache.shale.usecases.rolodex.WebPagerRenderer.getPageIndex(FacesContext, UIData)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL376
Dead store of null to p in org.apache.shale.usecases.rolodex.WebPagerRenderer.writeNextPageLink(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL331
Dead store of null to styleClass in org.apache.shale.usecases.rolodex.WebPagerRenderer.writeNextPageLink(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL333
Dead store of null to url in org.apache.shale.usecases.rolodex.WebPagerRenderer.writeNextPageLink(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL326
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.writeNextPageLink(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL332
Dead store of null to styleClass in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageCaption(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL220
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageCaption(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL219
Dead store of null to fmt in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageLinks(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL280
Dead store of null to pi in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageLinks(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL278
Dead store of null to url in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageLinks(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL279
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePageLinks(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL281
Dead store of null to p in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePrevPageLink(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL174
Dead store of null to styleClass in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePrevPageLink(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL176
Dead store of null to url in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePrevPageLink(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL169
Dead store of null to writer in org.apache.shale.usecases.rolodex.WebPagerRenderer.writePrevPageLink(FacesContext, UIData, UIComponent)STYLEDLS_DEAD_LOCAL_STORE_OF_NULL175

org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfo

BugCategoryDetailsLine
Should org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfo be a _static_ inner class?PERFORMANCESIC_INNER_SHOULD_BE_STATICNot available

org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfoIterator

BugCategoryDetailsLine
org.apache.shale.usecases.rolodex.WebPagerRenderer$PageInfoIterator.next() can't throw NoSuchElement exceptionBAD_PRACTICEIT_NO_SUCH_ELEMENT587-592